mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
82 lines
2.7 KiB
Python
82 lines
2.7 KiB
Python
"""Regression tests for profile-scoped skills_tool path resolution."""
|
|
|
|
import importlib
|
|
import json
|
|
from pathlib import Path
|
|
|
|
|
|
def _write_skill(root: Path, category: str, name: str, description: str) -> Path:
|
|
skill_dir = root / "skills" / category / name
|
|
skill_dir.mkdir(parents=True)
|
|
(skill_dir / "SKILL.md").write_text(
|
|
f"---\n"
|
|
f"name: {name}\n"
|
|
f"description: {description}\n"
|
|
f"---\n\n"
|
|
f"# {name}\n\n"
|
|
f"Loaded from {description}.\n",
|
|
encoding="utf-8",
|
|
)
|
|
return skill_dir
|
|
|
|
|
|
def _reload_skills_tool(import_home: Path, monkeypatch):
|
|
monkeypatch.setenv("HERMES_HOME", str(import_home))
|
|
import tools.skills_tool as skills_tool
|
|
|
|
return importlib.reload(skills_tool)
|
|
|
|
|
|
def test_skill_view_uses_live_profile_home_after_module_import(tmp_path, monkeypatch):
|
|
"""skill_view should not stay pinned to HERMES_HOME from import time."""
|
|
default_home = tmp_path / "default-home"
|
|
profile_home = tmp_path / "profiles" / "orchestrator"
|
|
_write_skill(default_home, "autonomous-ai-agents", "default-only", "default home")
|
|
profile_skill_dir = _write_skill(
|
|
profile_home,
|
|
"software-development",
|
|
"kanban-orchestrator-operations",
|
|
"orchestrator profile",
|
|
)
|
|
|
|
skills_tool = _reload_skills_tool(default_home, monkeypatch)
|
|
assert skills_tool.SKILLS_DIR == default_home / "skills"
|
|
|
|
monkeypatch.setenv("HERMES_HOME", str(profile_home))
|
|
|
|
result = json.loads(
|
|
skills_tool.skill_view("kanban-orchestrator-operations", preprocess=False)
|
|
)
|
|
|
|
assert result["success"] is True
|
|
assert result["name"] == "kanban-orchestrator-operations"
|
|
assert Path(result["skill_dir"]) == profile_skill_dir
|
|
assert "orchestrator profile" in result["content"]
|
|
|
|
|
|
def test_explicit_skills_dir_monkeypatch_still_wins(tmp_path, monkeypatch):
|
|
"""Existing tests can still override tools.skills_tool.SKILLS_DIR directly."""
|
|
default_home = tmp_path / "default-home"
|
|
profile_home = tmp_path / "profiles" / "orchestrator"
|
|
patched_root = tmp_path / "patched"
|
|
patched_skill_dir = _write_skill(
|
|
patched_root,
|
|
"software-development",
|
|
"patched-skill",
|
|
"patched skills dir",
|
|
)
|
|
_write_skill(
|
|
profile_home,
|
|
"software-development",
|
|
"profile-skill",
|
|
"orchestrator profile",
|
|
)
|
|
|
|
skills_tool = _reload_skills_tool(default_home, monkeypatch)
|
|
monkeypatch.setenv("HERMES_HOME", str(profile_home))
|
|
monkeypatch.setattr(skills_tool, "SKILLS_DIR", patched_root / "skills")
|
|
|
|
result = json.loads(skills_tool.skill_view("patched-skill", preprocess=False))
|
|
|
|
assert result["success"] is True
|
|
assert Path(result["skill_dir"]) == patched_skill_dir
|