mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
55 lines
2 KiB
Python
55 lines
2 KiB
Python
"""Tests for Singularity/Apptainer preflight availability check.
|
|
|
|
Verifies that a clear error is raised when neither apptainer nor
|
|
singularity is installed, instead of a cryptic FileNotFoundError.
|
|
|
|
See: https://github.com/NousResearch/hermes-agent/issues/1511
|
|
"""
|
|
|
|
import subprocess
|
|
from unittest.mock import patch, MagicMock
|
|
|
|
import pytest
|
|
|
|
from tools.environments.singularity import (
|
|
_find_singularity_executable,
|
|
_ensure_singularity_available,
|
|
)
|
|
|
|
|
|
class TestFindSingularityExecutable:
|
|
"""_find_singularity_executable resolution tests."""
|
|
|
|
def test_prefers_apptainer(self):
|
|
"""When both are available, apptainer should be preferred."""
|
|
def which_both(name):
|
|
return f"/usr/bin/{name}" if name in {"apptainer", "singularity"} else None
|
|
|
|
with patch("shutil.which", side_effect=which_both):
|
|
assert _find_singularity_executable() == "apptainer"
|
|
|
|
|
|
def test_raises_when_neither_found(self):
|
|
"""Must raise RuntimeError with install instructions."""
|
|
with patch("shutil.which", return_value=None):
|
|
with pytest.raises(RuntimeError, match="Neither.*apptainer.*nor.*singularity"):
|
|
_find_singularity_executable()
|
|
|
|
|
|
class TestEnsureSingularityAvailable:
|
|
"""_ensure_singularity_available preflight tests."""
|
|
|
|
def test_returns_executable_on_success(self):
|
|
"""Returns the executable name when version check passes."""
|
|
fake_result = MagicMock(returncode=0, stderr="")
|
|
|
|
with patch("shutil.which", side_effect=lambda n: "/usr/bin/apptainer" if n == "apptainer" else None), \
|
|
patch("subprocess.run", return_value=fake_result):
|
|
assert _ensure_singularity_available() == "apptainer"
|
|
|
|
|
|
def test_raises_when_not_installed(self):
|
|
"""Raises RuntimeError when neither executable exists."""
|
|
with patch("shutil.which", return_value=None):
|
|
with pytest.raises(RuntimeError, match="Neither.*apptainer.*nor.*singularity"):
|
|
_ensure_singularity_available()
|