mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
85 lines
3.1 KiB
Python
85 lines
3.1 KiB
Python
"""Tests for Chromium-presence detection in browser_tool.
|
|
|
|
Regression guard for the "browser tool advertised but Chromium missing"
|
|
class of bug — where ``agent-browser`` CLI is discoverable but no
|
|
Chromium build is on disk, causing every browser_* tool call to hang
|
|
for the full command timeout before surfacing a useless error.
|
|
"""
|
|
|
|
import os
|
|
|
|
import pytest
|
|
|
|
from tools import browser_tool as bt
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _reset_chromium_cache():
|
|
bt._cached_chromium_installed = None
|
|
yield
|
|
bt._cached_chromium_installed = None
|
|
|
|
|
|
class TestChromiumSearchRoots:
|
|
def test_respects_playwright_browsers_path_env(self, monkeypatch, tmp_path):
|
|
monkeypatch.setenv("PLAYWRIGHT_BROWSERS_PATH", str(tmp_path))
|
|
roots = bt._chromium_search_roots()
|
|
assert str(tmp_path) == roots[0]
|
|
|
|
|
|
def test_always_includes_default_ms_playwright_cache(self, monkeypatch):
|
|
monkeypatch.delenv("PLAYWRIGHT_BROWSERS_PATH", raising=False)
|
|
roots = bt._chromium_search_roots()
|
|
home = os.path.expanduser("~")
|
|
assert any(r == os.path.join(home, ".cache", "ms-playwright") for r in roots)
|
|
|
|
|
|
class TestChromiumInstalled:
|
|
def test_true_when_plain_chromium_on_path(self, monkeypatch):
|
|
monkeypatch.delenv("AGENT_BROWSER_EXECUTABLE_PATH", raising=False)
|
|
monkeypatch.setattr(
|
|
bt.shutil,
|
|
"which",
|
|
lambda name: "/usr/bin/chromium" if name == "chromium" else None,
|
|
)
|
|
|
|
assert bt._chromium_installed() is True
|
|
|
|
|
|
def test_result_cached(self, monkeypatch, tmp_path):
|
|
monkeypatch.setenv("PLAYWRIGHT_BROWSERS_PATH", str(tmp_path))
|
|
(tmp_path / "chromium-1208").mkdir()
|
|
assert bt._chromium_installed() is True
|
|
# Delete after first call — cached True should still return True.
|
|
(tmp_path / "chromium-1208").rmdir()
|
|
assert bt._chromium_installed() is True
|
|
|
|
|
|
class TestCheckBrowserRequirementsChromium:
|
|
|
|
def test_local_mode_with_chromium_returns_true(self, monkeypatch, tmp_path):
|
|
monkeypatch.setattr(bt, "_is_camofox_mode", lambda: False)
|
|
monkeypatch.setattr(bt, "_find_agent_browser", lambda **_kw: "/usr/local/bin/agent-browser")
|
|
monkeypatch.setattr(bt, "_requires_real_termux_browser_install", lambda _: False)
|
|
monkeypatch.setattr(bt, "_get_cloud_provider", lambda: None)
|
|
monkeypatch.setenv("PLAYWRIGHT_BROWSERS_PATH", str(tmp_path))
|
|
(tmp_path / "chromium-1208").mkdir()
|
|
|
|
assert bt.check_browser_requirements() is True
|
|
|
|
|
|
def test_camofox_mode_does_not_require_chromium(self, monkeypatch, tmp_path):
|
|
monkeypatch.setattr(bt, "_is_camofox_mode", lambda: True)
|
|
# Even with no chromium on disk, camofox drives its own backend.
|
|
monkeypatch.setenv("PLAYWRIGHT_BROWSERS_PATH", str(tmp_path))
|
|
monkeypatch.setattr("os.path.expanduser", lambda p: str(tmp_path / "fakehome"))
|
|
|
|
assert bt.check_browser_requirements() is True
|
|
|
|
|
|
class TestRunBrowserCommandChromiumGuard:
|
|
"""Verify _run_browser_command fails fast (no timeout hang) when
|
|
Chromium is missing in local mode.
|
|
"""
|
|
|
|
|