mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
89 lines
3.3 KiB
Python
89 lines
3.3 KiB
Python
"""Tests for gated Chromium-binary auto-install on local cold start."""
|
|
|
|
from types import SimpleNamespace
|
|
|
|
import pytest
|
|
|
|
import tools.browser_tool as bt
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _reset_state():
|
|
bt._chromium_autoinstall_attempted = False
|
|
bt._cached_chromium_installed = None
|
|
yield
|
|
bt._chromium_autoinstall_attempted = False
|
|
bt._cached_chromium_installed = None
|
|
|
|
|
|
def _no_subprocess(monkeypatch):
|
|
calls = []
|
|
monkeypatch.setattr(bt.subprocess, "run", lambda *a, **k: calls.append((a, k)))
|
|
return calls
|
|
|
|
|
|
class TestGating:
|
|
def test_disabled_lazy_installs_skips(self, monkeypatch):
|
|
monkeypatch.setattr(bt, "_running_in_docker", lambda: False)
|
|
monkeypatch.setattr("tools.lazy_deps._allow_lazy_installs", lambda: False)
|
|
calls = _no_subprocess(monkeypatch)
|
|
assert bt._maybe_autoinstall_chromium() is False
|
|
assert calls == []
|
|
|
|
def test_docker_skips(self, monkeypatch):
|
|
monkeypatch.setattr(bt, "_running_in_docker", lambda: True)
|
|
calls = _no_subprocess(monkeypatch)
|
|
assert bt._maybe_autoinstall_chromium() is False
|
|
assert calls == []
|
|
|
|
|
|
class TestInstall:
|
|
def test_success_installs_binary_only_and_rechecks(self, monkeypatch):
|
|
monkeypatch.setattr(bt, "_running_in_docker", lambda: False)
|
|
monkeypatch.setattr("tools.lazy_deps._allow_lazy_installs", lambda: True)
|
|
monkeypatch.setattr(bt, "_find_agent_browser", lambda: "/x/agent-browser")
|
|
monkeypatch.setattr(bt, "_build_browser_env", lambda: {})
|
|
monkeypatch.setattr(bt, "_chromium_installed", lambda: True)
|
|
|
|
captured = {}
|
|
|
|
def fake_run(cmd, **kw):
|
|
captured["cmd"] = cmd
|
|
return SimpleNamespace(returncode=0, stdout="", stderr="")
|
|
|
|
monkeypatch.setattr(bt.subprocess, "run", fake_run)
|
|
|
|
assert bt._maybe_autoinstall_chromium() is True
|
|
assert captured["cmd"] == ["/x/agent-browser", "install"]
|
|
assert "--with-deps" not in captured["cmd"]
|
|
|
|
|
|
def test_nonzero_exit_returns_false(self, monkeypatch):
|
|
monkeypatch.setattr(bt, "_running_in_docker", lambda: False)
|
|
monkeypatch.setattr("tools.lazy_deps._allow_lazy_installs", lambda: True)
|
|
monkeypatch.setattr(bt, "_find_agent_browser", lambda: "/x/agent-browser")
|
|
monkeypatch.setattr(bt, "_build_browser_env", lambda: {})
|
|
monkeypatch.setattr(
|
|
bt.subprocess, "run",
|
|
lambda *a, **k: SimpleNamespace(returncode=1, stdout="", stderr="boom"),
|
|
)
|
|
assert bt._maybe_autoinstall_chromium() is False
|
|
|
|
|
|
class TestOneShot:
|
|
def test_second_call_does_not_reinstall(self, monkeypatch):
|
|
monkeypatch.setattr(bt, "_running_in_docker", lambda: False)
|
|
monkeypatch.setattr("tools.lazy_deps._allow_lazy_installs", lambda: True)
|
|
monkeypatch.setattr(bt, "_find_agent_browser", lambda: "/x/agent-browser")
|
|
monkeypatch.setattr(bt, "_build_browser_env", lambda: {})
|
|
monkeypatch.setattr(bt, "_chromium_installed", lambda: True)
|
|
|
|
runs = []
|
|
monkeypatch.setattr(
|
|
bt.subprocess, "run",
|
|
lambda *a, **k: runs.append(1) or SimpleNamespace(returncode=0, stdout="", stderr=""),
|
|
)
|
|
|
|
assert bt._maybe_autoinstall_chromium() is True
|
|
assert bt._maybe_autoinstall_chromium() is True
|
|
assert len(runs) == 1
|