mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
223 lines
7.1 KiB
Python
223 lines
7.1 KiB
Python
"""Inbound dispatch + dedup tests for PhotonAdapter.
|
|
|
|
These bypass the loopback HTTP stream — they call ``_dispatch_inbound`` /
|
|
``_on_inbound_line`` / ``_is_duplicate`` directly, exercising the
|
|
sidecar-event parsing without spawning the Node sidecar or binding ports.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import asyncio
|
|
import base64
|
|
import json
|
|
from pathlib import Path
|
|
from typing import Any, Dict, List
|
|
|
|
import pytest
|
|
|
|
from gateway.config import Platform, PlatformConfig
|
|
from gateway.platforms.base import MessageEvent, MessageType
|
|
from plugins.platforms.photon.adapter import PhotonAdapter
|
|
|
|
|
|
def _make_adapter(monkeypatch: pytest.MonkeyPatch) -> PhotonAdapter:
|
|
monkeypatch.setenv("PHOTON_PROJECT_ID", "test-project-id")
|
|
monkeypatch.setenv("PHOTON_PROJECT_SECRET", "test-project-secret")
|
|
cfg = PlatformConfig(enabled=True, token="", extra={})
|
|
return PhotonAdapter(cfg)
|
|
|
|
|
|
def _capture(adapter: PhotonAdapter, monkeypatch: pytest.MonkeyPatch) -> List[MessageEvent]:
|
|
captured: List[MessageEvent] = []
|
|
|
|
async def fake_handle(event: MessageEvent) -> None:
|
|
captured.append(event)
|
|
|
|
monkeypatch.setattr(adapter, "handle_message", fake_handle)
|
|
return captured
|
|
|
|
|
|
def _dm_event(text: str, msg_id: str = "spc-msg-abc") -> Dict[str, Any]:
|
|
return {
|
|
"messageId": msg_id,
|
|
"platform": "iMessage",
|
|
"space": {"id": "+15551234567", "type": "dm", "phone": "+15551234567"},
|
|
"sender": {"id": "+15551234567"},
|
|
"content": {"type": "text", "text": text},
|
|
"timestamp": "2026-05-14T19:06:32.000Z",
|
|
}
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_dispatch_text_dm(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
adapter = _make_adapter(monkeypatch)
|
|
captured = _capture(adapter, monkeypatch)
|
|
|
|
await adapter._dispatch_inbound(_dm_event("hello world"))
|
|
|
|
assert len(captured) == 1
|
|
event = captured[0]
|
|
assert event.text == "hello world"
|
|
assert event.message_type == MessageType.TEXT
|
|
assert event.message_id == "spc-msg-abc"
|
|
src = event.source
|
|
assert src is not None
|
|
assert src.platform == Platform("photon")
|
|
assert src.chat_id == "+15551234567"
|
|
assert src.chat_type == "dm"
|
|
assert src.user_id == "+15551234567"
|
|
|
|
|
|
# A real 1x1 transparent PNG (passes base.py's _looks_like_image magic check).
|
|
_PNG_1X1_B64 = (
|
|
"iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYPhf"
|
|
"DwAChwGA60e6kgAAAABJRU5ErkJggg=="
|
|
)
|
|
|
|
|
|
def _attachment_event(
|
|
content: Dict[str, Any], msg_id: str = "spc-msg-att"
|
|
) -> Dict[str, Any]:
|
|
return {
|
|
"messageId": msg_id,
|
|
"space": {"id": "+15551234567", "type": "dm", "phone": "+15551234567"},
|
|
"sender": {"id": "+15551234567"},
|
|
"content": {"type": "attachment", **content},
|
|
"timestamp": "2026-05-14T19:06:32.000Z",
|
|
}
|
|
|
|
|
|
def _voice_event(
|
|
content: Dict[str, Any], msg_id: str = "spc-msg-voice"
|
|
) -> Dict[str, Any]:
|
|
return {
|
|
"messageId": msg_id,
|
|
"space": {"id": "+15551234567", "type": "dm", "phone": "+15551234567"},
|
|
"sender": {"id": "+15551234567"},
|
|
"content": {"type": "voice", **content},
|
|
"timestamp": "2026-05-14T19:06:32.000Z",
|
|
}
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_on_inbound_line_dispatches_and_dedups(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
adapter = _make_adapter(monkeypatch)
|
|
captured = _capture(adapter, monkeypatch)
|
|
|
|
line = json.dumps(_dm_event("ping", msg_id="dup-1"))
|
|
await adapter._on_inbound_line(line)
|
|
await adapter._on_inbound_line(line) # same messageId -> deduped
|
|
|
|
assert len(captured) == 1
|
|
assert captured[0].text == "ping"
|
|
|
|
|
|
def test_is_duplicate_window(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
adapter = _make_adapter(monkeypatch)
|
|
assert adapter._is_duplicate("id-1") is False
|
|
assert adapter._is_duplicate("id-1") is True
|
|
assert adapter._is_duplicate("id-2") is False
|
|
assert adapter._is_duplicate("id-1") is True # still dup
|
|
|
|
|
|
def test_check_requirements_without_node(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
# If no node binary on PATH the adapter should refuse to start.
|
|
from plugins.platforms.photon import adapter as adapter_mod
|
|
|
|
monkeypatch.setattr(adapter_mod.shutil, "which", lambda _name: None)
|
|
assert adapter_mod.check_requirements() is False
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# CAF attachment promotion + U+FFFC placeholder tests
|
|
# ---------------------------------------------------------------------------
|
|
|
|
_CAF_BYTES = b"caff" + b"\x00" * 60 # Minimal CAF header magic
|
|
|
|
|
|
def _caf_attachment_event(
|
|
content: Dict[str, Any], msg_id: str = "spc-msg-caf"
|
|
) -> Dict[str, Any]:
|
|
return {
|
|
"messageId": msg_id,
|
|
"space": {"id": "+155****4567", "type": "dm", "phone": "+155****4567"},
|
|
"sender": {"id": "+155****4567"},
|
|
"content": {"type": "attachment", **content},
|
|
"timestamp": "2026-05-14T19:06:32.000Z",
|
|
}
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_caf_attachment_named_promoted_to_voice(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
"""A named .caf attachment is promoted to VOICE for STT routing."""
|
|
adapter = _make_adapter(monkeypatch)
|
|
captured = _capture(adapter, monkeypatch)
|
|
|
|
raw = _CAF_BYTES
|
|
event = _caf_attachment_event(
|
|
{
|
|
"name": "voice_note.caf",
|
|
"mimeType": "audio/x-caf",
|
|
"size": len(raw),
|
|
"data": base64.b64encode(raw).decode("ascii"),
|
|
"encoding": "base64",
|
|
}
|
|
)
|
|
await adapter._dispatch_inbound(event)
|
|
|
|
assert len(captured) == 1
|
|
ev = captured[0]
|
|
assert ev.message_type == MessageType.VOICE
|
|
assert ev.media_types == ["audio/x-caf"]
|
|
assert len(ev.media_urls) == 1
|
|
cached = Path(ev.media_urls[0])
|
|
try:
|
|
assert cached.is_file()
|
|
assert cached.read_bytes() == raw
|
|
assert ev.text == "(voice)"
|
|
finally:
|
|
cached.unlink(missing_ok=True)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_fffc_placeholder_no_dispatch(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
"""A U+FFFC placeholder text does not trigger a message dispatch."""
|
|
adapter = _make_adapter(monkeypatch)
|
|
captured = _capture(adapter, monkeypatch)
|
|
|
|
event = _dm_event("\ufffc", msg_id="spc-msg-fffc")
|
|
chat_key = event["space"]["id"]
|
|
await adapter._dispatch_inbound(event)
|
|
|
|
assert len(captured) == 0
|
|
assert chat_key in adapter._pending_fffc
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_disconnect_cancels_pending_fffc_tasks(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
"""disconnect() cancels any pending U+FFFC placeholder tasks."""
|
|
adapter = _make_adapter(monkeypatch)
|
|
_capture(adapter, monkeypatch)
|
|
|
|
await adapter._dispatch_inbound(_dm_event("\ufffc", msg_id="spc-msg-fffc"))
|
|
assert len(adapter._pending_fffc) == 1
|
|
|
|
async def _noop_stop_sidecar():
|
|
pass
|
|
|
|
monkeypatch.setattr(adapter, "_stop_sidecar", _noop_stop_sidecar)
|
|
monkeypatch.setattr(adapter, "_inbound_running", False)
|
|
monkeypatch.setattr(adapter, "_inbound_task", None)
|
|
monkeypatch.setattr(adapter, "_sidecar_health_task", None)
|
|
monkeypatch.setattr(adapter, "_http_client", None)
|
|
|
|
await adapter.disconnect()
|
|
|
|
assert len(adapter._pending_fffc) == 0
|