mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
112 lines
3.1 KiB
Python
112 lines
3.1 KiB
Python
"""Tests for the CLI ``/diff`` command handler.
|
|
|
|
``/diff`` shows git changes in the working directory (unstaged + untracked by
|
|
default; ``staged``/``all`` modes) and ``/diff session`` shows the cumulative
|
|
checkpoint-baseline diff of everything Hermes changed. These drive the mixin
|
|
handler against real git repos (default modes) and a stubbed checkpoint
|
|
manager (session mode), asserting rendering, ``--stat``, and graceful
|
|
degradation.
|
|
"""
|
|
|
|
import contextlib
|
|
import io
|
|
import shutil
|
|
import subprocess
|
|
|
|
import pytest
|
|
|
|
from hermes_cli.cli_commands_mixin import CLICommandsMixin
|
|
|
|
requires_git = pytest.mark.skipif(
|
|
shutil.which("git") is None, reason="git required"
|
|
)
|
|
|
|
|
|
class _Console:
|
|
def __init__(self, sink):
|
|
self._sink = sink
|
|
|
|
def print(self, obj, **kwargs):
|
|
self._sink.write(getattr(obj, "plain", str(obj)) + "\n")
|
|
|
|
|
|
class _Mgr:
|
|
def __init__(self, result, enabled=True):
|
|
self.enabled = enabled
|
|
self._result = result
|
|
self.calls = []
|
|
|
|
def session_diff(self, cwd):
|
|
self.calls.append(cwd)
|
|
return self._result
|
|
|
|
|
|
class _Agent:
|
|
def __init__(self, mgr):
|
|
self._checkpoint_mgr = mgr
|
|
|
|
|
|
class _Stub(CLICommandsMixin):
|
|
def __init__(self, agent=None):
|
|
self.agent = agent
|
|
|
|
|
|
def _run(stub, command):
|
|
buf = io.StringIO()
|
|
stub.console = _Console(buf)
|
|
with contextlib.redirect_stdout(buf):
|
|
stub._handle_diff_command(command)
|
|
return buf.getvalue()
|
|
|
|
|
|
def _git(repo, *args):
|
|
subprocess.run(["git", *args], cwd=repo, check=True, capture_output=True,
|
|
env={"GIT_AUTHOR_NAME": "t", "GIT_AUTHOR_EMAIL": "t@t",
|
|
"GIT_COMMITTER_NAME": "t", "GIT_COMMITTER_EMAIL": "t@t",
|
|
"HOME": str(repo),
|
|
"PATH": __import__("os").environ["PATH"]})
|
|
|
|
|
|
@pytest.fixture()
|
|
def repo(tmp_path, monkeypatch):
|
|
d = tmp_path / "repo"
|
|
d.mkdir()
|
|
_git(d, "init", "-q")
|
|
(d / "main.py").write_text("print('hello')\n")
|
|
_git(d, "add", "-A")
|
|
_git(d, "commit", "-q", "-m", "init")
|
|
monkeypatch.setenv("TERMINAL_CWD", str(d))
|
|
return d
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Default (working-tree) mode — real git
|
|
# ---------------------------------------------------------------------------
|
|
|
|
@requires_git
|
|
def test_diff_clean_repo_reports_no_changes(repo):
|
|
out = _run(_Stub(), "/diff")
|
|
assert "No changes" in out
|
|
|
|
|
|
@requires_git
|
|
def test_diff_non_git_directory_is_graceful(tmp_path, monkeypatch):
|
|
plain = tmp_path / "plain"
|
|
plain.mkdir()
|
|
monkeypatch.setenv("TERMINAL_CWD", str(plain))
|
|
out = _run(_Stub(), "/diff")
|
|
assert "not a git repository" in out.lower()
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Session mode — stubbed checkpoint manager
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_diff_session_empty_reports_no_changes(tmp_path, monkeypatch):
|
|
monkeypatch.setenv("TERMINAL_CWD", str(tmp_path))
|
|
mgr = _Mgr({"success": True, "stat": "", "diff": "", "empty": True})
|
|
out = _run(_Stub(_Agent(mgr)), "/diff session")
|
|
assert "No changes" in out
|
|
|
|
|