mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
48 lines
1.1 KiB
Python
48 lines
1.1 KiB
Python
"""Invariant tests for registry-owned slash execution (CommandDef.execute).
|
|
|
|
Every ``CommandDef`` with ``execute`` set must:
|
|
* name a key that exists in :data:`hermes_cli.slash_exec.EXECUTORS`, and
|
|
* produce IDENTICAL core text across surfaces for a fixed context — the
|
|
executor may only vary on ``args``/``options``, never on ``surface``.
|
|
"""
|
|
|
|
import pytest
|
|
|
|
from hermes_cli.commands import COMMAND_REGISTRY, resolve_command
|
|
from hermes_cli.slash_exec import (
|
|
EXECUTORS,
|
|
CommandContext,
|
|
CommandReply,
|
|
execute_command,
|
|
resolve_executor,
|
|
run_execute,
|
|
)
|
|
|
|
MIGRATED = [cmd for cmd in COMMAND_REGISTRY if cmd.execute]
|
|
|
|
SURFACES = ("cli", "gateway", "tui")
|
|
|
|
|
|
def test_some_commands_are_migrated():
|
|
names = {cmd.name for cmd in MIGRATED}
|
|
# The thin-slice set — extend as more commands migrate.
|
|
assert {"version", "egress", "profile", "bundles", "help", "commands"} <= names
|
|
|
|
|
|
|
|
|
|
def test_unmigrated_commands_have_no_executor():
|
|
for cmd in COMMAND_REGISTRY:
|
|
if not cmd.execute:
|
|
assert resolve_executor(cmd) is None
|
|
assert run_execute(cmd, CommandContext()) is None
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|