mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
75 lines
2.5 KiB
Python
75 lines
2.5 KiB
Python
"""Tests for banner toolset name normalization and skin color usage."""
|
|
|
|
from unittest.mock import patch
|
|
|
|
from rich.console import Console
|
|
|
|
import hermes_cli.banner as banner
|
|
import model_tools
|
|
import tools.mcp_tool
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_build_welcome_banner_title_falls_back_when_no_tag():
|
|
"""Without a resolvable tag, the panel title renders as plain text (no hyperlink escape)."""
|
|
import io
|
|
from unittest.mock import patch as _patch
|
|
import hermes_cli.banner as _banner
|
|
import model_tools as _mt
|
|
import tools.mcp_tool as _mcp
|
|
|
|
_banner._latest_release_cache = None
|
|
buf = io.StringIO()
|
|
with (
|
|
_patch.object(_mt, "check_tool_availability", return_value=(["web"], [])),
|
|
_patch.object(_banner, "get_available_skills", return_value={}),
|
|
_patch.object(_banner, "get_update_result", return_value=None),
|
|
_patch.object(_mcp, "get_mcp_status", return_value=[]),
|
|
_patch.object(_banner, "get_latest_release_tag", return_value=None),
|
|
):
|
|
console = Console(file=buf, force_terminal=True, color_system="truecolor", width=160)
|
|
_banner.build_welcome_banner(
|
|
console=console, model="x", cwd="/tmp",
|
|
session_id="abc123",
|
|
tools=[{"function": {"name": "read_file"}}],
|
|
get_toolset_for_tool=lambda n: "file",
|
|
)
|
|
|
|
raw = buf.getvalue()
|
|
assert "Hermes Agent v" in raw, "Version label missing from title"
|
|
assert "\x1b]8;" not in raw, "OSC-8 hyperlink should not be emitted without a tag"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_build_welcome_banner_non_moa_unchanged(tmp_path, monkeypatch):
|
|
"""A normal provider still renders the bare model slug, no MoA prefix."""
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path / ".hermes"))
|
|
(tmp_path / ".hermes").mkdir()
|
|
|
|
with (
|
|
patch.object(model_tools, "check_tool_availability", return_value=([], [])),
|
|
patch.object(banner, "get_available_skills", return_value={}),
|
|
patch.object(banner, "get_update_result", return_value=None),
|
|
patch.object(tools.mcp_tool, "get_mcp_status", return_value=[]),
|
|
):
|
|
console = Console(record=True, force_terminal=False, color_system=None, width=160)
|
|
banner.build_welcome_banner(
|
|
console=console,
|
|
model="anthropic/claude-opus-4.8",
|
|
cwd="/tmp/project",
|
|
tools=[],
|
|
enabled_toolsets=[],
|
|
provider="openrouter",
|
|
)
|
|
|
|
out = console.export_text()
|
|
assert "claude-opus-4.8" in out
|
|
assert "MoA:" not in out
|