mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
72 lines
3 KiB
Python
72 lines
3 KiB
Python
"""Tests for the Slack plugin's interactive_setup wizard.
|
|
|
|
These cover the home-channel save logic that previously lived in
|
|
``hermes_cli/setup.py::_setup_slack`` before the Slack adapter migrated to a
|
|
bundled plugin (#41112). ``interactive_setup`` lazy-imports its CLI helpers
|
|
from ``hermes_cli.config`` (get_env_value / save_env_value / remove_env_value)
|
|
and ``hermes_cli.cli_output`` (prompt / prompt_yes_no / print_*), so we patch
|
|
those source modules.
|
|
"""
|
|
import hermes_cli.config as config_mod
|
|
import hermes_cli.cli_output as cli_output_mod
|
|
from plugins.platforms.slack.adapter import interactive_setup
|
|
|
|
|
|
def _patch_setup_io(monkeypatch, prompts, saved, removed, existing):
|
|
"""Wire interactive_setup's lazy-imported CLI helpers to test doubles."""
|
|
prompt_iter = iter(prompts)
|
|
monkeypatch.setattr(config_mod, "get_env_value", lambda key: existing.get(key, ""))
|
|
monkeypatch.setattr(config_mod, "save_env_value", lambda k, v: saved.update({k: v}))
|
|
|
|
# Mirror remove_env_value's real semantics: True if removed, False if absent.
|
|
def _remove(key):
|
|
removed.append(key)
|
|
return existing.pop(key, None) is not None
|
|
|
|
monkeypatch.setattr(config_mod, "remove_env_value", _remove)
|
|
monkeypatch.setattr(cli_output_mod, "prompt", lambda *_a, **_kw: next(prompt_iter))
|
|
monkeypatch.setattr(cli_output_mod, "prompt_yes_no", lambda *_a, **_kw: False)
|
|
for name in ("print_header", "print_info", "print_success", "print_warning"):
|
|
monkeypatch.setattr(cli_output_mod, name, lambda *_a, **_kw: None)
|
|
# Manifest writing reaches out to hermes_cli.slack_cli + filesystem; stub it.
|
|
import hermes_cli.slack_cli as slack_cli_mod
|
|
monkeypatch.setattr(slack_cli_mod, "_build_full_manifest", lambda **_kw: {"display_information": {}})
|
|
|
|
|
|
def test_interactive_setup_saves_home_channel(monkeypatch, tmp_path):
|
|
"""interactive_setup() saves SLACK_HOME_CHANNEL when the user provides one."""
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
|
saved, removed = {}, []
|
|
# prompts: bot token, app token, allowed users (empty), home channel
|
|
_patch_setup_io(
|
|
monkeypatch,
|
|
["«redacted:xox…»", "xapp-test-token", "", "C01ABC2DE3F"],
|
|
saved,
|
|
removed,
|
|
existing={},
|
|
)
|
|
|
|
interactive_setup()
|
|
|
|
assert saved.get("SLACK_HOME_CHANNEL") == "C01ABC2DE3F"
|
|
assert "SLACK_HOME_CHANNEL" not in removed
|
|
|
|
|
|
class TestSlackHomeChannelClear:
|
|
"""Blank home-channel answer must clear SLACK_HOME_CHANNEL (#12423)."""
|
|
|
|
def test_blank_removes_existing_home_channel(self, monkeypatch, tmp_path):
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
|
saved, removed = {}, []
|
|
_patch_setup_io(
|
|
monkeypatch,
|
|
["«redacted:xox…»", "xapp-test-token", "", ""],
|
|
saved,
|
|
removed,
|
|
existing={"SLACK_HOME_CHANNEL": "C01OLDHOMEXYZ"},
|
|
)
|
|
interactive_setup()
|
|
assert "SLACK_HOME_CHANNEL" in removed
|
|
assert "SLACK_HOME_CHANNEL" not in saved
|
|
|
|
|