mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
163 lines
5.8 KiB
Python
163 lines
5.8 KiB
Python
"""Contract tests for gateway.platforms.media_cache — the shared mime↔ext
|
|
dispatch — plus per-adapter parity spot-checks that hardcode each adapter's
|
|
HISTORICAL (pre-refactor) mappings as the contract.
|
|
|
|
If any of these fail, an adapter's downloaded-media filenames changed —
|
|
that's a behavioral regression, not a test to update casually.
|
|
"""
|
|
|
|
import mimetypes
|
|
|
|
import pytest
|
|
|
|
from gateway.platforms.media_cache import (
|
|
DEFAULT_EXT_TO_MIME,
|
|
DEFAULT_MIME_TO_EXT,
|
|
cache_media_bytes,
|
|
ext_for_mime,
|
|
mime_for_ext,
|
|
)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Shared table contract
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestSharedTable:
|
|
def test_defaults_resolve(self):
|
|
for mime, ext in DEFAULT_MIME_TO_EXT.items():
|
|
assert ext_for_mime(mime) == ext
|
|
|
|
|
|
def test_stage_gating(self):
|
|
# use_defaults=False skips the shared table.
|
|
assert ext_for_mime(
|
|
"audio/ogg", use_defaults=False, use_mimetypes=False, fallback=".x"
|
|
) == ".x"
|
|
# use_mimetypes=False skips the mimetypes fallback.
|
|
assert ext_for_mime("image/bmp", use_mimetypes=False) is None
|
|
|
|
|
|
def test_mime_for_ext_fallback_and_case(self):
|
|
assert mime_for_ext(".JPG") == "image/jpeg"
|
|
assert mime_for_ext(".unknown") == "application/octet-stream"
|
|
assert mime_for_ext(".unknown", fallback="x/y") == "x/y"
|
|
assert mime_for_ext(".pdf", overrides={".pdf": "custom/pdf"}) == "custom/pdf"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# cache_media_bytes dispatch
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestCacheMediaBytes:
|
|
PNG = b"\x89PNG\r\n\x1a\n" + b"\x00" * 16
|
|
|
|
def test_image_dispatch(self, monkeypatch, tmp_path):
|
|
monkeypatch.setattr(
|
|
"gateway.platforms.base.get_image_cache_dir", lambda: tmp_path
|
|
)
|
|
path = cache_media_bytes(self.PNG, "image/png")
|
|
assert path.endswith(".png")
|
|
|
|
|
|
def test_document_dispatch_uses_filename_hint(self, monkeypatch, tmp_path):
|
|
monkeypatch.setattr(
|
|
"gateway.platforms.base.get_document_cache_dir", lambda: tmp_path
|
|
)
|
|
path = cache_media_bytes(b"%PDF-1.4", "application/pdf",
|
|
filename_hint="report.pdf")
|
|
assert path.endswith("_report.pdf")
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Per-adapter parity: HISTORICAL mappings hardcoded as the contract
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestBlueBubblesParity:
|
|
"""Historical closed maps from bluebubbles._download_attachment."""
|
|
|
|
IMAGE_CASES = {
|
|
"image/jpeg": ".jpg",
|
|
"image/png": ".png",
|
|
"image/gif": ".gif",
|
|
"image/webp": ".webp",
|
|
"image/heic": ".jpg", # historically coerced to .jpg
|
|
"image/heif": ".jpg", # historically coerced to .jpg
|
|
"image/tiff": ".jpg", # historically coerced to .jpg
|
|
"image/bmp": ".jpg", # unlisted → historical .jpg fallback
|
|
}
|
|
AUDIO_CASES = {
|
|
"audio/mp3": ".mp3",
|
|
"audio/mpeg": ".mp3",
|
|
"audio/ogg": ".ogg",
|
|
"audio/wav": ".wav",
|
|
"audio/x-caf": ".mp3", # historically coerced to .mp3
|
|
"audio/mp4": ".m4a",
|
|
"audio/aac": ".m4a", # historically .m4a (NOT .aac)
|
|
"audio/flac": ".mp3", # unlisted → historical .mp3 fallback
|
|
}
|
|
|
|
@pytest.mark.parametrize("mime,expected", sorted(IMAGE_CASES.items()))
|
|
def test_image_map(self, mime, expected):
|
|
from gateway.platforms.bluebubbles import _BLUEBUBBLES_IMAGE_EXT_OVERRIDES
|
|
got = ext_for_mime(
|
|
mime,
|
|
overrides=_BLUEBUBBLES_IMAGE_EXT_OVERRIDES,
|
|
use_defaults=False,
|
|
use_mimetypes=False,
|
|
fallback=".jpg",
|
|
)
|
|
assert got == expected
|
|
|
|
|
|
class TestWhatsAppCloudParity:
|
|
"""Historical _ext_for_mime: overrides → mimetypes → None."""
|
|
|
|
CASES = {
|
|
# Pinned overrides (Meta-sent types the STT pipeline needs pinned).
|
|
"audio/ogg": ".ogg", # NOT mimetypes' .oga
|
|
"audio/x-opus+ogg": ".ogg",
|
|
"audio/opus": ".ogg",
|
|
"audio/mp4": ".m4a",
|
|
"audio/x-m4a": ".m4a",
|
|
"image/jpeg": ".jpg", # NOT the legacy .jpe
|
|
}
|
|
|
|
@pytest.mark.parametrize("mime,expected", sorted(CASES.items()))
|
|
def test_pinned_overrides(self, mime, expected):
|
|
from gateway.platforms.whatsapp_cloud import _ext_for_mime
|
|
assert _ext_for_mime(mime) == expected
|
|
|
|
|
|
class TestSignalParity:
|
|
"""Historical _EXT_TO_MIME table from signal.py, verbatim."""
|
|
|
|
HISTORICAL = {
|
|
".jpg": "image/jpeg", ".jpeg": "image/jpeg", ".png": "image/png",
|
|
".gif": "image/gif", ".webp": "image/webp",
|
|
".ogg": "audio/ogg", ".mp3": "audio/mpeg", ".wav": "audio/wav",
|
|
".m4a": "audio/mp4", ".aac": "audio/aac",
|
|
".mp4": "video/mp4", ".pdf": "application/pdf",
|
|
".zip": "application/zip",
|
|
}
|
|
|
|
@pytest.mark.parametrize("ext,expected", sorted(HISTORICAL.items()))
|
|
def test_table(self, ext, expected):
|
|
from gateway.platforms.signal import _ext_to_mime
|
|
assert _ext_to_mime(ext) == expected
|
|
assert _ext_to_mime(ext.upper()) == expected
|
|
|
|
|
|
class TestQQBotParity:
|
|
"""Historical qqbot image path: mimetypes.guess_extension or '.jpg'."""
|
|
|
|
@pytest.mark.parametrize("mime", [
|
|
"image/jpeg", "image/png", "image/gif", "image/webp", "image/bmp",
|
|
])
|
|
def test_trusts_mimetypes(self, mime):
|
|
historical = mimetypes.guess_extension(mime) or ".jpg"
|
|
got = ext_for_mime(
|
|
mime, use_defaults=False, use_mimetypes=True, fallback=".jpg"
|
|
) or ".jpg"
|
|
assert got == historical
|
|
|