mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
142 lines
4.3 KiB
Python
142 lines
4.3 KiB
Python
"""Tests for gateway/hooks.py — event hook system."""
|
|
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
from gateway.hooks import HookRegistry
|
|
|
|
|
|
def _create_hook(hooks_dir, hook_name, events, handler_code):
|
|
"""Helper to create a hook directory with HOOK.yaml and handler.py."""
|
|
hook_dir = hooks_dir / hook_name
|
|
hook_dir.mkdir(parents=True)
|
|
(hook_dir / "HOOK.yaml").write_text(
|
|
f"name: {hook_name}\n"
|
|
f"description: Test hook\n"
|
|
f"events: {events}\n"
|
|
)
|
|
(hook_dir / "handler.py").write_text(handler_code)
|
|
return hook_dir
|
|
|
|
|
|
class TestHookRegistryInit:
|
|
def test_empty_registry(self):
|
|
reg = HookRegistry()
|
|
assert reg.loaded_hooks == []
|
|
assert reg._handlers == {}
|
|
|
|
|
|
def _patch_no_builtins(reg):
|
|
"""Suppress built-in hook registration so tests only exercise user-hook discovery."""
|
|
return patch.object(reg, "_register_builtin_hooks")
|
|
|
|
|
|
class TestDiscoverAndLoad:
|
|
def test_loads_valid_hook(self, tmp_path):
|
|
_create_hook(tmp_path, "my-hook", '["agent:start"]',
|
|
"def handle(event_type, context):\n pass\n")
|
|
|
|
reg = HookRegistry()
|
|
with patch("gateway.hooks.HOOKS_DIR", tmp_path), _patch_no_builtins(reg):
|
|
reg.discover_and_load()
|
|
|
|
assert len(reg.loaded_hooks) == 1
|
|
assert reg.loaded_hooks[0]["name"] == "my-hook"
|
|
assert "agent:start" in reg.loaded_hooks[0]["events"]
|
|
|
|
|
|
def test_skips_no_events(self, tmp_path):
|
|
hook_dir = tmp_path / "empty-hook"
|
|
hook_dir.mkdir()
|
|
(hook_dir / "HOOK.yaml").write_text("name: empty\nevents: []\n")
|
|
(hook_dir / "handler.py").write_text("def handle(e, c): pass\n")
|
|
|
|
reg = HookRegistry()
|
|
with patch("gateway.hooks.HOOKS_DIR", tmp_path), _patch_no_builtins(reg):
|
|
reg.discover_and_load()
|
|
|
|
assert len(reg.loaded_hooks) == 0
|
|
|
|
|
|
class TestEmit:
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_emit_calls_async_handler(self, tmp_path):
|
|
results = []
|
|
|
|
hook_dir = tmp_path / "async-hook"
|
|
hook_dir.mkdir()
|
|
(hook_dir / "HOOK.yaml").write_text(
|
|
"name: async-hook\nevents: ['agent:end']\n"
|
|
)
|
|
(hook_dir / "handler.py").write_text(
|
|
"import asyncio\n"
|
|
"results = []\n"
|
|
"async def handle(event_type, context):\n"
|
|
" results.append(event_type)\n"
|
|
)
|
|
|
|
reg = HookRegistry()
|
|
with patch("gateway.hooks.HOOKS_DIR", tmp_path):
|
|
reg.discover_and_load()
|
|
|
|
handler_fn = reg._handlers["agent:end"][0]
|
|
handler_fn.__globals__["results"] = results
|
|
|
|
await reg.emit("agent:end", {})
|
|
assert "agent:end" in results
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_wildcard_matching(self, tmp_path):
|
|
results = []
|
|
|
|
_create_hook(tmp_path, "wildcard-hook", '["command:*"]',
|
|
"results = []\n"
|
|
"def handle(event_type, context):\n"
|
|
" results.append(event_type)\n")
|
|
|
|
reg = HookRegistry()
|
|
with patch("gateway.hooks.HOOKS_DIR", tmp_path):
|
|
reg.discover_and_load()
|
|
|
|
handler_fn = reg._handlers["command:*"][0]
|
|
handler_fn.__globals__["results"] = results
|
|
|
|
await reg.emit("command:reset", {})
|
|
assert "command:reset" in results
|
|
|
|
|
|
class TestEmitCollect:
|
|
"""Tests for emit_collect() — returns handler return values for decision-style hooks."""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_collects_sync_return_values(self):
|
|
reg = HookRegistry()
|
|
reg._handlers["command:status"] = [
|
|
lambda _e, _c: {"decision": "allow"},
|
|
lambda _e, _c: {"decision": "deny", "message": "nope"},
|
|
]
|
|
|
|
results = await reg.emit_collect("command:status", {})
|
|
|
|
assert results == [
|
|
{"decision": "allow"},
|
|
{"decision": "deny", "message": "nope"},
|
|
]
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_drops_none_return_values(self):
|
|
reg = HookRegistry()
|
|
reg._handlers["command:x"] = [
|
|
lambda _e, _c: None, # fire-and-forget, returns nothing
|
|
lambda _e, _c: {"decision": "deny"},
|
|
lambda _e, _c: None,
|
|
]
|
|
|
|
results = await reg.emit_collect("command:x", {})
|
|
|
|
assert results == [{"decision": "deny"}]
|
|
|
|
|