mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
99 lines
3.7 KiB
Python
99 lines
3.7 KiB
Python
"""Async SessionStore boundary for gateway event-loop safety."""
|
|
|
|
import ast
|
|
import asyncio
|
|
import threading
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from gateway.session import AsyncSessionStore
|
|
|
|
|
|
class _SpyStore:
|
|
def __init__(self) -> None:
|
|
self.calls: list[tuple[str, int]] = []
|
|
self.label = "store"
|
|
|
|
def read(self, value: str) -> str:
|
|
self.calls.append((value, threading.get_ident()))
|
|
return value
|
|
|
|
|
|
def _nearest_function(node: ast.AST, parents: dict[ast.AST, ast.AST]):
|
|
current = node
|
|
while current in parents:
|
|
current = parents[current]
|
|
if isinstance(current, (ast.FunctionDef, ast.AsyncFunctionDef)):
|
|
return current
|
|
return None
|
|
|
|
|
|
def _is_awaited(node: ast.AST, parents: dict[ast.AST, ast.AST]) -> bool:
|
|
current = node
|
|
while current in parents:
|
|
current = parents[current]
|
|
if isinstance(current, ast.Await):
|
|
return True
|
|
if isinstance(current, (ast.FunctionDef, ast.AsyncFunctionDef)):
|
|
return False
|
|
return False
|
|
|
|
|
|
def test_gateway_async_code_uses_one_awaited_session_store_boundary() -> None:
|
|
"""Loop-side store calls must use the facade; raw store remains sync-only."""
|
|
root = Path(__file__).resolve().parents[2]
|
|
violations: list[str] = []
|
|
for rel in ("gateway/run.py", "gateway/slash_commands.py"):
|
|
tree = ast.parse((root / rel).read_text(encoding="utf-8"))
|
|
parents = {
|
|
child: parent
|
|
for parent in ast.walk(tree)
|
|
for child in ast.iter_child_nodes(parent)
|
|
}
|
|
for owner in (node for node in ast.walk(tree) if isinstance(node, ast.AsyncFunctionDef)):
|
|
raw_aliases = {
|
|
target.id
|
|
for node in ast.walk(owner)
|
|
if isinstance(node, ast.Assign)
|
|
and isinstance(node.value, ast.Attribute)
|
|
and isinstance(node.value.value, ast.Name)
|
|
and node.value.value.id in {"self", "_self"}
|
|
and node.value.attr == "session_store"
|
|
for target in node.targets
|
|
if isinstance(target, ast.Name)
|
|
}
|
|
for node in ast.walk(owner):
|
|
if not isinstance(node, ast.Call) or not isinstance(node.func, ast.Attribute):
|
|
continue
|
|
if _nearest_function(node, parents) is not owner:
|
|
# A nested sync helper (for example run_sync) executes off-loop.
|
|
continue
|
|
receiver = node.func.value
|
|
if isinstance(receiver, ast.Name) and receiver.id in raw_aliases:
|
|
violations.append(
|
|
f"{rel}:{node.lineno} raw alias {receiver.id}.{node.func.attr}() in async {owner.name}"
|
|
)
|
|
continue
|
|
if not (
|
|
isinstance(receiver, ast.Attribute)
|
|
and isinstance(receiver.value, ast.Name)
|
|
and receiver.value.id in {"self", "_self"}
|
|
):
|
|
continue
|
|
if receiver.attr == "session_store":
|
|
violations.append(
|
|
f"{rel}:{node.lineno} raw session_store.{node.func.attr}() in async {owner.name}"
|
|
)
|
|
elif receiver.attr == "async_session_store" and not _is_awaited(
|
|
node, parents
|
|
):
|
|
violations.append(
|
|
f"{rel}:{node.lineno} unawaited async_session_store.{node.func.attr}()"
|
|
)
|
|
assert not violations, "\n".join(violations)
|
|
|
|
|
|
def test_no_repository_local_claude_permissions_file() -> None:
|
|
root = Path(__file__).resolve().parents[2]
|
|
assert not (root / ".claude" / "settings.json").exists()
|