mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
102 lines
3.4 KiB
Python
102 lines
3.4 KiB
Python
"""Regression guard for #62151 — gateway cron must not wedge on the 2nd+ call.
|
|
|
|
Gateway-fired cron jobs hung forever on the 2nd+ API call because both the
|
|
non-streaming (``interruptible_api_call``) and the default streaming
|
|
(``interruptible_streaming_api_call``) paths run the request on a spawned
|
|
daemon worker thread. Inside the gateway's nested cron thread pools that extra
|
|
worker wedged before the socket opened; the same job succeeded via ``hermes
|
|
cron tick`` (foreground, no nested pools). Cron has no interactive interrupt
|
|
surface, so both paths now run inline on the conversation thread for the
|
|
``cron`` platform.
|
|
|
|
These tests pin: (1) the inline gate is cron-only, (2) the inline call runs on
|
|
the *calling* thread — no worker is spawned — for both entry points, and (3)
|
|
the shared dispatch closes the per-request client.
|
|
"""
|
|
|
|
import threading
|
|
from types import SimpleNamespace
|
|
from unittest.mock import MagicMock
|
|
|
|
from run_agent import AIAgent
|
|
|
|
from agent.chat_completion_helpers import (
|
|
direct_api_call,
|
|
interruptible_api_call,
|
|
interruptible_streaming_api_call,
|
|
should_use_direct_api_call,
|
|
)
|
|
|
|
|
|
def _make_agent(*, platform="cron"):
|
|
agent = MagicMock()
|
|
agent.platform = platform
|
|
agent.api_mode = "chat_completions"
|
|
agent.provider = "openrouter"
|
|
agent._interrupt_requested = False
|
|
agent._consecutive_stale_streams = 0
|
|
agent._touch_activity = MagicMock()
|
|
agent._close_request_openai_client = MagicMock()
|
|
return agent
|
|
|
|
|
|
def test_should_use_direct_api_call_only_for_cron_openai_wire():
|
|
assert should_use_direct_api_call(_make_agent(platform="cron")) is True
|
|
assert should_use_direct_api_call(_make_agent(platform="cli")) is False
|
|
assert should_use_direct_api_call(_make_agent(platform="telegram")) is False
|
|
assert should_use_direct_api_call(_make_agent(platform=None)) is False
|
|
|
|
for api_mode in ("codex_responses", "anthropic_messages", "bedrock_converse"):
|
|
agent = _make_agent(platform="cron")
|
|
agent.api_mode = api_mode
|
|
assert should_use_direct_api_call(agent) is False
|
|
|
|
moa = _make_agent(platform="cron")
|
|
moa.provider = "moa"
|
|
assert should_use_direct_api_call(moa) is False
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_direct_api_call_interrupt_aborts_active_client_and_raises():
|
|
"""Cron's outer watchdog interrupts from another thread while inline."""
|
|
agent = _make_agent()
|
|
client_ready = threading.Event()
|
|
release_request = threading.Event()
|
|
fake_client = MagicMock()
|
|
|
|
def _create(**_kwargs):
|
|
client_ready.set()
|
|
return fake_client
|
|
|
|
def _request(**_kwargs):
|
|
assert release_request.wait(timeout=2)
|
|
raise RuntimeError("socket closed")
|
|
|
|
fake_client.chat.completions.create.side_effect = _request
|
|
agent._create_request_openai_client.side_effect = _create
|
|
result = {}
|
|
|
|
def _run():
|
|
try:
|
|
direct_api_call(agent, {"model": "m", "messages": []})
|
|
except Exception as exc:
|
|
result["exception"] = exc
|
|
|
|
worker = threading.Thread(target=_run)
|
|
worker.start()
|
|
assert client_ready.wait(timeout=1)
|
|
assert callable(agent._active_request_abort)
|
|
AIAgent.interrupt(agent, "cron timeout")
|
|
agent._abort_request_openai_client.assert_called_once_with(
|
|
fake_client, reason="interrupt_abort"
|
|
)
|
|
release_request.set()
|
|
worker.join(timeout=2)
|
|
assert not worker.is_alive()
|
|
assert isinstance(result.get("exception"), InterruptedError)
|
|
assert agent._active_request_abort is None
|
|
|
|
|