mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
42 lines
1.7 KiB
Python
42 lines
1.7 KiB
Python
"""Tests for the post_setup install-state gate in `_toolset_needs_configuration_prompt`.
|
|
|
|
Regression coverage for the cua-driver silent-no-op bug (issue #22737).
|
|
|
|
When a no-key provider's only install side-effect is a `post_setup` hook
|
|
(cua-driver, etc.), the gate function used to fall through to the
|
|
`_toolset_has_keys` catch-all, which returned True for any provider with
|
|
empty `env_vars` — causing `hermes tools` to write the toolset to config
|
|
and exit `✓ Saved` without ever invoking the post_setup install. These
|
|
tests pin the new predicate-aware behaviour so the regression doesn't
|
|
sneak back in.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
|
|
class TestPostSetupGate:
|
|
def test_cua_driver_missing_forces_setup(self, monkeypatch, tmp_path):
|
|
"""When cua-driver isn't on PATH, the gate must return True so the
|
|
provider-setup flow runs and triggers `_run_post_setup`."""
|
|
from hermes_cli import tools_config
|
|
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
|
monkeypatch.setattr(tools_config.shutil, "which", lambda name, path=None: None)
|
|
|
|
assert tools_config._toolset_needs_configuration_prompt(
|
|
"computer_use", {}
|
|
) is True
|
|
|
|
|
|
def test_post_setup_predicate_exception_does_not_block(self, monkeypatch):
|
|
"""A predicate that raises must be treated as 'satisfied' so a
|
|
broken check can't strand the user in an infinite setup loop."""
|
|
from hermes_cli import tools_config
|
|
|
|
def _boom():
|
|
raise RuntimeError("predicate broken")
|
|
|
|
monkeypatch.setitem(tools_config._POST_SETUP_INSTALLED, "cua_driver", _boom)
|
|
assert tools_config._post_setup_already_installed("cua_driver") is True
|
|
|
|
|