mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
120 lines
3.7 KiB
Python
120 lines
3.7 KiB
Python
"""Tests for file path autocomplete in the CLI completer."""
|
|
|
|
import os
|
|
from unittest.mock import MagicMock
|
|
|
|
import pytest
|
|
from prompt_toolkit.document import Document
|
|
from prompt_toolkit.formatted_text import to_plain_text
|
|
|
|
from hermes_cli.commands import SlashCommandCompleter, _file_size_label
|
|
|
|
|
|
def _display_names(completions):
|
|
"""Extract plain-text display names from a list of Completion objects."""
|
|
return [to_plain_text(c.display) for c in completions]
|
|
|
|
|
|
def _display_metas(completions):
|
|
"""Extract plain-text display_meta from a list of Completion objects."""
|
|
return [to_plain_text(c.display_meta) if c.display_meta else "" for c in completions]
|
|
|
|
|
|
@pytest.fixture
|
|
def completer():
|
|
return SlashCommandCompleter()
|
|
|
|
|
|
class TestExtractPathWord:
|
|
def test_relative_path(self):
|
|
assert SlashCommandCompleter._extract_path_word("look at ./src/main.py") == "./src/main.py"
|
|
|
|
|
|
|
|
|
|
|
|
class TestPathCompletions:
|
|
def test_lists_current_directory(self, tmp_path):
|
|
(tmp_path / "file_a.py").touch()
|
|
(tmp_path / "file_b.txt").touch()
|
|
(tmp_path / "subdir").mkdir()
|
|
|
|
old_cwd = os.getcwd()
|
|
os.chdir(tmp_path)
|
|
try:
|
|
completions = list(SlashCommandCompleter._path_completions("./"))
|
|
names = _display_names(completions)
|
|
assert "file_a.py" in names
|
|
assert "file_b.txt" in names
|
|
assert "subdir/" in names
|
|
finally:
|
|
os.chdir(old_cwd)
|
|
|
|
|
|
def test_directories_have_trailing_slash(self, tmp_path):
|
|
(tmp_path / "mydir").mkdir()
|
|
(tmp_path / "myfile.txt").touch()
|
|
|
|
completions = list(SlashCommandCompleter._path_completions(f"{tmp_path}/"))
|
|
names = _display_names(completions)
|
|
metas = _display_metas(completions)
|
|
assert "mydir/" in names
|
|
idx = names.index("mydir/")
|
|
assert metas[idx] == "dir"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
class TestIntegration:
|
|
"""Test the completer produces path completions via the prompt_toolkit API."""
|
|
|
|
def test_slash_commands_still_work(self, completer):
|
|
doc = Document("/hel", cursor_position=4)
|
|
event = MagicMock()
|
|
completions = list(completer.get_completions(doc, event))
|
|
names = _display_names(completions)
|
|
assert "/help" in names
|
|
|
|
def test_path_completion_triggers_on_dot_slash(self, completer, tmp_path):
|
|
(tmp_path / "test.py").touch()
|
|
old_cwd = os.getcwd()
|
|
os.chdir(tmp_path)
|
|
try:
|
|
doc = Document("edit ./te", cursor_position=9)
|
|
event = MagicMock()
|
|
completions = list(completer.get_completions(doc, event))
|
|
names = _display_names(completions)
|
|
assert "test.py" in names
|
|
finally:
|
|
os.chdir(old_cwd)
|
|
|
|
|
|
def test_url_does_not_touch_filesystem(self, completer, monkeypatch):
|
|
# Regression for laggy typing: a URL token contains "/", so before the
|
|
# scheme guard it reached _path_completions and called os.listdir on
|
|
# every keystroke. Assert no completions AND that the filesystem is
|
|
# never touched while a URL is under the cursor.
|
|
import hermes_cli.commands as commands_mod
|
|
|
|
def _fail(*_args, **_kwargs):
|
|
raise AssertionError("os.listdir must not run for a URL token")
|
|
|
|
monkeypatch.setattr(commands_mod.os, "listdir", _fail)
|
|
|
|
text = "open https://paste.rs/abc"
|
|
doc = Document(text, cursor_position=len(text))
|
|
event = MagicMock()
|
|
assert list(completer.get_completions(doc, event)) == []
|
|
|
|
|
|
class TestFileSizeLabel:
|
|
def test_bytes(self, tmp_path):
|
|
f = tmp_path / "small.txt"
|
|
f.write_text("hi")
|
|
assert _file_size_label(str(f)) == "2B"
|
|
|
|
|
|
def test_nonexistent(self):
|
|
assert _file_size_label("/nonexistent_xyz") == ""
|