mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
72 lines
2.3 KiB
Python
72 lines
2.3 KiB
Python
"""Write-guard tests — managed keys can't be set/removed by the user."""
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture
|
|
def homes(tmp_path, monkeypatch):
|
|
home = tmp_path / "home"
|
|
home.mkdir()
|
|
managed = tmp_path / "managed"
|
|
managed.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
monkeypatch.setenv("HERMES_MANAGED_DIR", str(managed))
|
|
import hermes_cli.config as cfg
|
|
from hermes_cli import managed_scope
|
|
|
|
cfg._LOAD_CONFIG_CACHE.clear()
|
|
cfg._RAW_CONFIG_CACHE.clear()
|
|
managed_scope.invalidate_managed_cache()
|
|
(managed / "config.yaml").write_text(
|
|
"model:\n default: managed/model\n", encoding="utf-8"
|
|
)
|
|
managed_scope.invalidate_managed_cache()
|
|
return home, managed
|
|
|
|
|
|
def test_config_set_managed_key_rejected(homes, capsys):
|
|
from hermes_cli.config import set_config_value
|
|
|
|
with pytest.raises(SystemExit) as exc:
|
|
set_config_value("model.default", "user/override")
|
|
assert exc.value.code != 0
|
|
captured = capsys.readouterr()
|
|
assert "managed" in (captured.out + captured.err).lower()
|
|
|
|
|
|
|
|
|
|
# ── env write guards ─────────────────────────────────────────────────────────
|
|
|
|
|
|
@pytest.fixture
|
|
def env_homes(tmp_path, monkeypatch):
|
|
home = tmp_path / "home"
|
|
home.mkdir()
|
|
managed = tmp_path / "managed"
|
|
managed.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
monkeypatch.setenv("HERMES_MANAGED_DIR", str(managed))
|
|
(managed / ".env").write_text(
|
|
"OPENAI_API_BASE=https://org.example/v1\n", encoding="utf-8"
|
|
)
|
|
from hermes_cli import managed_scope
|
|
|
|
managed_scope.invalidate_managed_cache()
|
|
return home, managed
|
|
|
|
|
|
def test_save_env_value_managed_key_rejected(env_homes, capsys):
|
|
from hermes_cli.config import save_env_value, get_env_path
|
|
|
|
save_env_value("OPENAI_API_BASE", "https://user.example/v1")
|
|
assert "managed" in capsys.readouterr().err.lower()
|
|
env_path = get_env_path()
|
|
body = env_path.read_text() if env_path.exists() else ""
|
|
assert "user.example" not in body
|
|
|
|
|
|
|
|
|
|
# ── bulk save strips managed leaves ──────────────────────────────────────────
|
|
|
|
|