mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
150 lines
4.4 KiB
Python
150 lines
4.4 KiB
Python
"""Regression tests: `hermes dashboard` validates HERMES_WEB_DIST before serving.
|
|
|
|
A custom HERMES_WEB_DIST without --skip-build previously skipped BOTH the
|
|
build and any validation, so the server started and served 404s with no
|
|
obvious cause (same failure mode as issue #23817, reached via the env-var
|
|
path instead of --skip-build). The env-var branch must now fail fast when
|
|
the dist has no index.html, and proceed when it does.
|
|
|
|
Design credit: PR #17845 (@Caelier).
|
|
"""
|
|
|
|
import sys
|
|
import types
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture()
|
|
def main_mod():
|
|
import hermes_cli.main as main
|
|
return main
|
|
|
|
|
|
def _args(**over):
|
|
base = {
|
|
"host": "127.0.0.1",
|
|
"port": 0,
|
|
"no_open": True,
|
|
"open_profile": None,
|
|
"skip_build": False,
|
|
"headless_backend": False,
|
|
"tui": False,
|
|
}
|
|
base.update(over)
|
|
return types.SimpleNamespace(**base)
|
|
|
|
|
|
def _wire_common(main_mod, monkeypatch):
|
|
monkeypatch.setattr(
|
|
"hermes_cli.profiles.get_active_profile_name", lambda: "default"
|
|
)
|
|
monkeypatch.setattr(main_mod, "_sync_bundled_skills_quietly", lambda: None)
|
|
monkeypatch.setitem(sys.modules, "fastapi", types.SimpleNamespace())
|
|
monkeypatch.setitem(sys.modules, "uvicorn", types.SimpleNamespace())
|
|
monkeypatch.setitem(
|
|
sys.modules,
|
|
"hermes_logging",
|
|
types.SimpleNamespace(setup_logging=lambda **_k: None),
|
|
)
|
|
monkeypatch.setitem(
|
|
sys.modules,
|
|
"hermes_cli.plugins",
|
|
types.SimpleNamespace(discover_plugins=lambda: None),
|
|
)
|
|
monkeypatch.setattr(
|
|
"hermes_cli.mcp_startup.start_background_mcp_discovery",
|
|
lambda **_k: None,
|
|
)
|
|
|
|
|
|
def test_env_dist_without_index_exits(main_mod, monkeypatch, tmp_path, capsys):
|
|
"""HERMES_WEB_DIST pointing at a dist with no index.html must exit 1,
|
|
not start a server that 404s."""
|
|
_wire_common(main_mod, monkeypatch)
|
|
empty_dist = tmp_path / "empty_dist"
|
|
empty_dist.mkdir()
|
|
monkeypatch.setenv("HERMES_WEB_DIST", str(empty_dist))
|
|
|
|
started = []
|
|
monkeypatch.setitem(
|
|
sys.modules,
|
|
"hermes_cli.web_server",
|
|
types.SimpleNamespace(start_server=lambda **k: started.append(k)),
|
|
)
|
|
builds = []
|
|
monkeypatch.setattr(
|
|
main_mod, "_build_web_ui", lambda *a, **k: builds.append(a) or True
|
|
)
|
|
|
|
with pytest.raises(SystemExit) as exc:
|
|
main_mod.cmd_dashboard(_args())
|
|
|
|
assert exc.value.code == 1
|
|
assert started == []
|
|
assert builds == [] # env var set -> build skipped, validation is the gate
|
|
out = capsys.readouterr().out
|
|
assert "HERMES_WEB_DIST" in out and str(empty_dist) in out
|
|
|
|
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# --skip-build recovery (issue #59288): a missing dist under --skip-build
|
|
# should warn and attempt ONE recovery build via _build_web_ui before the
|
|
# fatal exit, instead of hard-failing immediately.
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_skip_build_missing_dist_attempts_one_recovery_build(
|
|
main_mod, monkeypatch, tmp_path, capsys
|
|
):
|
|
"""--skip-build + missing index.html triggers exactly one recovery build;
|
|
when the build produces a dist, the server starts."""
|
|
_wire_common(main_mod, monkeypatch)
|
|
monkeypatch.delenv("HERMES_WEB_DIST", raising=False)
|
|
project_root = tmp_path / "proj"
|
|
dist = project_root / "hermes_cli" / "web_dist"
|
|
dist.mkdir(parents=True)
|
|
monkeypatch.setattr(main_mod, "PROJECT_ROOT", project_root)
|
|
|
|
started = []
|
|
monkeypatch.setitem(
|
|
sys.modules,
|
|
"hermes_cli.web_server",
|
|
types.SimpleNamespace(start_server=lambda **k: started.append(k)),
|
|
)
|
|
|
|
builds = []
|
|
|
|
def fake_build(web_dir, *, fatal=False):
|
|
builds.append((web_dir, fatal))
|
|
(dist / "index.html").write_text("<html></html>", encoding="utf-8")
|
|
return True
|
|
|
|
monkeypatch.setattr(main_mod, "_build_web_ui", fake_build)
|
|
|
|
main_mod.cmd_dashboard(_args(skip_build=True))
|
|
|
|
assert len(builds) == 1 # exactly ONE recovery build
|
|
assert builds[0][0] == project_root / "web"
|
|
assert len(started) == 1
|
|
out = capsys.readouterr().out
|
|
assert "recovery build" in out.lower()
|
|
|
|
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Desktop-inherited env isolation (issue #52945 / supersedes #52948, #67402)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|