mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
112 lines
3.2 KiB
Python
112 lines
3.2 KiB
Python
"""Guards for ``get_external_skills_dirs`` mtime-based memo.
|
|
|
|
``get_external_skills_dirs()`` is called once per skill during banner
|
|
construction and tool registration — on a typical install that's 120+
|
|
calls. Without caching, each call re-reads + YAML-parses the full
|
|
config.yaml (~85ms each, 10+ seconds total). This test pins the
|
|
behavior: first call parses, subsequent calls return cached result,
|
|
cache invalidates when config.yaml's mtime changes.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
from agent import skill_utils
|
|
from agent.skill_utils import (
|
|
_external_dirs_cache_clear,
|
|
get_external_skills_dirs,
|
|
)
|
|
|
|
|
|
@pytest.fixture
|
|
def hermes_home_with_config(tmp_path, monkeypatch):
|
|
"""Isolated ``~/.hermes/`` with a config.yaml referencing one external dir."""
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
external = tmp_path / "external_skills"
|
|
external.mkdir()
|
|
|
|
config = home / "config.yaml"
|
|
config.write_text(
|
|
"skills:\n"
|
|
f" external_dirs:\n"
|
|
f" - {external}\n",
|
|
encoding="utf-8",
|
|
)
|
|
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
monkeypatch.setattr(Path, "home", lambda: tmp_path)
|
|
_external_dirs_cache_clear()
|
|
yield home, external, config
|
|
_external_dirs_cache_clear()
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_cache_invalidates_on_mtime_change(hermes_home_with_config):
|
|
"""A config.yaml edit invalidates the cache on the next call."""
|
|
_home, external, config = hermes_home_with_config
|
|
other = external.parent / "other_skills"
|
|
other.mkdir()
|
|
|
|
# Prime cache with original contents.
|
|
first = get_external_skills_dirs()
|
|
assert first == [external.resolve()]
|
|
|
|
# Rewrite config; bump mtime forward explicitly so filesystems with
|
|
# coarse mtime granularity still register the change on fast test
|
|
# systems.
|
|
config.write_text(
|
|
"skills:\n"
|
|
f" external_dirs:\n"
|
|
f" - {other}\n",
|
|
encoding="utf-8",
|
|
)
|
|
stat = config.stat()
|
|
future = stat.st_atime + 10
|
|
os.utime(config, (future, future))
|
|
|
|
second = get_external_skills_dirs()
|
|
assert second == [other.resolve()]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_cache_key_is_per_config_path(tmp_path, monkeypatch):
|
|
"""Two different HERMES_HOMEs keep separate cache entries."""
|
|
home_a = tmp_path / "home_a" / ".hermes"
|
|
home_a.mkdir(parents=True)
|
|
ext_a = tmp_path / "ext_a"
|
|
ext_a.mkdir()
|
|
(home_a / "config.yaml").write_text(
|
|
f"skills:\n external_dirs:\n - {ext_a}\n", encoding="utf-8"
|
|
)
|
|
|
|
home_b = tmp_path / "home_b" / ".hermes"
|
|
home_b.mkdir(parents=True)
|
|
ext_b = tmp_path / "ext_b"
|
|
ext_b.mkdir()
|
|
(home_b / "config.yaml").write_text(
|
|
f"skills:\n external_dirs:\n - {ext_b}\n", encoding="utf-8"
|
|
)
|
|
|
|
_external_dirs_cache_clear()
|
|
|
|
monkeypatch.setenv("HERMES_HOME", str(home_a))
|
|
assert get_external_skills_dirs() == [ext_a.resolve()]
|
|
|
|
monkeypatch.setenv("HERMES_HOME", str(home_b))
|
|
assert get_external_skills_dirs() == [ext_b.resolve()]
|
|
|
|
# And switching back still works — both entries coexist in the cache.
|
|
monkeypatch.setenv("HERMES_HOME", str(home_a))
|
|
assert get_external_skills_dirs() == [ext_a.resolve()]
|