mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
82 lines
2.4 KiB
Python
82 lines
2.4 KiB
Python
"""Cross-surface contract for the persistent /approvals mode command."""
|
|
|
|
from types import SimpleNamespace
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import yaml
|
|
|
|
from cli import HermesCLI
|
|
from hermes_cli.commands import (
|
|
GATEWAY_KNOWN_COMMANDS,
|
|
SUBCOMMANDS,
|
|
SlashCommandCompleter,
|
|
gateway_help_lines,
|
|
resolve_command,
|
|
telegram_bot_commands,
|
|
)
|
|
from prompt_toolkit.completion import CompleteEvent
|
|
from prompt_toolkit.document import Document
|
|
|
|
|
|
def _completions(text: str) -> set[str]:
|
|
return {
|
|
item.text
|
|
for item in SlashCommandCompleter().get_completions(
|
|
Document(text=text), CompleteEvent(completion_requested=True)
|
|
)
|
|
}
|
|
|
|
|
|
def test_approvals_registry_drives_help_menu_and_autocomplete():
|
|
command = resolve_command("approvals")
|
|
assert command is not None
|
|
assert command.category == "Configuration"
|
|
assert command.args_hint == "[manual|smart|off]"
|
|
assert SUBCOMMANDS["/approvals"] == ["manual", "smart", "off"]
|
|
assert "approvals" in GATEWAY_KNOWN_COMMANDS
|
|
assert any("/approvals" in line for line in gateway_help_lines())
|
|
assert "approvals" in {name for name, _ in telegram_bot_commands()}
|
|
assert _completions("/approvals ") == {"manual", "smart", "off"}
|
|
|
|
|
|
def _isolate_config(monkeypatch, home):
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
monkeypatch.setenv("HERMES_MANAGED_DIR", str(home / "missing-managed"))
|
|
from hermes_cli import managed_scope
|
|
from hermes_cli.config import _LOAD_CONFIG_CACHE, _RAW_CONFIG_CACHE
|
|
|
|
_LOAD_CONFIG_CACHE.clear()
|
|
_RAW_CONFIG_CACHE.clear()
|
|
managed_scope.invalidate_managed_cache()
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_shared_command_refuses_managed_mode_override(tmp_path, monkeypatch):
|
|
from hermes_cli import managed_scope
|
|
from hermes_cli.approval_mode import run_approval_mode_command
|
|
|
|
home = tmp_path / "home"
|
|
managed = tmp_path / "managed"
|
|
home.mkdir()
|
|
managed.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
monkeypatch.setenv("HERMES_MANAGED_DIR", str(managed))
|
|
(managed / "config.yaml").write_text("approvals:\n mode: manual\n", encoding="utf-8")
|
|
managed_scope.invalidate_managed_cache()
|
|
|
|
result = run_approval_mode_command("off")
|
|
|
|
assert result.ok is False
|
|
assert result.mode == "manual"
|
|
assert result.changed is False
|
|
assert "managed" in result.message.lower()
|
|
assert not (home / "config.yaml").exists()
|
|
|
|
|
|
|
|
|
|
|
|
|