hermes-agent/tests/gateway/test_telegram_status_indicator.py
Teknium 26e76a75e5
feat(telegram): opt-in Online/Offline bot status indicator (#49134)
Sets the Telegram bot's short description (the line under its name) to
"Online" on gateway connect and "Offline" on clean disconnect, gated
behind extra.status_indicator (off by default).

Telegram bots have no presence/online dot — that's a user-account
feature the Bot API doesn't expose for bots. The short description is
the closest available surface, so this gives users a way to tell whether
the gateway is up from the bot's profile.

- New extra.status_indicator flag (+ status_online/status_offline text
  overrides), read in __init__ via config.extra — no config-schema change.
- _set_status_indicator() helper: best-effort, swallows API errors so it
  never blocks connect/disconnect; truncates to Telegram's 120-char cap.
- Wired Online after _mark_connected(), Offline at top of disconnect()
  while the bot HTTP client is still alive.
- 9 unit tests + Telegram docs section.

Requested by @ilTrumpista, cc @Teknium.
2026-06-19 11:38:39 -07:00

120 lines
3.9 KiB
Python

"""Tests for the Telegram bot status indicator.
Telegram bots have no real online/offline presence dot (that's a user-account
feature). The closest Bot API surface is the bot's *short description* — the
line shown under the bot's name in its profile. When `extra.status_indicator`
is enabled, the adapter sets it to "Online" on connect and "Offline" on clean
disconnect so users can tell whether the gateway is up.
"""
import sys
from unittest.mock import AsyncMock, MagicMock
import pytest
from gateway.config import PlatformConfig
def _ensure_telegram_mock():
if "telegram" in sys.modules and hasattr(sys.modules["telegram"], "__file__"):
return
telegram_mod = MagicMock()
telegram_mod.ext.ContextTypes.DEFAULT_TYPE = type(None)
telegram_mod.constants.ParseMode.MARKDOWN_V2 = "MarkdownV2"
telegram_mod.constants.ChatType.GROUP = "group"
telegram_mod.constants.ChatType.SUPERGROUP = "supergroup"
telegram_mod.constants.ChatType.CHANNEL = "channel"
telegram_mod.constants.ChatType.PRIVATE = "private"
for name in ("telegram", "telegram.ext", "telegram.constants", "telegram.request"):
sys.modules.setdefault(name, telegram_mod)
_ensure_telegram_mock()
from gateway.platforms.telegram import TelegramAdapter # noqa: E402
def _make_adapter(extra):
adapter = TelegramAdapter(PlatformConfig(enabled=True, token="***", extra=extra))
adapter._bot = MagicMock()
adapter._bot.set_my_short_description = AsyncMock()
return adapter
def test_disabled_by_default():
adapter = _make_adapter(extra={})
assert adapter._status_indicator_enabled is False
def test_enabled_via_extra():
adapter = _make_adapter(extra={"status_indicator": True})
assert adapter._status_indicator_enabled is True
@pytest.mark.asyncio
async def test_disabled_is_noop():
adapter = _make_adapter(extra={"status_indicator": False})
await adapter._set_status_indicator(online=True)
adapter._bot.set_my_short_description.assert_not_called()
@pytest.mark.asyncio
async def test_online_sets_default_text():
adapter = _make_adapter(extra={"status_indicator": True})
await adapter._set_status_indicator(online=True)
adapter._bot.set_my_short_description.assert_awaited_once_with(
short_description="Online"
)
@pytest.mark.asyncio
async def test_offline_sets_default_text():
adapter = _make_adapter(extra={"status_indicator": True})
await adapter._set_status_indicator(online=False)
adapter._bot.set_my_short_description.assert_awaited_once_with(
short_description="Offline"
)
@pytest.mark.asyncio
async def test_custom_status_strings():
adapter = _make_adapter(
extra={
"status_indicator": True,
"status_online": "🟢 Gateway up",
"status_offline": "🔴 Gateway down",
}
)
await adapter._set_status_indicator(online=True)
adapter._bot.set_my_short_description.assert_awaited_once_with(
short_description="🟢 Gateway up"
)
@pytest.mark.asyncio
async def test_text_truncated_to_120_chars():
adapter = _make_adapter(
extra={"status_indicator": True, "status_online": "x" * 200}
)
await adapter._set_status_indicator(online=True)
_, kwargs = adapter._bot.set_my_short_description.call_args
assert len(kwargs["short_description"]) == 120
@pytest.mark.asyncio
async def test_noop_when_bot_is_none():
adapter = _make_adapter(extra={"status_indicator": True})
adapter._bot = None
# Must not raise even though there's no bot to call.
await adapter._set_status_indicator(online=True)
@pytest.mark.asyncio
async def test_api_failure_is_swallowed():
adapter = _make_adapter(extra={"status_indicator": True})
adapter._bot.set_my_short_description.side_effect = RuntimeError("flood wait")
# Best-effort: a Bot API failure must never propagate out of the helper,
# so it can't block connect/disconnect.
await adapter._set_status_indicator(online=True)