mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
114 lines
3.5 KiB
Python
114 lines
3.5 KiB
Python
"""Tests for tools/microsoft_graph_auth.py."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import asyncio
|
|
|
|
import httpx
|
|
import pytest
|
|
|
|
from tools.microsoft_graph_auth import (
|
|
CachedAccessToken,
|
|
DEFAULT_GRAPH_SCOPE,
|
|
GraphCredentials,
|
|
MicrosoftGraphConfigError,
|
|
MicrosoftGraphTokenError,
|
|
MicrosoftGraphTokenProvider,
|
|
)
|
|
|
|
|
|
class TestGraphCredentials:
|
|
def test_from_env_raises_for_missing_required_values(self):
|
|
with pytest.raises(MicrosoftGraphConfigError) as exc:
|
|
GraphCredentials.from_env({})
|
|
assert "MSGRAPH_TENANT_ID" in str(exc.value)
|
|
assert "MSGRAPH_CLIENT_ID" in str(exc.value)
|
|
assert "MSGRAPH_CLIENT_SECRET" in str(exc.value)
|
|
|
|
def test_from_env_optional_returns_none_when_not_configured(self):
|
|
assert GraphCredentials.from_env({}, required=False) is None
|
|
|
|
def test_from_env_builds_normalized_credentials(self):
|
|
creds = GraphCredentials.from_env(
|
|
{
|
|
"MSGRAPH_TENANT_ID": "tenant-123",
|
|
"MSGRAPH_CLIENT_ID": "client-456",
|
|
"MSGRAPH_CLIENT_SECRET": "secret-789",
|
|
}
|
|
)
|
|
assert creds is not None
|
|
assert creds.scope == DEFAULT_GRAPH_SCOPE
|
|
assert creds.token_url.endswith("/tenant-123/oauth2/v2.0/token")
|
|
|
|
|
|
@pytest.mark.anyio
|
|
class TestMicrosoftGraphTokenProvider:
|
|
async def test_reuses_cached_token_until_expiry(self):
|
|
calls: list[int] = []
|
|
|
|
def handler(request: httpx.Request) -> httpx.Response:
|
|
calls.append(1)
|
|
return httpx.Response(
|
|
200,
|
|
json={
|
|
"access_token": f"token-{len(calls)}",
|
|
"expires_in": 3600,
|
|
"token_type": "Bearer",
|
|
},
|
|
)
|
|
|
|
provider = MicrosoftGraphTokenProvider(
|
|
GraphCredentials("tenant", "client", "secret"),
|
|
transport=httpx.MockTransport(handler),
|
|
)
|
|
|
|
first = await provider.get_access_token()
|
|
second = await provider.get_access_token()
|
|
|
|
assert first == "token-1"
|
|
assert second == "token-1"
|
|
assert len(calls) == 1
|
|
|
|
async def test_concurrent_calls_share_one_token_fetch(self):
|
|
calls: list[int] = []
|
|
|
|
provider = MicrosoftGraphTokenProvider(
|
|
GraphCredentials("tenant", "client", "secret"),
|
|
)
|
|
|
|
async def _fake_fetch():
|
|
calls.append(1)
|
|
await asyncio.sleep(0)
|
|
return CachedAccessToken(
|
|
access_token="token-1",
|
|
token_type="Bearer",
|
|
expires_at=9_999_999_999,
|
|
)
|
|
|
|
provider._fetch_access_token = _fake_fetch # type: ignore[method-assign]
|
|
|
|
first, second = await asyncio.gather(
|
|
provider.get_access_token(),
|
|
provider.get_access_token(),
|
|
)
|
|
|
|
assert first == "token-1"
|
|
assert second == "token-1"
|
|
assert len(calls) == 1
|
|
|
|
|
|
async def test_http_error_includes_server_message(self):
|
|
def handler(request: httpx.Request) -> httpx.Response:
|
|
return httpx.Response(
|
|
401,
|
|
json={"error": "invalid_client", "error_description": "bad secret"},
|
|
)
|
|
|
|
provider = MicrosoftGraphTokenProvider(
|
|
GraphCredentials("tenant", "client", "secret"),
|
|
transport=httpx.MockTransport(handler),
|
|
)
|
|
|
|
with pytest.raises(MicrosoftGraphTokenError) as exc:
|
|
await provider.get_access_token()
|
|
assert "bad secret" in str(exc.value)
|