mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
56 lines
1.6 KiB
Python
56 lines
1.6 KiB
Python
"""Unit tests for hermes_cli.managed_scope (resolver + loaders + key helpers)."""
|
|
import textwrap
|
|
|
|
import pytest
|
|
|
|
|
|
# ── Directory resolver ───────────────────────────────────────────────────────
|
|
|
|
|
|
|
|
|
|
|
|
|
|
# ── Loaders + key helpers ────────────────────────────────────────────────────
|
|
|
|
|
|
def _write_managed(tmp_path, monkeypatch, *, config=None, env=None):
|
|
from hermes_cli import managed_scope
|
|
|
|
managed = tmp_path / "managed"
|
|
managed.mkdir(exist_ok=True)
|
|
if config is not None:
|
|
(managed / "config.yaml").write_text(textwrap.dedent(config), encoding="utf-8")
|
|
if env is not None:
|
|
(managed / ".env").write_text(textwrap.dedent(env), encoding="utf-8")
|
|
monkeypatch.setenv("HERMES_MANAGED_DIR", str(managed))
|
|
managed_scope.invalidate_managed_cache()
|
|
return managed
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_load_managed_env_and_is_env_managed(tmp_path, monkeypatch):
|
|
from hermes_cli import managed_scope
|
|
|
|
_write_managed(
|
|
tmp_path, monkeypatch, env="OPENAI_API_BASE=https://org.example/v1\n"
|
|
)
|
|
assert managed_scope.load_managed_env() == {
|
|
"OPENAI_API_BASE": "https://org.example/v1"
|
|
}
|
|
assert managed_scope.is_env_managed("OPENAI_API_BASE") is True
|
|
assert managed_scope.is_env_managed("OTHER") is False
|
|
|
|
|
|
|
|
|
|
def test_managed_dir_env_scrubbed_by_default():
|
|
"""conftest must scrub HERMES_MANAGED_DIR so a dev-shell value can't leak in."""
|
|
import os
|
|
|
|
assert "HERMES_MANAGED_DIR" not in os.environ
|