mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-09 08:21:50 +00:00
1a626470ca
Subcommands whose handler was a closure defined inside main() — memory, acp, tools, insights, skills, pairing, plugins, mcp, claw — have their handler promoted to a top-level function and their parser block extracted into hermes_cli/subcommands/<name>.py (build_<name>_parser, injected handler). These 9 had zero closure-over-main-locals, so promotion is a pure relocation. acp/mcp parser blocks use the shared add_accept_hooks_flag helper. main() 1798 -> 954 LOC (71% below the 3297 Phase-2 starting point); add_parser calls in main.py 89 -> 28. Deferred: sessions, computer-use, secrets handlers reference <name>_parser (for a no-subcommand print_help fallback) — left in place to avoid the _self_parser indirection; minority, low value. Behavior-neutral: all 9 subcommands' --help (incl nested subactions) byte- identical to pre-extraction (diff-verified). tests/hermes_cli/ 6519 passed / 0 failed; new test_subcommands_followup.py covers the 9 builders.
66 lines
2.5 KiB
Python
66 lines
2.5 KiB
Python
"""Smoke tests for the Phase 2 follow-up subcommand builders (promoted handlers).
|
|
|
|
These 9 subcommands had their handler defined as a closure inside main(); the
|
|
handler was promoted to top-level and the parser block extracted into a builder.
|
|
Confirms each builder attaches its subcommand and wires func to the injected
|
|
handler.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import argparse
|
|
|
|
import pytest
|
|
|
|
from hermes_cli.subcommands.acp import build_acp_parser
|
|
from hermes_cli.subcommands.claw import build_claw_parser
|
|
from hermes_cli.subcommands.insights import build_insights_parser
|
|
from hermes_cli.subcommands.mcp import build_mcp_parser
|
|
from hermes_cli.subcommands.memory import build_memory_parser
|
|
from hermes_cli.subcommands.pairing import build_pairing_parser
|
|
from hermes_cli.subcommands.plugins import build_plugins_parser
|
|
from hermes_cli.subcommands.skills import build_skills_parser
|
|
from hermes_cli.subcommands.tools import build_tools_parser
|
|
|
|
|
|
def _h(name):
|
|
def handler(args): # pragma: no cover - identity only
|
|
return name
|
|
handler.__name__ = f"cmd_{name}"
|
|
return handler
|
|
|
|
|
|
# (subcommand, builder, handler_kwarg, sample argv that should dispatch to func)
|
|
CASES = [
|
|
("memory", build_memory_parser, "cmd_memory", ["memory"]),
|
|
("acp", build_acp_parser, "cmd_acp", ["acp"]),
|
|
("tools", build_tools_parser, "cmd_tools", ["tools"]),
|
|
("insights", build_insights_parser, "cmd_insights", ["insights"]),
|
|
("skills", build_skills_parser, "cmd_skills", ["skills"]),
|
|
("pairing", build_pairing_parser, "cmd_pairing", ["pairing"]),
|
|
("plugins", build_plugins_parser, "cmd_plugins", ["plugins"]),
|
|
("mcp", build_mcp_parser, "cmd_mcp", ["mcp"]),
|
|
("claw", build_claw_parser, "cmd_claw", ["claw"]),
|
|
]
|
|
|
|
|
|
@pytest.mark.parametrize("name,builder,kw,argv", CASES, ids=[c[0] for c in CASES])
|
|
def test_followup_builders_dispatch(name, builder, kw, argv):
|
|
parser = argparse.ArgumentParser(prog="hermes")
|
|
sub = parser.add_subparsers(dest="command")
|
|
handler = _h(name)
|
|
builder(sub, **{kw: handler})
|
|
ns = parser.parse_args(argv)
|
|
assert ns.command == name
|
|
assert ns.func is handler
|
|
|
|
|
|
def test_mcp_and_acp_accept_hooks_flag():
|
|
# mcp/acp parser blocks use the shared add_accept_hooks_flag helper.
|
|
parser = argparse.ArgumentParser(prog="hermes")
|
|
sub = parser.add_subparsers(dest="command")
|
|
build_mcp_parser(sub, cmd_mcp=_h("mcp"))
|
|
build_acp_parser(sub, cmd_acp=_h("acp"))
|
|
# acp takes --accept-hooks at top level
|
|
ns = parser.parse_args(["acp", "--accept-hooks"])
|
|
assert ns.accept_hooks is True
|