mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
Address @ethernet8023's review nits (both flagged non-blocking):
- Extract the copy-pasted retried `gh pr view` label-fetch loop (lint.yml
ci-review gate + supply-chain-audit.yml mcp-catalog gate) into a single
.github/actions/gh-pr-labels composite action. It preserves the exact
semantics the reviewer verified: retry on transient API failure, exit 1
after N attempts (re-runnable), and a clean fetch that simply lacks the
label reports has-label=false rather than hard-failing. Both gates now
consume the has-label output.
- Rewrite the Dockerfile playwright retry from the compact
`&& break || { ... }` one-liner into the readable multi-line if/sleep
form used everywhere else.
E2E-verified the composite action against a stubbed gh across four cases:
label present -> has-label=true; absent -> has-label=false; API always
fails -> exit 1 + annotation, no output written; transient (fail-once) ->
recovers and reports true. All workflow/action YAML parses; bash -n clean.
|
||
|---|---|---|
| .. | ||
| detect-changes | ||
| gh-pr-labels | ||
| nix-setup | ||
| retry | ||