mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-23 16:36:23 +00:00
b9f82ed39f
Replace the static comment-pending + comment-results two-job pattern
with a live-updating comment system that polls the GitHub Actions API
every 15s, re-assembles the review comment from whatever results are
available, and upserts it via the <!-- hermes-ci-review-bot --> marker.
The comment updates in real time as each job finishes — no waiting for
the full pipeline.
Every CI job that wants to appear in the review comment emits a
review_status output — a JSON array of objects, each with a source
and a results array:
[
{
"source": "review-label-gate",
"results": [
{"kind": "action_required", "title": "...", "summary": "...",
"how_to_fix": "..."},
{"kind": "info", "title": "...", "summary": "..."}
]
},
{
"source": "ci timing",
"results": [
{"kind": "warning", "title": "CI timings", "summary": "...",
"detail": "...", "link": "..."}
]
}
]
One job can emit multiple results of different kinds. The source field
is used to exclude the corresponding job from the synthesized error
list (case-insensitive, hyphen-normalized matching against GitHub
Actions job display names).
| job | source | kind (on failure) | section |
|----------------------------|--------------------------|---------------------------|----------------------|
| review-labels | review label gate | action_required / info | Action required |
| lockfile-diff | lockfile-diff | action_required | Action required |
| ci-timings | ci timing | warning / info | Warnings |
| supply-chain scan | supply chain | error / (none) | Job failures |
| supply-chain dep-bounds | supply chain | action_required / (none) | Action required |
| osv-scanner | osv scan | warning / (none) | Warnings |
| uv-lockfile-check | uv.lock check | action_required / (none) | Action required |
| history-check | unrelated histories | action_required | Action required |
| contributor-check | contributor attribution | action_required | Action required |
Jobs that find nothing emit [] (empty array) — no noise info items.
A single comment-live job polls the GitHub Actions API every 15s,
classifies jobs into (completed, pending), assembles the comment, and
upserts it. Merges review_status outputs from all needs jobs via
toJSON(needs.*.outputs.review_status), and downloads the ci-timings
artifact when it becomes available. Shows commit SHA + message below
the header.
The assembler has ZERO job-specific knowledge. It just:
1. collect_from_statuses() — flattens all nested status objects into ReviewItems
2. collect_failed_jobs() — synthesizes errors for failed jobs with no declared status
3. _attach_job_urls() — fills in per-job log links for ALL items
4. render_comment() — groups by severity, renders with group headers
Each item shows links inline next to the title: View report (job-emitted
URL) and View job (auto-attached logs link). Each info item is its own
collapsible <details> block.
# ૮ >ﻌ< ა ci review
running on abc1234 — commit message first line
## ❌ Job failures
### {title} · [View job](url)
{summary}
## ⚠️ Action required
### {title} · [View job](url)
{summary}
**How to fix:**
{how_to_fix}
## ⚠️ Warnings
### {title} · [View report](url) · [View job](url)
{summary}
{detail}
<details><summary>{title}</summary>
{content}
</details>
Still running 3 jobs: ci-timings, docker
- test_assemble_review_comment.py (48 tests): collect_from_statuses,
collect_failed_jobs with exclude_sources, _attach_job_urls,
render_comment (group headers, inline links, commit info, per-item
details, pending footer), assemble integration
- test_live_comment.py (16 tests): classify_jobs pure function
- test_timings_report.py (10 tests): generate_review_status nested format
- test_lockfile_diff.py (6 tests)
- test_classify_changes.py (32 tests, pre-existing)
81 lines
3 KiB
YAML
81 lines
3 KiB
YAML
name: Label rerun
|
|
|
|
# When the ``ci-reviewed`` label is added to a PR, rerun all failed jobs in
|
|
# the latest CI run. This re-evaluates ``review-labels`` (which now sees the
|
|
# label) and GitHub automatically reruns dependent jobs (``comment-live``,
|
|
# ``all-checks-pass``) — so the review comment gets updated too.
|
|
#
|
|
# If the CI run is still in progress when the label is added, we wait for it
|
|
# to finish before rerunning (``gh run rerun`` only works on completed runs).
|
|
# The wait can be long (20+ min for a full CI run), but it's better than
|
|
# silently failing and leaving the reviewer stuck.
|
|
|
|
on:
|
|
pull_request:
|
|
types: [labeled]
|
|
|
|
permissions:
|
|
actions: write
|
|
pull-requests: read
|
|
|
|
concurrency:
|
|
group: label-rerun-${{ github.event.pull_request.number }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
rerun-review-labels:
|
|
name: Rerun review-labels job
|
|
if: github.event.label.name == 'ci-reviewed'
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 40
|
|
steps:
|
|
- name: Wait for CI run to finish, then rerun failed jobs
|
|
env:
|
|
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
REPO: ${{ github.repository }}
|
|
HEAD_SHA: ${{ github.event.pull_request.head.sha }}
|
|
run: |
|
|
set -uo pipefail
|
|
|
|
# Find the latest CI run for this PR's head SHA.
|
|
RUN_ID=$(gh run list \
|
|
--repo "$REPO" \
|
|
--commit "$HEAD_SHA" \
|
|
--workflow ci.yml \
|
|
--limit 1 \
|
|
--json databaseId,status \
|
|
--jq '.[0] | "\(.databaseId) \(.status)"' 2>/dev/null || true)
|
|
|
|
if [ -z "$RUN_ID" ]; then
|
|
echo "No CI run found for this PR — nothing to rerun."
|
|
exit 0
|
|
fi
|
|
|
|
# Split "RUN_ID STATUS" into two vars.
|
|
RUN_ID="${RUN_ID%% *}"
|
|
STATUS="${RUN_ID##* }"
|
|
|
|
echo "Latest CI run: $RUN_ID (status: $STATUS)"
|
|
|
|
# If the run is still in progress, wait for it to finish.
|
|
# gh run rerun only works on completed runs — if we try while it's
|
|
# running, GitHub rejects with "cannot be rerun; This workflow is
|
|
# already running".
|
|
if [ "$STATUS" != "completed" ]; then
|
|
echo "Run is $STATUS — waiting for completion (this may take a while)..."
|
|
# gh run watch --exit-status exits non-zero if the run fails,
|
|
# which is expected (the label gate fails). Don't let that kill
|
|
# the workflow — we WANT to rerun failed jobs.
|
|
timeout 2100 gh run watch "$RUN_ID" --repo "$REPO" --interval 15 || true
|
|
|
|
# Verify it's actually completed now.
|
|
STATUS=$(gh run view "$RUN_ID" --repo "$REPO" --json status --jq '.status' 2>/dev/null || echo "unknown")
|
|
if [ "$STATUS" != "completed" ]; then
|
|
echo "Run is still $STATUS after wait — giving up."
|
|
exit 0
|
|
fi
|
|
fi
|
|
|
|
echo "Run completed. Rerunning all failed jobs..."
|
|
gh run rerun "$RUN_ID" --repo "$REPO" --failed || true
|
|
echo "Done. GitHub will rerun review-labels and all dependent jobs."
|