mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-29 18:46:59 +00:00
Rework of #68509 per triage: hoist the duplicated per-tool _resolve_provider_key helpers into one owner, tools.tool_backend_helpers.resolve_provider_secret(), and migrate every STT/TTS key lookup site to it. Resolution order: explicit config.yaml value > profile secret scope / env / ~/.hermes/.env > credential pool (checks both '<provider>' and 'custom:<provider>' pool keys, so keys added via 'hermes auth add mistral' or declared under providers.<name> both resolve). Under an active multiplex turn the profile scope stays authoritative — no pool or .env fallback that could borrow another profile's key (composes with the #69469 scope fix). Coverage now includes GROQ_API_KEY, MISTRAL_API_KEY, ELEVENLABS_API_KEY, DEEPINFRA_API_KEY, MINIMAX_API_KEY, GEMINI_API_KEY/GOOGLE_API_KEY, the XAI_API_KEY fallback in resolve_xai_http_credentials, and the OpenAI audio key (resolve_openai_audio_api_key now pool-aware for OPENAI_API_KEY via 'hermes auth add openai-api'). Unit tests: fake pool entry proves each provider resolves from the pool when env is empty; env still wins when set; config wins over both; a multiplex scope miss never borrows the pool; pool read failures never raise; tool-level wiring for STT, TTS, xAI, and OpenAI audio. Fixes #68003
311 lines
11 KiB
Python
311 lines
11 KiB
Python
"""Shared helpers for tool backend selection."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
import os
|
|
from pathlib import Path
|
|
from typing import Any, Dict
|
|
|
|
from utils import is_truthy_value
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
_DEFAULT_BROWSER_PROVIDER = "local"
|
|
_DEFAULT_MODAL_MODE = "auto"
|
|
_VALID_MODAL_MODES = {"auto", "direct", "managed"}
|
|
|
|
|
|
def managed_nous_tools_enabled(*, force_fresh: bool = False) -> bool:
|
|
"""Return True when the user is entitled to the Nous Tool Gateway.
|
|
|
|
Entitlement is paid Nous Portal service access OR a live free tool pool
|
|
(``tool_gateway_entitled``). Per-category coverage (the pool funds image but
|
|
not video, etc.) is narrowed by callers via ``tool_gateway_entitled_for``;
|
|
this coarse gate only answers "is any managed tool usable at all".
|
|
|
|
Tool Gateway availability fails closed on unknown/error entitlement. We
|
|
intentionally catch all exceptions and return False — never block startup.
|
|
``force_fresh=True`` is for interactive configuration flows that should
|
|
reflect a just-purchased subscription, credits, or pool grant immediately.
|
|
"""
|
|
try:
|
|
from hermes_cli.nous_account import get_nous_portal_account_info
|
|
|
|
if force_fresh:
|
|
account_info = get_nous_portal_account_info(force_fresh=True)
|
|
else:
|
|
account_info = get_nous_portal_account_info()
|
|
if not account_info.logged_in:
|
|
return False
|
|
return account_info.tool_gateway_entitled
|
|
except Exception:
|
|
return False
|
|
|
|
|
|
def nous_tool_gateway_unavailable_message(
|
|
capability: str = "the Nous Tool Gateway",
|
|
*,
|
|
force_fresh: bool = False,
|
|
) -> str:
|
|
"""Return account-aware guidance for an unavailable Nous Tool Gateway path."""
|
|
try:
|
|
from hermes_cli.nous_account import (
|
|
format_nous_portal_entitlement_message,
|
|
get_nous_portal_account_info,
|
|
)
|
|
|
|
account_info = get_nous_portal_account_info(force_fresh=force_fresh)
|
|
message = format_nous_portal_entitlement_message(
|
|
account_info,
|
|
capability=capability,
|
|
)
|
|
if message:
|
|
return message
|
|
except Exception:
|
|
pass
|
|
return (
|
|
f"{capability} is unavailable. Run `hermes model` to refresh your "
|
|
"Nous Portal login and billing status."
|
|
)
|
|
|
|
|
|
def normalize_browser_cloud_provider(value: object | None) -> str:
|
|
"""Return a normalized browser provider key."""
|
|
provider = str(value or _DEFAULT_BROWSER_PROVIDER).strip().lower()
|
|
return provider or _DEFAULT_BROWSER_PROVIDER
|
|
|
|
|
|
def coerce_modal_mode(value: object | None) -> str:
|
|
"""Return the requested modal mode when valid, else the default."""
|
|
mode = str(value or _DEFAULT_MODAL_MODE).strip().lower()
|
|
if mode in _VALID_MODAL_MODES:
|
|
return mode
|
|
return _DEFAULT_MODAL_MODE
|
|
|
|
|
|
def normalize_modal_mode(value: object | None) -> str:
|
|
"""Return a normalized modal execution mode."""
|
|
return coerce_modal_mode(value)
|
|
|
|
|
|
def has_direct_modal_credentials() -> bool:
|
|
"""Return True when direct Modal credentials/config are available."""
|
|
try:
|
|
modal_file_exists = (Path.home() / ".modal.toml").exists()
|
|
except (PermissionError, OSError):
|
|
modal_file_exists = False
|
|
return bool(
|
|
(os.getenv("MODAL_TOKEN_ID") and os.getenv("MODAL_TOKEN_SECRET"))
|
|
or modal_file_exists
|
|
)
|
|
|
|
|
|
def resolve_modal_backend_state(
|
|
modal_mode: object | None,
|
|
*,
|
|
has_direct: bool,
|
|
managed_ready: bool,
|
|
managed_enabled: bool | None = None,
|
|
) -> Dict[str, Any]:
|
|
"""Resolve direct vs managed Modal backend selection.
|
|
|
|
Semantics:
|
|
- ``direct`` means direct-only
|
|
- ``managed`` means managed-only
|
|
- ``auto`` prefers managed when available, then falls back to direct
|
|
"""
|
|
requested_mode = coerce_modal_mode(modal_mode)
|
|
normalized_mode = normalize_modal_mode(modal_mode)
|
|
if managed_enabled is None:
|
|
managed_enabled = managed_nous_tools_enabled()
|
|
managed_mode_blocked = (
|
|
requested_mode == "managed" and not managed_enabled
|
|
)
|
|
|
|
if normalized_mode == "managed":
|
|
selected_backend = "managed" if managed_enabled and managed_ready else None
|
|
elif normalized_mode == "direct":
|
|
selected_backend = "direct" if has_direct else None
|
|
else:
|
|
selected_backend = "managed" if managed_enabled and managed_ready else "direct" if has_direct else None
|
|
|
|
return {
|
|
"requested_mode": requested_mode,
|
|
"mode": normalized_mode,
|
|
"has_direct": has_direct,
|
|
"managed_ready": managed_ready,
|
|
"managed_mode_blocked": managed_mode_blocked,
|
|
"selected_backend": selected_backend,
|
|
}
|
|
|
|
|
|
def _scoped_credential(name: str) -> str:
|
|
"""Read a credential env var under the active profile secret scope.
|
|
|
|
Falls back to a raw read only when ``agent.secret_scope`` cannot be
|
|
imported, so a packaging edge never leaves the caller without a key.
|
|
"""
|
|
try:
|
|
from agent.secret_scope import get_secret
|
|
|
|
return (get_secret(name, "") or "").strip()
|
|
except Exception: # pragma: no cover — secret_scope is in-repo
|
|
return (os.getenv(name, "") or "").strip()
|
|
|
|
|
|
def resolve_provider_secret(
|
|
env_var: str,
|
|
provider_id: str,
|
|
config_value: str = "",
|
|
env_getter=None,
|
|
) -> str:
|
|
"""Resolve a voice-provider API key. Single owner for STT/TTS key lookup.
|
|
|
|
Resolution order (fixes #68003 — keys added via ``hermes auth add
|
|
<provider>`` were invisible to the voice tools, which only consulted
|
|
env/.env):
|
|
|
|
1. An explicit ``config_value`` from config.yaml, when the caller has one.
|
|
2. The environment / ``~/.hermes/.env``. Under a multiplexed gateway turn
|
|
this reads the active profile's secret scope (authoritative — a scope
|
|
miss must NOT borrow another profile's ``os.environ``; see
|
|
``agent/secret_scope.py``). Outside multiplexing it reads
|
|
``hermes_cli.config.get_env_value`` (os.environ, then ``.env``),
|
|
matching the tools' historical behaviour exactly.
|
|
3. The credential pool / auth store for ``provider_id`` (``hermes auth
|
|
add <provider_id>``). Skipped under an active multiplex turn, where
|
|
only the profile scope is authoritative for credentials.
|
|
|
|
Never raises — credential resolution must not hard-fail on a pool or
|
|
config read; returns ``""`` when no key is found anywhere.
|
|
|
|
``env_getter`` lets callers supply their module-level ``get_env_value``
|
|
wrapper (transcription_tools / tts_tool expose one that tests patch);
|
|
when omitted, ``hermes_cli.config.get_env_value`` is used directly.
|
|
"""
|
|
value = str(config_value or "").strip()
|
|
if value:
|
|
return value
|
|
|
|
# Scope-aware env read: under a multiplexed gateway turn this reads the
|
|
# active profile's secret scope (authoritative); otherwise it reads the
|
|
# scope overlay then os.environ (see ``agent.secret_scope.get_secret``).
|
|
key = _scoped_credential(env_var)
|
|
if key:
|
|
return key
|
|
|
|
try:
|
|
from agent.secret_scope import is_multiplex_active
|
|
|
|
if is_multiplex_active():
|
|
# Under multiplexing the profile scope is authoritative: do not
|
|
# fall through to the process-global .env or credential pool,
|
|
# which may belong to a different profile than the current turn.
|
|
return ""
|
|
except Exception: # pragma: no cover — secret_scope is in-repo
|
|
pass
|
|
|
|
if env_getter is not None:
|
|
key = str(env_getter(env_var) or "").strip()
|
|
else:
|
|
try:
|
|
from hermes_cli.config import get_env_value
|
|
|
|
key = str(get_env_value(env_var) or "").strip()
|
|
except ImportError: # pragma: no cover — config is in-repo
|
|
key = ""
|
|
if key:
|
|
return key
|
|
|
|
if not provider_id:
|
|
return ""
|
|
try:
|
|
from agent.credential_pool import load_pool
|
|
|
|
# `hermes auth add <provider>` keys a registry provider by its plain
|
|
# id, but a provider declared via config.yaml ``providers.<name>`` /
|
|
# ``custom_providers`` is pooled under ``custom:<name>`` (see
|
|
# agent/credential_pool.py CUSTOM_POOL_PREFIX). Check both.
|
|
for pool_key in (provider_id, f"custom:{provider_id}"):
|
|
pool = load_pool(pool_key)
|
|
if pool is None or not pool.has_credentials():
|
|
continue
|
|
entry = pool.peek()
|
|
if entry is None:
|
|
continue
|
|
key = str(
|
|
getattr(entry, "runtime_api_key", "")
|
|
or getattr(entry, "access_token", "")
|
|
or ""
|
|
).strip()
|
|
if key:
|
|
return key
|
|
except Exception as exc:
|
|
logger.debug(
|
|
"Could not read %s credential pool for %s: %s",
|
|
provider_id,
|
|
env_var,
|
|
exc,
|
|
)
|
|
return ""
|
|
|
|
|
|
def resolve_openai_audio_api_key() -> str:
|
|
"""Prefer the voice-tools key, but fall back to the normal OpenAI key.
|
|
|
|
Routed through the profile secret scope rather than reading ``os.environ``
|
|
directly: in a multiplex gateway serving several profiles from one
|
|
process, ``os.environ`` reflects whichever profile's ``.env`` happened to
|
|
load at boot, not the profile the current turn belongs to. A raw read here
|
|
lets one profile's TTS reply / voice-note transcription authenticate as —
|
|
and get billed against — a different profile's OpenAI account. Same
|
|
routing the WeChat send path and ``agent/vertex_adapter`` already use; see
|
|
``agent/secret_scope.py``.
|
|
|
|
Outside a multiplexed turn, ``OPENAI_API_KEY`` additionally falls back to
|
|
the credential pool (``hermes auth add openai-api``) via
|
|
``resolve_provider_secret`` — same #68003 fix as the other voice
|
|
providers. The dedicated voice-tools override remains env/scope-only.
|
|
"""
|
|
return (
|
|
resolve_provider_secret("VOICE_TOOLS_OPENAI_KEY", "")
|
|
or resolve_provider_secret("OPENAI_API_KEY", "openai-api")
|
|
)
|
|
|
|
|
|
def prefers_gateway(config_section: str) -> bool:
|
|
"""Return True when the user opted into the Tool Gateway for this tool.
|
|
|
|
Reads ``<section>.use_gateway`` from config.yaml. Never raises.
|
|
"""
|
|
try:
|
|
from hermes_cli.config import load_config
|
|
section = (load_config() or {}).get(config_section)
|
|
if isinstance(section, dict):
|
|
return is_truthy_value(section.get("use_gateway"), default=False)
|
|
except Exception:
|
|
pass
|
|
return False
|
|
|
|
|
|
def fal_key_is_configured() -> bool:
|
|
"""Return True when FAL_KEY is set to a non-whitespace value.
|
|
|
|
Consults both ``os.environ`` and ``~/.hermes/.env`` (via
|
|
``hermes_cli.config.get_env_value`` when available) so tool-side
|
|
checks and CLI setup-time checks agree. A whitespace-only value
|
|
is treated as unset everywhere.
|
|
"""
|
|
value = os.getenv("FAL_KEY")
|
|
if value is None:
|
|
# Fall back to the .env file for CLI paths that may run before
|
|
# dotenv is loaded into os.environ.
|
|
try:
|
|
from hermes_cli.config import get_env_value
|
|
|
|
value = get_env_value("FAL_KEY")
|
|
except Exception:
|
|
value = None
|
|
return bool(value and value.strip())
|