"""Tests for topic-aware gateway progress updates.""" import importlib import sys import time import types from types import SimpleNamespace import pytest from gateway.config import Platform, PlatformConfig from gateway.platforms.base import BasePlatformAdapter, SendResult from gateway.session import SessionSource class ProgressCaptureAdapter(BasePlatformAdapter): def __init__(self, platform=Platform.TELEGRAM): super().__init__(PlatformConfig(enabled=True, token="***"), platform) self.sent = [] self.edits = [] self.typing = [] async def connect(self) -> bool: return True async def disconnect(self) -> None: return None async def send(self, chat_id, content, reply_to=None, metadata=None) -> SendResult: self.sent.append( { "chat_id": chat_id, "content": content, "reply_to": reply_to, "metadata": metadata, } ) return SendResult(success=True, message_id="progress-1") async def edit_message(self, chat_id, message_id, content) -> SendResult: self.edits.append( { "chat_id": chat_id, "message_id": message_id, "content": content, } ) return SendResult(success=True, message_id=message_id) async def send_typing(self, chat_id, metadata=None) -> None: self.typing.append({"chat_id": chat_id, "metadata": metadata}) async def get_chat_info(self, chat_id: str): return {"id": chat_id} class FakeAgent: def __init__(self, **kwargs): self.tool_progress_callback = kwargs.get("tool_progress_callback") self.tools = [] def run_conversation(self, message, conversation_history=None, task_id=None): self.tool_progress_callback("tool.started", "terminal", "pwd", {}) time.sleep(0.35) self.tool_progress_callback("tool.started", "browser_navigate", "https://example.com", {}) time.sleep(0.35) return { "final_response": "done", "messages": [], "api_calls": 1, } class LongPreviewAgent: """Agent that emits a tool call with a very long preview string.""" LONG_CMD = "cd /home/teknium/.hermes/hermes-agent/.worktrees/hermes-d8860339 && source .venv/bin/activate && python -m pytest tests/gateway/test_run_progress_topics.py -n0 -q" def __init__(self, **kwargs): self.tool_progress_callback = kwargs.get("tool_progress_callback") self.tools = [] def run_conversation(self, message, conversation_history=None, task_id=None): self.tool_progress_callback("tool.started", "terminal", self.LONG_CMD, {}) time.sleep(0.35) return { "final_response": "done", "messages": [], "api_calls": 1, } def _make_runner(adapter): gateway_run = importlib.import_module("gateway.run") GatewayRunner = gateway_run.GatewayRunner runner = object.__new__(GatewayRunner) runner.adapters = {adapter.platform: adapter} runner._voice_mode = {} runner._prefill_messages = [] runner._ephemeral_system_prompt = "" runner._reasoning_config = None runner._provider_routing = {} runner._fallback_model = None runner._session_db = None runner._running_agents = {} runner.hooks = SimpleNamespace(loaded_hooks=False) return runner @pytest.mark.asyncio async def test_run_agent_progress_stays_in_originating_topic(monkeypatch, tmp_path): monkeypatch.setenv("HERMES_TOOL_PROGRESS_MODE", "all") fake_dotenv = types.ModuleType("dotenv") fake_dotenv.load_dotenv = lambda *args, **kwargs: None monkeypatch.setitem(sys.modules, "dotenv", fake_dotenv) fake_run_agent = types.ModuleType("run_agent") fake_run_agent.AIAgent = FakeAgent monkeypatch.setitem(sys.modules, "run_agent", fake_run_agent) adapter = ProgressCaptureAdapter() runner = _make_runner(adapter) gateway_run = importlib.import_module("gateway.run") monkeypatch.setattr(gateway_run, "_hermes_home", tmp_path) monkeypatch.setattr(gateway_run, "_resolve_runtime_agent_kwargs", lambda: {"api_key": "fake"}) source = SessionSource( platform=Platform.TELEGRAM, chat_id="-1001", chat_type="group", thread_id="17585", ) result = await runner._run_agent( message="hello", context_prompt="", history=[], source=source, session_id="sess-1", session_key="agent:main:telegram:group:-1001:17585", ) assert result["final_response"] == "done" assert adapter.sent == [ { "chat_id": "-1001", "content": '⚙️ terminal: "pwd"', "reply_to": None, "metadata": {"thread_id": "17585"}, } ] assert adapter.edits assert all(call["metadata"] == {"thread_id": "17585"} for call in adapter.typing) @pytest.mark.asyncio async def test_run_agent_progress_does_not_use_event_message_id_for_telegram_dm(monkeypatch, tmp_path): """Telegram DM progress must not reuse event message id as thread metadata.""" monkeypatch.setenv("HERMES_TOOL_PROGRESS_MODE", "all") fake_dotenv = types.ModuleType("dotenv") fake_dotenv.load_dotenv = lambda *args, **kwargs: None monkeypatch.setitem(sys.modules, "dotenv", fake_dotenv) fake_run_agent = types.ModuleType("run_agent") fake_run_agent.AIAgent = FakeAgent monkeypatch.setitem(sys.modules, "run_agent", fake_run_agent) adapter = ProgressCaptureAdapter(platform=Platform.TELEGRAM) runner = _make_runner(adapter) gateway_run = importlib.import_module("gateway.run") monkeypatch.setattr(gateway_run, "_hermes_home", tmp_path) monkeypatch.setattr(gateway_run, "_resolve_runtime_agent_kwargs", lambda: {"api_key": "***"}) source = SessionSource( platform=Platform.TELEGRAM, chat_id="12345", chat_type="dm", thread_id=None, ) result = await runner._run_agent( message="hello", context_prompt="", history=[], source=source, session_id="sess-2", session_key="agent:main:telegram:dm:12345", event_message_id="777", ) assert result["final_response"] == "done" assert adapter.sent assert adapter.sent[0]["metadata"] is None assert all(call["metadata"] is None for call in adapter.typing) @pytest.mark.asyncio async def test_run_agent_progress_uses_event_message_id_for_slack_dm(monkeypatch, tmp_path): """Slack DM progress should keep event ts fallback threading.""" monkeypatch.setenv("HERMES_TOOL_PROGRESS_MODE", "all") fake_dotenv = types.ModuleType("dotenv") fake_dotenv.load_dotenv = lambda *args, **kwargs: None monkeypatch.setitem(sys.modules, "dotenv", fake_dotenv) fake_run_agent = types.ModuleType("run_agent") fake_run_agent.AIAgent = FakeAgent monkeypatch.setitem(sys.modules, "run_agent", fake_run_agent) adapter = ProgressCaptureAdapter(platform=Platform.SLACK) runner = _make_runner(adapter) gateway_run = importlib.import_module("gateway.run") monkeypatch.setattr(gateway_run, "_hermes_home", tmp_path) monkeypatch.setattr(gateway_run, "_resolve_runtime_agent_kwargs", lambda: {"api_key": "***"}) source = SessionSource( platform=Platform.SLACK, chat_id="D123", chat_type="dm", thread_id=None, ) result = await runner._run_agent( message="hello", context_prompt="", history=[], source=source, session_id="sess-3", session_key="agent:main:slack:dm:D123", event_message_id="1234567890.000001", ) assert result["final_response"] == "done" assert adapter.sent assert adapter.sent[0]["metadata"] == {"thread_id": "1234567890.000001"} assert all(call["metadata"] == {"thread_id": "1234567890.000001"} for call in adapter.typing) # --------------------------------------------------------------------------- # Preview truncation tests (all/new mode respects tool_preview_length) # --------------------------------------------------------------------------- def _run_long_preview_helper(monkeypatch, tmp_path, preview_length=0): """Shared setup for long-preview truncation tests. Returns (adapter, result) after running the agent with LongPreviewAgent. ``preview_length`` controls display.tool_preview_length in the config file that _run_agent reads — so the gateway picks it up the same way production does. """ import asyncio import yaml monkeypatch.setenv("HERMES_TOOL_PROGRESS_MODE", "all") fake_dotenv = types.ModuleType("dotenv") fake_dotenv.load_dotenv = lambda *args, **kwargs: None monkeypatch.setitem(sys.modules, "dotenv", fake_dotenv) fake_run_agent = types.ModuleType("run_agent") fake_run_agent.AIAgent = LongPreviewAgent monkeypatch.setitem(sys.modules, "run_agent", fake_run_agent) # Write config.yaml so _run_agent picks up tool_preview_length config = {"display": {"tool_preview_length": preview_length}} (tmp_path / "config.yaml").write_text(yaml.dump(config), encoding="utf-8") adapter = ProgressCaptureAdapter() runner = _make_runner(adapter) gateway_run = importlib.import_module("gateway.run") monkeypatch.setattr(gateway_run, "_hermes_home", tmp_path) monkeypatch.setattr(gateway_run, "_resolve_runtime_agent_kwargs", lambda: {"api_key": "***"}) source = SessionSource( platform=Platform.TELEGRAM, chat_id="12345", chat_type="dm", thread_id=None, ) result = asyncio.get_event_loop().run_until_complete( runner._run_agent( message="hello", context_prompt="", history=[], source=source, session_id="sess-trunc", session_key="agent:main:telegram:dm:12345", ) ) return adapter, result def test_all_mode_default_truncation_40_chars(monkeypatch, tmp_path): """When tool_preview_length is 0 (default), all/new mode truncates to 40 chars.""" adapter, result = _run_long_preview_helper(monkeypatch, tmp_path, preview_length=0) assert result["final_response"] == "done" assert adapter.sent content = adapter.sent[0]["content"] # The long command should be truncated — total preview <= 40 chars assert "..." in content # Extract the preview part between quotes import re match = re.search(r'"(.+)"', content) assert match, f"No quoted preview found in: {content}" preview_text = match.group(1) assert len(preview_text) <= 40, f"Preview too long ({len(preview_text)}): {preview_text}" def test_all_mode_respects_custom_preview_length(monkeypatch, tmp_path): """When tool_preview_length is explicitly set (e.g. 120), all/new mode uses that.""" adapter, result = _run_long_preview_helper(monkeypatch, tmp_path, preview_length=120) assert result["final_response"] == "done" assert adapter.sent content = adapter.sent[0]["content"] # With 120-char cap, the command (165 chars) should still be truncated but longer import re match = re.search(r'"(.+)"', content) assert match, f"No quoted preview found in: {content}" preview_text = match.group(1) # Should be longer than the 40-char default assert len(preview_text) > 40, f"Preview suspiciously short ({len(preview_text)}): {preview_text}" # But still capped at 120 assert len(preview_text) <= 120, f"Preview too long ({len(preview_text)}): {preview_text}" def test_all_mode_no_truncation_when_preview_fits(monkeypatch, tmp_path): """Short previews (under the cap) are not truncated.""" # Set a generous cap — the LongPreviewAgent's command is ~165 chars adapter, result = _run_long_preview_helper(monkeypatch, tmp_path, preview_length=200) assert result["final_response"] == "done" assert adapter.sent content = adapter.sent[0]["content"] # With a 200-char cap, the 165-char command should NOT be truncated assert "..." not in content, f"Preview was truncated when it shouldn't be: {content}"