hermes-agent

mirrors/hermes-agent

Fork 0

mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-05-06 02:41:48 +00:00

Commit graph

Author	SHA1	Message	Date
brooklyn!	6b09df39be	fix(tui): restore macOS copy behavior and theme polish (#17131 ) This PR groups the TUI fixes that restore macOS Terminal usability and clean up the theme/composer regressions: - copy transcript selections on macOS drag-release so Terminal.app users can copy while mouse tracking is enabled - copy composer selections on macOS drag-release; composer selection is internal to TextInput and does not use the global Ink selection bus - keep IDE Cmd+C forwarding setup macOS-only, and make keybinding conflict checks respect simple when-clause overlap/negation - force truecolor before chalk initializes (unless NO_COLOR / FORCE_COLOR / HERMES_TUI_TRUECOLOR opt-outs apply) so the default banner keeps its gold/amber/bronze gradient in Terminal.app - move TUI surfaces onto semantic theme tokens and preserve skin prompt symbols as bare tokens with renderer-owned spacing - render focused placeholders as dim hint text in TTY mode instead of inverse/selected-looking synthetic cursor text	2026-04-28 18:47:14 -05:00
Brooklyn Nicholson	b1c49d5e73	chore(tui): /clean recent perf work — KISS/DRY pass 24 files, -319 LoC. Behaviour preserved, 369/369 tests green. - hermes-ink caches: shared lruEvict helper for the four parallel LRU caches (stringWidth, wrapText, sliceAnsi, lineWidth); touch-on-read stays inlined per cache; tightened output.ts skip-slice fast path. - wheelAccel: trimmed provenance header, collapsed env parsing, ternary dispatch in computeWheelStep. - perfPane: folded ensureLogDir into once-flag, spread-with-overrides for fastPath/phases instead of full rebuilds. - env: extracted truthy() (used 4×). - virtualHeights: collapsed user/diff/slash height bumps; trail+todos estimate. - useInputHandlers: scrollIdleTimer cleanup on unmount, ?? undefined shorthand. - useMainApp: dropped dead liveTailVisible IIFE and liveProgress indirection. - appLayout, markdown, messageLine, entry: vertical rhythm, dropped narration comments, inlined one-shot vars. - fix: empty catch blocks → /* best-effort */ for no-empty lint.	2026-04-26 20:38:47 -05:00
Brooklyn Nicholson	85e9a23efb	feat(tui): HERMES_TUI_FPS=1 shows live fps counter Adds a corner-overlay FPS readout gated on HERMES_TUI_FPS, fed by ink's onFrame callback (so it's the REAL render rate, not a timer). Displays fps, last-frame duration, and total frame count, colored by threshold (green ≥50, yellow ≥30, red below). Implementation: * lib/fpsStore.ts — nanostore atom updated from a trackFrame() sink. Ring buffer of last 30 frame timestamps; fps = 29/elapsed. trackFrame is undefined when SHOW_FPS is off so ink's onFrame short-circuits at the optional chain. * components/fpsOverlay.tsx — tiny <Text> subscriber; returns null when SHOW_FPS is off (React skips the subtree entirely). * entry.tsx — composes onFrame from logFrameEvent (dev-perf) and trackFrame (fps) so both flags can coexist. When both are off, onFrame is undefined and ink never attaches the handler. * appLayout.tsx — mounts the overlay as a flex-shrink=0 right- aligned Box below the composer, conditional on SHOW_FPS. Usage: HERMES_TUI_FPS=1 hermes --tui # bottom right: " 62.3fps · 0.8ms · #1234" (green/yellow/red) Intended as a user-facing diagnostic during the scroll-perf tuning pass — watch the counter drop while holding PageUp to see where frames go silent, without having to run scripts/profile-tui.py in a side terminal. 126 files post-compile with React Compiler; 352 tests still pass.	2026-04-26 17:20:47 -05:00

Author

SHA1

Message

Date

brooklyn!

6b09df39be

fix(tui): restore macOS copy behavior and theme polish (#17131 )

This PR groups the TUI fixes that restore macOS Terminal usability and clean up the theme/composer regressions:

- copy transcript selections on macOS drag-release so Terminal.app users can copy while mouse tracking is enabled
- copy composer selections on macOS drag-release; composer selection is internal to TextInput and does not use the global Ink selection bus
- keep IDE Cmd+C forwarding setup macOS-only, and make keybinding conflict checks respect simple when-clause overlap/negation
- force truecolor before chalk initializes (unless NO_COLOR / FORCE_COLOR / HERMES_TUI_TRUECOLOR opt-outs apply) so the default banner keeps its gold/amber/bronze gradient in Terminal.app
- move TUI surfaces onto semantic theme tokens and preserve skin prompt symbols as bare tokens with renderer-owned spacing
- render focused placeholders as dim hint text in TTY mode instead of inverse/selected-looking synthetic cursor text

2026-04-28 18:47:14 -05:00

Brooklyn Nicholson

b1c49d5e73

chore(tui): /clean recent perf work — KISS/DRY pass

24 files, -319 LoC. Behaviour preserved, 369/369 tests green.

- hermes-ink caches: shared lruEvict helper for the four parallel LRU
  caches (stringWidth, wrapText, sliceAnsi, lineWidth); touch-on-read
  stays inlined per cache; tightened output.ts skip-slice fast path.
- wheelAccel: trimmed provenance header, collapsed env parsing, ternary
  dispatch in computeWheelStep.
- perfPane: folded ensureLogDir into once-flag, spread-with-overrides
  for fastPath/phases instead of full rebuilds.
- env: extracted truthy() (used 4×).
- virtualHeights: collapsed user/diff/slash height bumps; trail+todos
  estimate.
- useInputHandlers: scrollIdleTimer cleanup on unmount, ?? undefined
  shorthand.
- useMainApp: dropped dead liveTailVisible IIFE and liveProgress
  indirection.
- appLayout, markdown, messageLine, entry: vertical rhythm, dropped
  narration comments, inlined one-shot vars.
- fix: empty catch blocks → /* best-effort */ for no-empty lint.

2026-04-26 20:38:47 -05:00

Brooklyn Nicholson

85e9a23efb

feat(tui): HERMES_TUI_FPS=1 shows live fps counter

Adds a corner-overlay FPS readout gated on HERMES_TUI_FPS, fed by
ink's onFrame callback (so it's the REAL render rate, not a timer).
Displays fps, last-frame duration, and total frame count, colored by
threshold (green ≥50, yellow ≥30, red below).

Implementation:
  * lib/fpsStore.ts — nanostore atom updated from a trackFrame()
    sink.  Ring buffer of last 30 frame timestamps; fps = 29/elapsed.
    trackFrame is undefined when SHOW_FPS is off so ink's onFrame
    short-circuits at the optional chain.
  * components/fpsOverlay.tsx — tiny <Text> subscriber; returns null
    when SHOW_FPS is off (React skips the subtree entirely).
  * entry.tsx — composes onFrame from logFrameEvent (dev-perf) and
    trackFrame (fps) so both flags can coexist.  When both are off,
    onFrame is undefined and ink never attaches the handler.
  * appLayout.tsx — mounts the overlay as a flex-shrink=0 right-
    aligned Box below the composer, conditional on SHOW_FPS.

Usage:
  HERMES_TUI_FPS=1 hermes --tui
  # bottom right: "  62.3fps ·   0.8ms · #1234" (green/yellow/red)

Intended as a user-facing diagnostic during the scroll-perf tuning
pass — watch the counter drop while holding PageUp to see where
frames go silent, without having to run scripts/profile-tui.py in a
side terminal.

126 files post-compile with React Compiler; 352 tests still pass.

2026-04-26 17:20:47 -05:00

3 commits