2 commits

Author	SHA1	Message	Date
Teknium	6b81590c55	test: prune low-value tests suite-wide (wave 1) — 46,820 → 28,106 test functions ... Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).	2026-07-29 13:10:23 -07:00
ud	c126a99fc1	fix(subdirectory_hints): catch RuntimeError from Path.expanduser() ... `pathlib.Path('~user').expanduser()` raises RuntimeError when the tilde-expansion can't resolve the user (e.g. `~500-700` where the LLM meant "approximately 500-700" rather than a path). The hint walker's existing `except (OSError, ValueError):` clauses do not catch RuntimeError, so it escapes through the tool dispatcher and surfaces in the conversation loop as a misleading Error during OpenAI-compatible API call #N: Could not determine home directory. Reproduced across three unrelated models (openai/gpt-5-mini, openai/gpt-5.1-codex, deepseek/deepseek-v4-flash) on terminal-tool commands containing literal tildes in non-path contexts — common in LLM output ("~500 agencies", "~45,000 CVEs", "~80/hr blended rate"). Reproduction (one-liner): >>> from pathlib import Path >>> Path("~500-700").expanduser() RuntimeError: Could not determine home directory. Fix: extend the three `except` clauses in agent/subdirectory_hints.py to also catch RuntimeError: line 138 (_add_path_candidate's outer catch around the Path().expanduser() call) lines 198+202 (_load_hints_for_directory's nested catches around hint_path.relative_to(Path.home())) Tests: tests/agent/test_subdirectory_hints_tilde.py adds three cases covering: tilde-as-approximately in heredoc commands, ~unknown_user paths, and a regression guard that legitimate ~/path expansion still works.	2026-07-01 04:55:15 -07:00