2 commits

Author	SHA1	Message	Date
Michel Belleau	c1c9ab534c	fix(discord): strip RTP padding before DAVE/Opus decode (#11267) ... The Discord voice receive path skipped RFC 3550 §5.1 padding handling, passing padding-contaminated payloads into DAVE E2EE decrypt and Opus decode. Symptoms in live VC sessions: deaf inbound speech, intermittent empty STT results, "corrupted stream" decode errors — especially on the first reply after join. When the P bit is set in the RTP header, the last payload byte holds the count of trailing padding bytes (including itself) that must be removed. Receive pipeline now follows the spec order: 1. RTP header parse 2. NaCl transport decrypt (aead_xchacha20_poly1305_rtpsize) 3. strip encrypted RTP extension data from start 4. strip RTP padding from end if P bit set ← was missing 5. DAVE inner media decrypt 6. Opus decode Drops malformed packets where pad_len is 0 or exceeds payload length. Adds 7 integration tests covering valid padded packets, the X+P combined case, padding under DAVE passthrough, and three malformed-padding paths. Closes #11267 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-04-16 16:50:15 -07:00
0xbyt4	3ea039684e	test(voice): add integration tests with real NaCl crypto and Opus codec ... End-to-end voice channel tests using real crypto (no mocks): NaCl decrypt (5): valid packet, wrong key, bot SSRC, multi-packet, multi-SSRC DAVE passthrough (3): unknown SSRC, Unencrypted error, real error drop Full flow (5): utterance lifecycle, auto-map, pause/resume, corruption, cleanup SPEAKING hook (4): hook installed, map/overwrite, mapped audio processed Auth filtering (3): allowed user, rejected user, empty allowlist Rejoin flow (3): clean state, new SSRC, missing SPEAKING auto-map Multi-guild (2): independent receivers, stop isolation Echo prevention (2): paused audio ignored, resumed audio processed	2026-03-15 05:20:17 -07:00