mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-07 02:51:50 +00:00
feat(kanban): auto-subscribe gateway chat on tool-driven kanban_create (#19718)
Closes #19479. When an orchestrator agent calls kanban_create from a gateway session (e.g. a Telegram user delegating to an orchestrator profile), auto- subscribe the originating (platform, chat, thread, user) to the new task's terminal events. Mirrors the behavior of the /kanban create slash command in gateway/run.py so tool-driven creation is at parity with human-driven creation. Without this, a user who interacts with an orchestrator exclusively via the gateway never receives blocked / completed / gave_up notifications for tasks the orchestrator created on their behalf — silently breaking the gateway-first multi-agent flow the reporter describes. Reads the context-local HERMES_SESSION_* vars via get_session_env() (not os.environ — those are contextvars for asyncio concurrency safety). Falls through cleanly in CLI / cron contexts with no session active (subscribed=False in the response). Best-effort: if the gateway module isn't importable (test rigs stubbing gateway.*), the task still creates, we just skip the subscription. Response gains a 'subscribed' bool so the orchestrator knows whether terminal events will land back in the originating chat or whether it needs to poll / unblock manually. Tests: 4 new in tests/tools/test_kanban_tools.py covering CLI/no-subscribe, telegram/gateway-auto-subscribe, discord-DM/no- thread subscribe, and partial-ctx/no-chat_id no-subscribe. 40/40 kanban tool tests pass.
This commit is contained in:
parent
fdf9343c51
commit
ff3d2773e2
2 changed files with 130 additions and 0 deletions
|
|
@ -610,3 +610,103 @@ def test_orchestrator_complete_any_task_allowed(monkeypatch, tmp_path):
|
||||||
out = kt._handle_complete({"task_id": tid, "summary": "orchestrator close"})
|
out = kt._handle_complete({"task_id": tid, "summary": "orchestrator close"})
|
||||||
d = json.loads(out)
|
d = json.loads(out)
|
||||||
assert d.get("ok") is True and d.get("task_id") == tid
|
assert d.get("ok") is True and d.get("task_id") == tid
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# kanban_create auto-subscribe to gateway notifications (#19479)
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
#
|
||||||
|
# When an orchestrator agent (running under the gateway) calls kanban_create,
|
||||||
|
# the originating (platform, chat, thread) should be auto-subscribed to the
|
||||||
|
# new task's terminal events — matching the /kanban create slash-command
|
||||||
|
# behavior in gateway/run.py. In CLI / cron contexts (no session vars set),
|
||||||
|
# no subscription row is written.
|
||||||
|
|
||||||
|
|
||||||
|
def test_create_no_subscribe_in_cli_context(worker_env):
|
||||||
|
"""Classic CLI: no gateway session vars -> no notify subscription."""
|
||||||
|
from tools import kanban_tools as kt
|
||||||
|
from hermes_cli import kanban_db as kb
|
||||||
|
out = kt._handle_create({"title": "cli task", "assignee": "peer"})
|
||||||
|
d = json.loads(out)
|
||||||
|
assert d.get("ok") is True
|
||||||
|
assert d.get("subscribed") is False
|
||||||
|
conn = kb.connect()
|
||||||
|
try:
|
||||||
|
assert kb.list_notify_subs(conn, d["task_id"]) == []
|
||||||
|
finally:
|
||||||
|
conn.close()
|
||||||
|
|
||||||
|
|
||||||
|
def test_create_auto_subscribes_in_gateway_context(worker_env):
|
||||||
|
"""Gateway session vars set -> auto-subscribe the originating source."""
|
||||||
|
from gateway.session_context import set_session_vars, clear_session_vars
|
||||||
|
from tools import kanban_tools as kt
|
||||||
|
from hermes_cli import kanban_db as kb
|
||||||
|
|
||||||
|
tokens = set_session_vars(
|
||||||
|
platform="telegram",
|
||||||
|
chat_id="1234567",
|
||||||
|
thread_id="42",
|
||||||
|
user_id="u_alice",
|
||||||
|
)
|
||||||
|
try:
|
||||||
|
out = kt._handle_create({"title": "gateway task", "assignee": "peer"})
|
||||||
|
d = json.loads(out)
|
||||||
|
assert d.get("ok") is True
|
||||||
|
assert d.get("subscribed") is True
|
||||||
|
conn = kb.connect()
|
||||||
|
try:
|
||||||
|
subs = kb.list_notify_subs(conn, d["task_id"])
|
||||||
|
finally:
|
||||||
|
conn.close()
|
||||||
|
assert len(subs) == 1
|
||||||
|
assert subs[0]["platform"] == "telegram"
|
||||||
|
assert subs[0]["chat_id"] == "1234567"
|
||||||
|
assert subs[0]["thread_id"] == "42"
|
||||||
|
assert subs[0]["user_id"] == "u_alice"
|
||||||
|
finally:
|
||||||
|
clear_session_vars(tokens)
|
||||||
|
|
||||||
|
|
||||||
|
def test_create_subscribe_without_thread_id(worker_env):
|
||||||
|
"""DM / no-thread platforms subscribe without a thread_id."""
|
||||||
|
from gateway.session_context import set_session_vars, clear_session_vars
|
||||||
|
from tools import kanban_tools as kt
|
||||||
|
from hermes_cli import kanban_db as kb
|
||||||
|
|
||||||
|
tokens = set_session_vars(platform="discord", chat_id="ch_dm_789")
|
||||||
|
try:
|
||||||
|
out = kt._handle_create({"title": "dm task", "assignee": "peer"})
|
||||||
|
d = json.loads(out)
|
||||||
|
assert d.get("subscribed") is True
|
||||||
|
conn = kb.connect()
|
||||||
|
try:
|
||||||
|
subs = kb.list_notify_subs(conn, d["task_id"])
|
||||||
|
finally:
|
||||||
|
conn.close()
|
||||||
|
assert len(subs) == 1
|
||||||
|
assert subs[0]["thread_id"] == ""
|
||||||
|
assert subs[0]["user_id"] is None
|
||||||
|
finally:
|
||||||
|
clear_session_vars(tokens)
|
||||||
|
|
||||||
|
|
||||||
|
def test_create_no_subscribe_when_chat_id_missing(worker_env):
|
||||||
|
"""Partial gateway context (platform but no chat_id) -> no subscription."""
|
||||||
|
from gateway.session_context import set_session_vars, clear_session_vars
|
||||||
|
from tools import kanban_tools as kt
|
||||||
|
from hermes_cli import kanban_db as kb
|
||||||
|
|
||||||
|
tokens = set_session_vars(platform="telegram", chat_id="")
|
||||||
|
try:
|
||||||
|
out = kt._handle_create({"title": "partial ctx", "assignee": "peer"})
|
||||||
|
d = json.loads(out)
|
||||||
|
assert d.get("subscribed") is False
|
||||||
|
conn = kb.connect()
|
||||||
|
try:
|
||||||
|
assert kb.list_notify_subs(conn, d["task_id"]) == []
|
||||||
|
finally:
|
||||||
|
conn.close()
|
||||||
|
finally:
|
||||||
|
clear_session_vars(tokens)
|
||||||
|
|
|
||||||
|
|
@ -380,10 +380,40 @@ def _handle_create(args: dict, **kw) -> str:
|
||||||
skills=skills,
|
skills=skills,
|
||||||
created_by=os.environ.get("HERMES_PROFILE") or "worker",
|
created_by=os.environ.get("HERMES_PROFILE") or "worker",
|
||||||
)
|
)
|
||||||
|
# Auto-subscribe the originating gateway source (if any) to the
|
||||||
|
# new task's terminal events. Mirrors the behavior of the
|
||||||
|
# `/kanban create` slash command in gateway/run.py so that
|
||||||
|
# tool-driven creation (orchestrator agents calling kanban_create)
|
||||||
|
# gets the same blocked/completed/gave_up notifications as human-
|
||||||
|
# driven creation. No-op in CLI / cron contexts where no gateway
|
||||||
|
# session context is active. See issue #19479.
|
||||||
|
subscribed = False
|
||||||
|
try:
|
||||||
|
from gateway.session_context import get_session_env
|
||||||
|
platform = get_session_env("HERMES_SESSION_PLATFORM")
|
||||||
|
chat_id = get_session_env("HERMES_SESSION_CHAT_ID")
|
||||||
|
thread_id = get_session_env("HERMES_SESSION_THREAD_ID") or None
|
||||||
|
user_id = get_session_env("HERMES_SESSION_USER_ID") or None
|
||||||
|
if platform and chat_id:
|
||||||
|
kb.add_notify_sub(
|
||||||
|
conn,
|
||||||
|
task_id=new_tid,
|
||||||
|
platform=platform,
|
||||||
|
chat_id=chat_id,
|
||||||
|
thread_id=thread_id,
|
||||||
|
user_id=user_id,
|
||||||
|
)
|
||||||
|
subscribed = True
|
||||||
|
except Exception:
|
||||||
|
# Subscription is best-effort; don't fail the whole create
|
||||||
|
# if the gateway context module isn't importable (e.g. in
|
||||||
|
# test rigs that stub out gateway.*).
|
||||||
|
logger.debug("kanban_create notify-sub skipped", exc_info=True)
|
||||||
new_task = kb.get_task(conn, new_tid)
|
new_task = kb.get_task(conn, new_tid)
|
||||||
return _ok(
|
return _ok(
|
||||||
task_id=new_tid,
|
task_id=new_tid,
|
||||||
status=new_task.status if new_task else None,
|
status=new_task.status if new_task else None,
|
||||||
|
subscribed=subscribed,
|
||||||
)
|
)
|
||||||
finally:
|
finally:
|
||||||
conn.close()
|
conn.close()
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue