mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-05-08 03:01:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Merge pull request #15749 from Zjianru/fix/copy-reasoning-content-ordering-and-cross-provider-isolation

Browse source 
fix(agent): ordering fix in _copy_reasoning_content_for_api — cross-provider reasoning isolation
This commit is contained in:
brooklyn! 2026-04-25 17:21:49 -05:00 • committed by GitHub
commit f93d4624bf
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 27 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

39
run_agent.py
View file

@ -7754,25 +7754,40 @@ class AIAgent:
if source_msg.get("role") != "assistant": if source_msg.get("role") != "assistant":
return return
explicit_reasoning = source_msg.get("reasoning_content") # 1. Explicit reasoning_content already set — preserve it verbatim
if isinstance(explicit_reasoning, str): # (includes DeepSeek/Kimi's own empty-string placeholder written at
api_msg["reasoning_content"] = explicit_reasoning # creation time, and any valid reasoning content from the same provider).
existing = source_msg.get("reasoning_content")
if isinstance(existing, str):
api_msg["reasoning_content"] = existing
return return
# 2. DeepSeek / Kimi thinking mode: tool-call turns that lack
# reasoning_content are "poisoned history" — a prior provider (MiniMax,
# etc.) left them empty. DeepSeek returns HTTP 400 if reasoning_content
# is absent on replay; inject "" to satisfy the provider's requirement
# without forwarding any cross-provider reasoning content.
needs_empty_reasoning = (
source_msg.get("tool_calls")
and (
self._needs_kimi_tool_reasoning()
or self._needs_deepseek_tool_reasoning()
)
)
if needs_empty_reasoning:
api_msg["reasoning_content"] = ""
return
# 3. Healthy session: promote 'reasoning' field to 'reasoning_content'
# for providers that use the internal 'reasoning' key.
normalized_reasoning = source_msg.get("reasoning") normalized_reasoning = source_msg.get("reasoning")
if isinstance(normalized_reasoning, str) and normalized_reasoning: if isinstance(normalized_reasoning, str) and normalized_reasoning:
api_msg["reasoning_content"] = normalized_reasoning api_msg["reasoning_content"] = normalized_reasoning
return return
# Providers that require an echoed reasoning_content on every # 4. reasoning_content was present but not a string (e.g. None after
# assistant tool-call turn. Detection logic lives in the per-provider # context compaction). Don't pass null to the API.
# helpers so both the creation path (_build_assistant_message) and api_msg.pop("reasoning_content", None)
# this replay path stay in sync.
if source_msg.get("tool_calls") and (
self._needs_kimi_tool_reasoning()
or self._needs_deepseek_tool_reasoning()
):
api_msg["reasoning_content"] = ""
@staticmethod @staticmethod
def _sanitize_tool_calls_for_strict_api(api_msg: dict) -> dict: def _sanitize_tool_calls_for_strict_api(api_msg: dict) -> dict: