mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-04-26 01:01:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

feat: add docker_volumes config for custom volume mounts

Browse source
This commit is contained in:
Gesina Sands 2026-02-28 07:12:48 +10:00
parent e3cb957a10
commit f7677ed275
4 changed files with 44 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

26
tools/environments/docker.py
View file

@ -51,6 +51,7 @@ class DockerEnvironment(BaseEnvironment):
disk: int = 0,
persistent_filesystem: bool = False,
task_id: str = "default",
volumes: list = None,
network: bool = True,
):
super().__init__(cwd=cwd, timeout=timeout)
@ -58,6 +59,11 @@ class DockerEnvironment(BaseEnvironment):
self._persistent = persistent_filesystem
self._task_id = task_id
self._container_id: Optional[str] = None
logger.info(f"DockerEnvironment volumes: {volumes}")
# Ensure volumes is a list (config.yaml could be malformed)
if volumes is not None and not isinstance(volumes, list):
logger.warning(f"docker_volumes config is not a list: {volumes!r}")
volumes = []
from minisweagent.environments.docker import DockerEnvironment as _Docker
@ -99,10 +105,26 @@ class DockerEnvironment(BaseEnvironment):
# All containers get full security hardening (read-only root + writable
# mounts for the workspace). Persistence uses Docker volumes, not
# filesystem layer commits, so --read-only is always safe.
all_run_args = list(_SECURITY_ARGS) + writable_args + resource_args
# User-configured volume mounts (from config.yaml docker_volumes)
volume_args = []
for vol in (volumes or []):
if not isinstance(vol, str):
logger.warning(f"Docker volume entry is not a string: {vol!r}")
continue
vol = vol.strip()
if not vol:
continue
if ":" in vol:
volume_args.extend(["-v", vol])
else:
logger.warning(f"Docker volume '{vol}' missing colon, skipping")
logger.info(f"Docker volume_args: {volume_args}")
all_run_args = list(_SECURITY_ARGS) + writable_args + resource_args + volume_args
logger.info(f"Docker run_args: {all_run_args}")
self._inner = _Docker(
image=effective_image, cwd=cwd, timeout=timeout,
image=image, cwd=cwd, timeout=timeout,
run_args=all_run_args,
)
self._container_id = self._inner.container_id