mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-04-27 01:11:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

feat(cli): use user's login shell for command execution to ensure environment consistency

Browse source
This commit is contained in:
teknium1 2026-02-27 15:10:27 -08:00
parent 4f3cb98e5e
commit f14ff3e041
2 changed files with 16 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tools/process_registry.py
View file

@ -32,6 +32,7 @@ Usage:
import json
import logging
import os
import shutil
import signal
import subprocess
import threading
@ -127,8 +128,9 @@ class ProcessRegistry:
# Try PTY mode for interactive CLI tools
try:
import ptyprocess
user_shell = os.environ.get("SHELL") or shutil.which("bash") or "/bin/bash"
pty_proc = ptyprocess.PtyProcess.spawn(
["bash", "-c", command],
[user_shell, "-lc", command],
cwd=session.cwd,
env=os.environ | (env_vars or {}),
dimensions=(30, 120),
@ -160,9 +162,11 @@ class ProcessRegistry:
logger.warning("PTY spawn failed (%s), falling back to pipe mode", e)
# Standard Popen path (non-PTY or PTY fallback)
# Use the user's login shell for consistency with LocalEnvironment --
# ensures rc files are sourced and user tools are available.
user_shell = os.environ.get("SHELL") or shutil.which("bash") or "/bin/bash"
proc = subprocess.Popen(
command,
shell=True,
[user_shell, "-lc", command],
text=True,
cwd=session.cwd,
env=os.environ | (env_vars or {}),