mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-14 14:12:44 +00:00
feat(cli): make hermes serve a real headless backend
`serve` (added in #54568) reused cmd_dashboard wholesale, so it still behaved like a dashboard: it ran a full vite build every launch, mounted and served the SPA whenever a stray web_dist/ existed, printed "Hermes Web UI →", and announced HERMES_DASHBOARD_READY. It's the headless JSON-RPC/WS backend the desktop app and remote clients run — pure socket clients that never load the browser SPA. Mark serve with headless_backend=True (resolved once in cmd_dashboard) and: - skip _build_web_ui entirely on the serve path - export HERMES_SERVE_HEADLESS=1 so mount_spa() disables the SPA even when a dist is present — only the JSON-RPC/WS/API surface is reachable - announce the bind ("Hermes backend listening on host:port") instead of a browser/auth-gated URL - print a neutral HERMES_BACKEND_READY sentinel; dashboard keeps the legacy one and the desktop port-discovery regex matches either - preserve serve across the named-profile re-exec so it can't rebuild as dashboard `hermes dashboard` is unchanged (builds + serves the browser UI). Backward compatible: old apps only ever spawn dashboard (legacy token + UI intact) and never invoke serve; the ready-file side channel is name-agnostic. The one behavior change is that a remote `hermes serve` no longer serves the browser dashboard as a side effect — that's `hermes dashboard`'s job. Tests: serve headless_backend contract, SPA-disabled-with-dist, the HERMES_BACKEND_READY desktop parse (17/17 node), and the existing serve/dashboard/web_server suites. AGENTS.md documents the behavior.
This commit is contained in:
parent
812236bff8
commit
f0f8c84d1b
8 changed files with 93 additions and 16 deletions
|
|
@ -2509,6 +2509,27 @@ class TestWebServerEndpoints:
|
|||
|
||||
assert seen_encodings == {"index": "utf-8", "css": "utf-8"}
|
||||
|
||||
def test_headless_serve_disables_spa_even_with_a_dist(self, monkeypatch, tmp_path):
|
||||
"""`hermes serve` (HERMES_SERVE_HEADLESS) must NOT serve the SPA even
|
||||
when a built dist is present — only the API/WS surface is reachable."""
|
||||
from fastapi import FastAPI
|
||||
from starlette.testclient import TestClient
|
||||
import hermes_cli.web_server as ws
|
||||
|
||||
dist = tmp_path / "web_dist"
|
||||
(dist / "assets").mkdir(parents=True)
|
||||
(dist / "index.html").write_text("<html><body>UI</body></html>", encoding="utf-8")
|
||||
|
||||
monkeypatch.setattr(ws, "WEB_DIST", dist)
|
||||
monkeypatch.setenv("HERMES_SERVE_HEADLESS", "1")
|
||||
app_ = FastAPI()
|
||||
ws.mount_spa(app_)
|
||||
|
||||
for route in ("/", "/chat"):
|
||||
resp = TestClient(app_).get(route)
|
||||
assert resp.status_code == 404
|
||||
assert "web UI disabled" in resp.json()["error"]
|
||||
|
||||
def test_set_model_main_nous_applies_gateway_defaults(self, monkeypatch):
|
||||
"""Switching the main provider to Nous calls apply_nous_managed_defaults
|
||||
(mirroring the CLI's post-model-selection Tool Gateway routing) and
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue