From f0a8e45cdc728c97b1e336df5ec6b9467bf23694 Mon Sep 17 00:00:00 2001 From: Teknium <127238744+teknium1@users.noreply.github.com> Date: Tue, 14 Jul 2026 15:25:24 -0700 Subject: [PATCH] chore(mcp): drop stale input_schema comment on add_tool call MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Review nit from verification: the comment claimed newer FastMCP accepts a JSON schema kwarg — the installed SDK's add_tool has no such parameter; the synthesized __signature__ is what drives schema generation on both paths. --- agent/transports/hermes_tools_mcp_server.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/agent/transports/hermes_tools_mcp_server.py b/agent/transports/hermes_tools_mcp_server.py index 8de3a5f1fa85..7fc23cf506d9 100644 --- a/agent/transports/hermes_tools_mcp_server.py +++ b/agent/transports/hermes_tools_mcp_server.py @@ -227,12 +227,11 @@ def _build_server() -> Any: _make_handler(name, params_schema), name=name, description=description, - # FastMCP accepts JSON schema directly via the - # input_schema parameter on newer versions; older - # versions use parameters_schema. Try both for compat. ) except TypeError: - # Older mcp SDK signature — fall back to decorator-style. + # Older mcp SDK signature — fall back to decorator-style. The + # synthesized __signature__ on the handler still drives schema + # generation there. handler = _make_handler(name, params_schema) handler = mcp.tool(name=name, description=description)(handler)