mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-24 10:52:21 +00:00
fix(desktop): log session.title RPC failure before REST fallback
The RPC-rename fallback swallowed all errors silently. Narrow it to log the swallowed error via console.warn so a genuine session.title RPC failure (which then surfaces a REST 404 for the runtime id) is diagnosable instead of invisible. Behavior is unchanged: REST fallback still runs for any session with a persisted row.
This commit is contained in:
parent
7f43378931
commit
ed81f0b633
1 changed files with 5 additions and 2 deletions
|
|
@ -59,9 +59,12 @@ export async function renameSessionPreferringRpc(
|
|||
})
|
||||
|
||||
return { title: result?.title ?? title }
|
||||
} catch {
|
||||
} catch (err) {
|
||||
// Fall through to REST — e.g. the socket is mid-reconnect. REST still
|
||||
// works for any session that already has a persisted row.
|
||||
// works for any session that already has a persisted row. Log so a
|
||||
// genuine RPC-side failure (which then surfaces a REST 404 for the
|
||||
// runtime id) is at least diagnosable instead of silently swallowed.
|
||||
console.warn('session.title RPC rename failed; falling back to REST', err)
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue