mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-07 08:02:23 +00:00
fix(kanban): preserve original exception when write_txn rollback fails
When code inside a write_txn block raises an OperationalError that SQLite has already auto-rolled-back (typical for disk I/O error, database is locked, and database disk image is malformed), the explicit ROLLBACK in write_txn.__exit__ itself raises cannot rollback - no transaction is active and the secondary exception replaces the original in the traceback. Operators see a misleading error and lose the diagnostic information they need. Swallow the rollback-time OperationalError so the caller always sees the original cause. Confirmed reproducer: tests/hermes_cli/test_kanban_db.py:: test_write_txn_preserves_original_exception_when_rollback_fails
This commit is contained in:
parent
5c49cd0ed0
commit
e83252dc46
2 changed files with 68 additions and 1 deletions
|
|
@ -1481,12 +1481,22 @@ def write_txn(conn: sqlite3.Connection):
|
|||
Use for any multi-statement write (creating a task + link, claiming a
|
||||
task + recording an event, etc.). A claim CAS inside this context is
|
||||
atomic -- at most one concurrent writer can succeed.
|
||||
|
||||
The explicit ROLLBACK on exception is wrapped in try/except so that
|
||||
a SQLite auto-rollback (which leaves no active transaction) does not
|
||||
shadow the original exception with a spurious rollback error.
|
||||
"""
|
||||
conn.execute("BEGIN IMMEDIATE")
|
||||
try:
|
||||
yield conn
|
||||
except Exception:
|
||||
conn.execute("ROLLBACK")
|
||||
try:
|
||||
conn.execute("ROLLBACK")
|
||||
except sqlite3.OperationalError:
|
||||
# SQLite has already auto-rolled-back the transaction (typical
|
||||
# under EIO, lock contention, or corruption). Nothing to undo;
|
||||
# do not let this secondary failure shadow the real one.
|
||||
pass
|
||||
raise
|
||||
else:
|
||||
conn.execute("COMMIT")
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue