mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-05-08 03:01:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

fix(delegate): expand composite toolsets before intersection in delegate_task

Browse source 
When the parent agent uses a composite toolset like hermes-cli, calling
delegate_task with individual toolsets (e.g. web, terminal) resulted in
zero tools because the name-based intersection failed: 'web' != 'hermes-cli'.

Add _expand_parent_toolsets() which collects all tool names from parent
toolsets, then recognises any individual toolset whose tools are a subset
of the parent's available tools. This allows delegate_task(toolsets=['web'])
to work correctly when the parent has hermes-cli enabled.

Fixes #19447
This commit is contained in:
luyao618 2026-05-04 09:42:13 +08:00 • committed by Teknium
parent a78e622dfe
commit e795b7e3ab
2 changed files with 82 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

38
tools/delegate_tool.py
View file

@ -462,6 +462,37 @@ def _is_mcp_toolset_name(name: str) -> bool:
return bool(target and str(target).startswith("mcp-"))
def _expand_parent_toolsets(parent_toolsets: set) -> set:
"""Expand composite toolsets so individual toolset names are recognized.
When a parent uses a composite toolset like ``hermes-cli`` (which bundles
all core tools), the child may request individual toolsets such as ``web``
or ``terminal``. A simple name-based intersection would reject them
because ``"web" != "hermes-cli"``.
This helper collects the tool names from each parent toolset, then adds
the names of any individual toolsets whose tools are a *subset* of the
parent's available tools. The original parent toolset names are preserved.
"""
parent_tool_names: set = set()
for ts_name in parent_toolsets:
ts_def = TOOLSETS.get(ts_name)
if ts_def:
parent_tool_names.update(ts_def.get("tools", []))
if not parent_tool_names:
return set(parent_toolsets)
expanded = set(parent_toolsets)
for ts_name, ts_def in TOOLSETS.items():
if ts_name in expanded:
continue
ts_tools = ts_def.get("tools", [])
if ts_tools and set(ts_tools).issubset(parent_tool_names):
expanded.add(ts_name)
return expanded
def _preserve_parent_mcp_toolsets(
child_toolsets: List[str], parent_toolsets: set[str]
) -> List[str]:
@ -907,8 +938,11 @@ def _build_child_agent(
parent_toolsets = set(DEFAULT_TOOLSETS)
if toolsets:
# Intersect with parent — subagent must not gain tools the parent lacks
child_toolsets = [t for t in toolsets if t in parent_toolsets]
# Intersect with parent — subagent must not gain tools the parent lacks.
# Expand composite toolsets (e.g. hermes-cli) so that individual
# toolset names (e.g. web, terminal) are recognised during intersection.
expanded_parent = _expand_parent_toolsets(parent_toolsets)
child_toolsets = [t for t in toolsets if t in expanded_parent]
if _get_inherit_mcp_toolsets():
child_toolsets = _preserve_parent_mcp_toolsets(
child_toolsets, parent_toolsets