mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-07-29 18:46:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

fix: update signal guard test for _install_signal refactor (#72677)

Browse source 
The change-detector test asserted 'hasattr(signal, "SIGPIPE")' in source.
PR #72677 replaced inline hasattr+signal.signal with _install_signal()
which does the same guard via getattr internally. Update the test to
accept either form.
This commit is contained in:
kshitijk4poor 2026-07-27 23:28:55 +05:00 • committed by kshitij
parent 8b11249755
commit e643f2e910
1 changed files with 15 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

24
tests/tools/test_windows_native_support.py
View file

@ -666,15 +666,21 @@ class TestTuiGatewayEntrySignalGuards:
def test_source_guards_each_signal_installation(self):
root = Path(__file__).resolve().parents[2]
source = (root / "tui_gateway" / "entry.py").read_text(encoding="utf-8")
# Every signal.signal(...) at module scope must be preceded by a
# hasattr check. We look at the text: no bare "signal.signal("
# call should appear outside a function body without a guard.
# Simpler heuristic: all SIGPIPE / SIGHUP references outside the
# dict-building loop must be wrapped in hasattr.
assert 'hasattr(signal, "SIGPIPE")' in source
assert 'hasattr(signal, "SIGHUP")' in source
assert 'hasattr(signal, "SIGTERM")' in source
assert 'hasattr(signal, "SIGINT")' in source
# Every signal installation at module scope must be guarded against
# missing signals (Windows: SIGPIPE/SIGHUP absent). Originally this
# was ``hasattr(signal, "SIGPIPE")`` inline; PR #72677 refactored to
# ``_install_signal("SIGPIPE", ...)`` which does the same guard via
# ``getattr(signal, signame, None)`` internally. Either form is
# acceptable — what matters is no bare ``signal.signal(SIGPIPE)``
# at module scope without a guard.
for sig_name in ("SIGPIPE", "SIGHUP", "SIGTERM", "SIGINT"):
assert (
f'hasattr(signal, "{sig_name}")' in source
or f'_install_signal("{sig_name}"' in source
), (
f"signal {sig_name} must be installed via a guarded path "
f"(hasattr or _install_signal), not bare signal.signal()"
)
def test_module_imports_cleanly(self):
"""Importing the module must not raise — verifies the guards work."""