mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-05-07 02:51:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

fix(tests): resolve remaining CI failures — commit_memory_session, already_sent, timezone leak, session env (#10785)

Browse source 
Fixes 12 CI test failures:

1. test_cli_new_session (4): _FakeAgent missing commit_memory_session
   attribute added in the memory provider refactoring. Added MagicMock.

2. test_run_progress_topics (1): already_sent detection only checked
   stream consumer flags, missing the response_previewed path from
   interim_assistant_callback. Restructured guard to check both paths.

3. test_timezone (1): HERMES_TIMEZONE leaked into child processes via
   _SAFE_ENV_PREFIXES matching HERMES_*. The code correctly converts
   it to TZ but didn't remove the original. Added child_env.pop().

4. test_session_env (1): contextvars baseline captured from a different
   context couldn't be restored after clear. Changed assertion to verify
   the test's value was removed rather than comparing to a fragile baseline.

5. test_discord_slash_commands (5): already fixed on current main.
This commit is contained in:
Teknium 2026-04-16 02:26:14 -07:00 • committed by GitHub
parent 0c1217d01e
commit e4cd62d07d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 16 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/gateway/test_session_env.py
View file

@ -209,11 +209,13 @@ def test_set_session_env_includes_session_key():
# Capture baseline value before setting (may be non-empty from another
# test in the same pytest-xdist worker sharing the context).
baseline = get_session_env("HERMES_SESSION_KEY")
tokens = runner._set_session_env(context)
assert get_session_env("HERMES_SESSION_KEY") == "tg:-1001:17585"
runner._clear_session_env(tokens)
assert get_session_env("HERMES_SESSION_KEY") == baseline
# After clearing, the session key must not retain the value we just set.
# The exact post-clear value depends on context propagation from other
# tests, so only check that our value was removed, not what replaced it.
assert get_session_env("HERMES_SESSION_KEY") != "tg:-1001:17585"
def test_session_key_no_race_condition_with_contextvars(monkeypatch):