mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-05-05 02:31:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix: harden clawhub skill search exact matches

Browse source
This commit is contained in:
teknium1 2026-03-14 22:31:09 -07:00
parent 15bf0b4af2
commit df9020dfa3
2 changed files with 243 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

142
tests/tools/test_skills_hub_clawhub.py
View file

@ -24,19 +24,26 @@ class TestClawHubSource(unittest.TestCase):
@patch("tools.skills_hub._read_index_cache", return_value=None)
@patch("tools.skills_hub.httpx.get")
def test_search_uses_new_endpoint_and_parses_items(self, mock_get, _mock_read_cache, _mock_write_cache):
mock_get.return_value = _MockResponse(
status_code=200,
json_data={
"items": [
{
"slug": "caldav-calendar",
"displayName": "CalDAV Calendar",
"summary": "Calendar integration",
"tags": ["calendar", "productivity"],
}
]
},
)
def side_effect(url, *args, **kwargs):
if url.endswith("/skills"):
return _MockResponse(
status_code=200,
json_data={
"items": [
{
"slug": "caldav-calendar",
"displayName": "CalDAV Calendar",
"summary": "Calendar integration",
"tags": ["calendar", "productivity"],
}
]
},
)
if url.endswith("/skills/caldav"):
return _MockResponse(status_code=404, json_data={})
return _MockResponse(status_code=404, json_data={})
mock_get.side_effect = side_effect
results = self.src.search("caldav", limit=5)
@ -45,11 +52,93 @@ class TestClawHubSource(unittest.TestCase):
self.assertEqual(results[0].name, "CalDAV Calendar")
self.assertEqual(results[0].description, "Calendar integration")
mock_get.assert_called_once()
args, kwargs = mock_get.call_args
first_call = mock_get.call_args_list[0]
args, kwargs = first_call
self.assertTrue(args[0].endswith("/skills"))
self.assertEqual(kwargs["params"], {"search": "caldav", "limit": 5})
@patch("tools.skills_hub._write_index_cache")
@patch("tools.skills_hub._read_index_cache", return_value=None)
@patch("tools.skills_hub.httpx.get")
def test_search_falls_back_to_exact_slug_when_search_results_are_irrelevant(
self, mock_get, _mock_read_cache, _mock_write_cache
):
def side_effect(url, *args, **kwargs):
if url.endswith("/skills"):
return _MockResponse(
status_code=200,
json_data={
"items": [
{
"slug": "apple-music-dj",
"displayName": "Apple Music DJ",
"summary": "Unrelated result",
}
]
},
)
if url.endswith("/skills/self-improving-agent"):
return _MockResponse(
status_code=200,
json_data={
"skill": {
"slug": "self-improving-agent",
"displayName": "self-improving-agent",
"summary": "Captures learnings and errors for continuous improvement.",
"tags": {"latest": "3.0.2", "automation": "3.0.2"},
},
"latestVersion": {"version": "3.0.2"},
},
)
return _MockResponse(status_code=404, json_data={})
mock_get.side_effect = side_effect
results = self.src.search("self-improving-agent", limit=5)
self.assertEqual(len(results), 1)
self.assertEqual(results[0].identifier, "self-improving-agent")
self.assertEqual(results[0].name, "self-improving-agent")
self.assertIn("continuous improvement", results[0].description)
@patch("tools.skills_hub.httpx.get")
@patch(
"tools.skills_hub._read_index_cache",
return_value=[
{
"name": "Apple Music DJ",
"description": "Unrelated cached result",
"source": "clawhub",
"identifier": "apple-music-dj",
"trust_level": "community",
"repo": None,
"path": None,
"tags": [],
"extra": {},
}
],
)
def test_search_repairs_poisoned_cache_with_exact_slug_lookup(self, _mock_read_cache, mock_get):
mock_get.return_value = _MockResponse(
status_code=200,
json_data={
"skill": {
"slug": "self-improving-agent",
"displayName": "self-improving-agent",
"summary": "Captures learnings and errors for continuous improvement.",
"tags": {"latest": "3.0.2", "automation": "3.0.2"},
},
"latestVersion": {"version": "3.0.2"},
},
)
results = self.src.search("self-improving-agent", limit=5)
self.assertEqual(len(results), 1)
self.assertEqual(results[0].identifier, "self-improving-agent")
mock_get.assert_called_once()
self.assertTrue(mock_get.call_args.args[0].endswith("/skills/self-improving-agent"))
@patch("tools.skills_hub.httpx.get")
def test_inspect_maps_display_name_and_summary(self, mock_get):
mock_get.return_value = _MockResponse(
@ -69,6 +158,29 @@ class TestClawHubSource(unittest.TestCase):
self.assertEqual(meta.description, "Calendar integration")
self.assertEqual(meta.identifier, "caldav-calendar")
@patch("tools.skills_hub.httpx.get")
def test_inspect_handles_nested_skill_payload(self, mock_get):
mock_get.return_value = _MockResponse(
status_code=200,
json_data={
"skill": {
"slug": "self-improving-agent",
"displayName": "self-improving-agent",
"summary": "Captures learnings and errors for continuous improvement.",
"tags": {"latest": "3.0.2", "automation": "3.0.2"},
},
"latestVersion": {"version": "3.0.2"},
},
)
meta = self.src.inspect("self-improving-agent")
self.assertIsNotNone(meta)
self.assertEqual(meta.name, "self-improving-agent")
self.assertIn("continuous improvement", meta.description)
self.assertEqual(meta.identifier, "self-improving-agent")
self.assertEqual(meta.tags, ["automation"])
@patch("tools.skills_hub.httpx.get")
def test_fetch_resolves_latest_version_and_downloads_raw_files(self, mock_get):
def side_effect(url, *args, **kwargs):