mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-13 03:52:00 +00:00
feat(kanban): hallucination gate + recovery UX for worker-created-card claims (#20232)
Workers completing a kanban task can now claim the ids of cards they created via an optional ``created_cards`` field on ``kanban_complete``. The kernel verifies each id exists and was created by the completing worker's profile; any phantom id blocks the completion with a ``HallucinatedCardsError`` and records a ``completion_blocked_hallucination`` event on the task so the rejected attempt is auditable. Successful completions also get a non-blocking prose-scan pass over their ``summary`` + ``result`` that emits a ``suspected_hallucinated_references`` event for any ``t_<hex>`` reference that doesn't resolve. Closes #20017. Recovery UX (kernel + CLI + dashboard) -------------------------------------- A structural gate alone isn't enough — operators also need to see and act on stuck workers, especially when a profile's model is the root cause. This PR ships the full loop: * ``kanban_db.reclaim_task(task_id)`` — operator-driven reclaim that releases an active worker claim immediately (unlike ``release_stale_claims`` which only acts after claim_expires has passed). Emits a ``reclaimed`` event with ``manual: True`` payload. * ``kanban_db.reassign_task(task_id, profile, reclaim_first=...)`` — switch a task to a different profile, optionally reclaiming a stuck running worker in the same call. * ``hermes kanban reclaim <id> [--reason ...]`` and ``hermes kanban reassign <id> <profile> [--reclaim] [--reason ...]`` CLI subcommands wired through to the same helpers. * ``POST /api/plugins/kanban/tasks/{id}/reclaim`` and ``POST /api/plugins/kanban/tasks/{id}/reassign`` endpoints on the dashboard plugin. Dashboard surfacing ------------------- * ⚠ **warning badge** on cards with active hallucination events. * **attention strip** at the top of the board listing all flagged tasks; dismissible per session. * **events callout** in the task drawer — hallucination events render with a red left border, amber icon, and phantom ids as styled chips. * **recovery section** in the task drawer with three actions: Reclaim, Reassign (with profile picker + reclaim-first checkbox), and a copy-to-clipboard hint for ``hermes -p <profile> model`` since profile config lives on disk and can't be edited from the browser. Auto-opens when the task has warnings, collapsed otherwise. Keyed by task id so state doesn't leak between drawers. Active-vs-stale rule: warnings clear when a clean ``completed`` or ``edited`` event supersedes the hallucination, so recovery is never permanently stigmatising — the audit events persist for debugging but the badge goes away once the worker succeeds. Skill updates ------------- * ``skills/devops/kanban-worker/SKILL.md`` documents the ``created_cards`` contract with good/bad examples. * ``skills/devops/kanban-orchestrator/SKILL.md`` gains a "Recovering stuck workers" section with the three actions and when to use each. Tests ----- * Kernel gate: verified-cards manifest, phantom rejection + audit event, cross-worker rejection, prose scan positive + negative. * Recovery helpers: reclaim on running task, reclaim on non-running returns False, reassign refuses running without reclaim_first, reassign with reclaim_first succeeds on running. * API endpoints: warnings field present on /board and /tasks/:id, warnings cleared after clean completion, reclaim 200 + 409 paths, reassign 200 + 409 + reclaim_first paths. * CLI smoke: reclaim + reassign subcommands. Live-verified end-to-end on a dashboard with seeded scenarios: attention strip renders, badges land on the right cards, drawer callout shows phantom chips, Reclaim on a running task flips status to ready + emits manual reclaimed event + refreshes the drawer, Reassign swaps the assignee and triggers board refresh. 359/359 kanban-suite tests pass (test_kanban_{db,cli,boards,core_functionality} + dashboard + tools).
This commit is contained in:
Teknium
GitHub
parent
7de3c86c5a
commit
de9238d37e
11 changed files with 1791 additions and 17 deletions
253
plugins/kanban/dashboard/dist/style.css
vendored
253
plugins/kanban/dashboard/dist/style.css
vendored
|
|
@ -847,3 +847,256 @@
|
|||
gap: 0.5rem;
|
||||
margin-top: 1rem;
|
||||
}
|
||||
|
||||
/* ---------------------------------------------------------------------- */
|
||||
/* Hallucination warnings: per-card badge, events callout, attention */
|
||||
/* strip, recovery popover. Orange/red palette but muted so the board */
|
||||
/* doesn't scream on every render. */
|
||||
/* ---------------------------------------------------------------------- */
|
||||
.hermes-kanban-warning-badge {
|
||||
display: inline-flex;
|
||||
align-items: center;
|
||||
justify-content: center;
|
||||
font-size: 0.75rem;
|
||||
color: #ff9e3b;
|
||||
margin-left: 0.25rem;
|
||||
cursor: help;
|
||||
}
|
||||
|
||||
/* Attention strip — collapsed state is a thin bar. */
|
||||
.hermes-kanban-attention {
|
||||
border: 1px solid rgba(255, 158, 59, 0.35);
|
||||
background: rgba(255, 158, 59, 0.06);
|
||||
border-radius: 0.5rem;
|
||||
overflow: hidden;
|
||||
}
|
||||
.hermes-kanban-attention-bar {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: 0.5rem;
|
||||
padding: 0.4rem 0.75rem;
|
||||
font-size: 0.8125rem;
|
||||
}
|
||||
.hermes-kanban-attention-icon { color: #ff9e3b; font-size: 1rem; }
|
||||
.hermes-kanban-attention-text { flex: 1; }
|
||||
.hermes-kanban-attention-toggle,
|
||||
.hermes-kanban-attention-dismiss,
|
||||
.hermes-kanban-attention-row-btn {
|
||||
background: transparent;
|
||||
border: 1px solid rgba(120, 120, 140, 0.3);
|
||||
border-radius: 0.3rem;
|
||||
padding: 0.15rem 0.55rem;
|
||||
font-size: 0.75rem;
|
||||
color: inherit;
|
||||
cursor: pointer;
|
||||
}
|
||||
.hermes-kanban-attention-toggle:hover,
|
||||
.hermes-kanban-attention-dismiss:hover,
|
||||
.hermes-kanban-attention-row-btn:hover {
|
||||
background: rgba(255, 158, 59, 0.12);
|
||||
}
|
||||
.hermes-kanban-attention-list {
|
||||
border-top: 1px solid rgba(255, 158, 59, 0.2);
|
||||
padding: 0.25rem 0;
|
||||
}
|
||||
.hermes-kanban-attention-row {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: 0.5rem;
|
||||
padding: 0.3rem 0.75rem;
|
||||
font-size: 0.8125rem;
|
||||
}
|
||||
.hermes-kanban-attention-row:hover {
|
||||
background: rgba(255, 158, 59, 0.08);
|
||||
}
|
||||
.hermes-kanban-attention-row-id {
|
||||
font-family: ui-monospace, SFMono-Regular, monospace;
|
||||
font-size: 0.75rem;
|
||||
color: var(--color-muted-foreground, #888);
|
||||
min-width: 7rem;
|
||||
}
|
||||
.hermes-kanban-attention-row-title {
|
||||
flex: 1;
|
||||
white-space: nowrap;
|
||||
overflow: hidden;
|
||||
text-overflow: ellipsis;
|
||||
}
|
||||
.hermes-kanban-attention-row-meta {
|
||||
font-size: 0.75rem;
|
||||
color: var(--color-muted-foreground, #888);
|
||||
}
|
||||
|
||||
/* Events tab — callout style for hallucination events. */
|
||||
.hermes-kanban-event--hallucination {
|
||||
border-left: 3px solid #ff6b6b;
|
||||
background: rgba(255, 107, 107, 0.08);
|
||||
padding: 0.5rem 0.65rem;
|
||||
border-radius: 0.35rem;
|
||||
margin: 0.25rem 0;
|
||||
}
|
||||
.hermes-kanban-event-header,
|
||||
.hermes-kanban-event-header-plain {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: 0.5rem;
|
||||
}
|
||||
.hermes-kanban-event-warning-icon { color: #ff6b6b; font-size: 1rem; }
|
||||
.hermes-kanban-event-warning-label {
|
||||
color: #ff6b6b;
|
||||
font-weight: 600;
|
||||
font-size: 0.8125rem;
|
||||
}
|
||||
.hermes-kanban-event-phantom-row {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: 0.4rem;
|
||||
flex-wrap: wrap;
|
||||
margin-top: 0.3rem;
|
||||
padding-left: 1.35rem;
|
||||
}
|
||||
.hermes-kanban-event-phantom-label {
|
||||
font-size: 0.75rem;
|
||||
color: var(--color-muted-foreground, #999);
|
||||
}
|
||||
.hermes-kanban-event-phantom-chip {
|
||||
font-family: ui-monospace, SFMono-Regular, monospace;
|
||||
font-size: 0.75rem;
|
||||
padding: 0.1rem 0.4rem;
|
||||
background: rgba(255, 107, 107, 0.15);
|
||||
border: 1px solid rgba(255, 107, 107, 0.3);
|
||||
border-radius: 0.3rem;
|
||||
}
|
||||
|
||||
/* Recovery section header — amber accent when the task has warnings. */
|
||||
.hermes-kanban-section-head-warning { color: #ff9e3b; }
|
||||
.hermes-kanban-section-head-row {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
justify-content: space-between;
|
||||
gap: 0.5rem;
|
||||
}
|
||||
.hermes-kanban-section-toggle {
|
||||
background: transparent;
|
||||
border: 1px solid rgba(120, 120, 140, 0.3);
|
||||
border-radius: 0.3rem;
|
||||
padding: 0.15rem 0.55rem;
|
||||
font-size: 0.75rem;
|
||||
color: inherit;
|
||||
cursor: pointer;
|
||||
}
|
||||
|
||||
/* Recovery popover body. */
|
||||
.hermes-kanban-recovery {
|
||||
border: 1px solid rgba(120, 120, 140, 0.25);
|
||||
background: rgba(255, 158, 59, 0.04);
|
||||
border-radius: 0.5rem;
|
||||
padding: 0.75rem;
|
||||
display: flex;
|
||||
flex-direction: column;
|
||||
gap: 0.75rem;
|
||||
}
|
||||
.hermes-kanban-recovery-title {
|
||||
font-weight: 600;
|
||||
font-size: 0.8125rem;
|
||||
}
|
||||
.hermes-kanban-recovery-hint {
|
||||
font-size: 0.75rem;
|
||||
color: var(--color-muted-foreground, #888);
|
||||
line-height: 1.35;
|
||||
}
|
||||
.hermes-kanban-recovery-section {
|
||||
display: flex;
|
||||
flex-direction: column;
|
||||
gap: 0.35rem;
|
||||
}
|
||||
.hermes-kanban-recovery-label {
|
||||
font-size: 0.75rem;
|
||||
color: var(--color-muted-foreground, #888);
|
||||
}
|
||||
.hermes-kanban-recovery-input,
|
||||
.hermes-kanban-recovery-select {
|
||||
padding: 0.25rem 0.4rem;
|
||||
font-size: 0.8125rem;
|
||||
background: rgba(0, 0, 0, 0.15);
|
||||
border: 1px solid rgba(120, 120, 140, 0.3);
|
||||
border-radius: 0.3rem;
|
||||
color: inherit;
|
||||
outline: none;
|
||||
}
|
||||
.hermes-kanban-recovery-action-row {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: 0.5rem;
|
||||
flex-wrap: wrap;
|
||||
}
|
||||
.hermes-kanban-recovery-action-label {
|
||||
font-size: 0.8125rem;
|
||||
font-weight: 600;
|
||||
min-width: 8rem;
|
||||
}
|
||||
.hermes-kanban-recovery-action-desc {
|
||||
flex: 1;
|
||||
font-size: 0.75rem;
|
||||
color: var(--color-muted-foreground, #888);
|
||||
}
|
||||
.hermes-kanban-recovery-btn {
|
||||
padding: 0.25rem 0.7rem;
|
||||
font-size: 0.75rem;
|
||||
background: rgba(255, 158, 59, 0.15);
|
||||
border: 1px solid rgba(255, 158, 59, 0.4);
|
||||
border-radius: 0.3rem;
|
||||
color: inherit;
|
||||
cursor: pointer;
|
||||
}
|
||||
.hermes-kanban-recovery-btn:hover:not(:disabled) {
|
||||
background: rgba(255, 158, 59, 0.25);
|
||||
}
|
||||
.hermes-kanban-recovery-btn:disabled {
|
||||
opacity: 0.4;
|
||||
cursor: not-allowed;
|
||||
}
|
||||
.hermes-kanban-recovery-reassign-row {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: 0.5rem;
|
||||
flex-wrap: wrap;
|
||||
}
|
||||
.hermes-kanban-recovery-checkbox {
|
||||
font-size: 0.75rem;
|
||||
display: inline-flex;
|
||||
align-items: center;
|
||||
gap: 0.25rem;
|
||||
}
|
||||
.hermes-kanban-recovery-cmd-row {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: 0.5rem;
|
||||
flex-wrap: wrap;
|
||||
}
|
||||
.hermes-kanban-recovery-cmd {
|
||||
font-family: ui-monospace, SFMono-Regular, monospace;
|
||||
font-size: 0.75rem;
|
||||
padding: 0.2rem 0.5rem;
|
||||
background: rgba(0, 0, 0, 0.2);
|
||||
border: 1px solid rgba(120, 120, 140, 0.3);
|
||||
border-radius: 0.3rem;
|
||||
flex: 1;
|
||||
min-width: 10rem;
|
||||
overflow-x: auto;
|
||||
white-space: nowrap;
|
||||
}
|
||||
.hermes-kanban-recovery-msg {
|
||||
font-size: 0.75rem;
|
||||
padding: 0.35rem 0.5rem;
|
||||
border-radius: 0.3rem;
|
||||
}
|
||||
.hermes-kanban-recovery-msg--ok {
|
||||
background: rgba(120, 200, 120, 0.12);
|
||||
color: #6bc46b;
|
||||
border: 1px solid rgba(120, 200, 120, 0.3);
|
||||
}
|
||||
.hermes-kanban-recovery-msg--err {
|
||||
background: rgba(255, 107, 107, 0.12);
|
||||
color: #ff8b8b;
|
||||
border: 1px solid rgba(255, 107, 107, 0.3);
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue