mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-09 08:21:50 +00:00
feat: config structure validation — detect malformed YAML at startup (#5426)
Add validate_config_structure() that catches common config.yaml mistakes: - custom_providers as dict instead of list (missing '-' in YAML) - fallback_model accidentally nested inside another section - custom_providers entries missing required fields (name, base_url) - Missing model section when custom_providers is configured - Root-level keys that look like misplaced custom_providers fields Surface these diagnostics at three levels: 1. Startup: print_config_warnings() runs at CLI and gateway module load, so users see issues before hitting cryptic errors 2. Error time: 'Unknown provider' errors in auth.py and model_switch.py now include config diagnostics with fix suggestions 3. Doctor: 'hermes doctor' shows a Config Structure section with all issues and fix hints Also adds a warning log in runtime_provider.py when custom_providers is a dict (previously returned None silently). Motivated by a Discord user who had malformed custom_providers YAML and got only 'Unknown Provider' with no guidance on what was wrong. 17 new tests covering all validation paths.
This commit is contained in:
parent
9ca954a274
commit
dce5f51c7c
8 changed files with 443 additions and 9 deletions
|
|
@ -711,6 +711,32 @@ def deactivate_provider() -> None:
|
|||
# Provider Resolution — picks which provider to use
|
||||
# =============================================================================
|
||||
|
||||
|
||||
def _get_config_hint_for_unknown_provider(provider_name: str) -> str:
|
||||
"""Return a helpful hint string when provider resolution fails.
|
||||
|
||||
Checks for common config.yaml mistakes (malformed custom_providers, etc.)
|
||||
and returns a human-readable diagnostic, or empty string if nothing found.
|
||||
"""
|
||||
try:
|
||||
from hermes_cli.config import validate_config_structure
|
||||
issues = validate_config_structure()
|
||||
if not issues:
|
||||
return ""
|
||||
|
||||
lines = ["Config issue detected — run 'hermes doctor' for full diagnostics:"]
|
||||
for ci in issues:
|
||||
prefix = "ERROR" if ci.severity == "error" else "WARNING"
|
||||
lines.append(f" [{prefix}] {ci.message}")
|
||||
# Show first line of hint
|
||||
first_hint = ci.hint.splitlines()[0] if ci.hint else ""
|
||||
if first_hint:
|
||||
lines.append(f" → {first_hint}")
|
||||
return "\n".join(lines)
|
||||
except Exception:
|
||||
return ""
|
||||
|
||||
|
||||
def resolve_provider(
|
||||
requested: Optional[str] = None,
|
||||
*,
|
||||
|
|
@ -757,10 +783,14 @@ def resolve_provider(
|
|||
if normalized in PROVIDER_REGISTRY:
|
||||
return normalized
|
||||
if normalized != "auto":
|
||||
raise AuthError(
|
||||
f"Unknown provider '{normalized}'.",
|
||||
code="invalid_provider",
|
||||
)
|
||||
# Check for common config.yaml issues that cause this error
|
||||
_config_hint = _get_config_hint_for_unknown_provider(normalized)
|
||||
msg = f"Unknown provider '{normalized}'."
|
||||
if _config_hint:
|
||||
msg += f"\n\n{_config_hint}"
|
||||
else:
|
||||
msg += " Check 'hermes model' for available providers, or run 'hermes doctor' to diagnose config issues."
|
||||
raise AuthError(msg, code="invalid_provider")
|
||||
|
||||
# Explicit one-off CLI creds always mean openrouter/custom
|
||||
if explicit_api_key or explicit_base_url:
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue