From dcc8de83a95b0bf1b89cea95f3d2b4ca42c1bb1f Mon Sep 17 00:00:00 2001 From: olegdater Date: Fri, 1 May 2026 10:09:38 +0400 Subject: [PATCH] feat(codex): add gpt-5.3-codex-spark model --- hermes_cli/codex_models.py | 2 ++ tests/hermes_cli/test_codex_models.py | 10 ++++++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/hermes_cli/codex_models.py b/hermes_cli/codex_models.py index e39b2c5943b..8ff2dd60a89 100644 --- a/hermes_cli/codex_models.py +++ b/hermes_cli/codex_models.py @@ -16,6 +16,7 @@ DEFAULT_CODEX_MODELS: List[str] = [ "gpt-5.4-mini", "gpt-5.4", "gpt-5.3-codex", + "gpt-5.3-codex-spark", "gpt-5.2-codex", "gpt-5.1-codex-max", "gpt-5.1-codex-mini", @@ -26,6 +27,7 @@ _FORWARD_COMPAT_TEMPLATE_MODELS: List[tuple[str, tuple[str, ...]]] = [ ("gpt-5.4-mini", ("gpt-5.3-codex", "gpt-5.2-codex")), ("gpt-5.4", ("gpt-5.3-codex", "gpt-5.2-codex")), ("gpt-5.3-codex", ("gpt-5.2-codex",)), + ("gpt-5.3-codex-spark", ("gpt-5.3-codex", "gpt-5.2-codex")), ] diff --git a/tests/hermes_cli/test_codex_models.py b/tests/hermes_cli/test_codex_models.py index 949d1c8e239..821558a1413 100644 --- a/tests/hermes_cli/test_codex_models.py +++ b/tests/hermes_cli/test_codex_models.py @@ -54,7 +54,7 @@ def test_get_codex_model_ids_falls_back_to_curated_defaults(tmp_path, monkeypatc assert models[: len(DEFAULT_CODEX_MODELS)] == DEFAULT_CODEX_MODELS assert "gpt-5.4" in models - assert "gpt-5.3-codex-spark" not in models + assert "gpt-5.3-codex-spark" in models def test_get_codex_model_ids_adds_forward_compat_models_from_templates(monkeypatch): @@ -65,7 +65,13 @@ def test_get_codex_model_ids_adds_forward_compat_models_from_templates(monkeypat models = get_codex_model_ids(access_token="codex-access-token") - assert models == ["gpt-5.2-codex", "gpt-5.4-mini", "gpt-5.4", "gpt-5.3-codex"] + assert models == [ + "gpt-5.2-codex", + "gpt-5.4-mini", + "gpt-5.4", + "gpt-5.3-codex", + "gpt-5.3-codex-spark", + ] def test_model_command_uses_runtime_access_token_for_codex_list(monkeypatch):