From dc7a20cb0e28e37e5d27efa1bd75f68b5873dc07 Mon Sep 17 00:00:00 2001
From: ethernet <arilotter@gmail.com>
Date: Thu, 16 Jul 2026 16:03:51 -0400
Subject: [PATCH] ci(js-autofix): skip apply-patch job when no fixes found
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

generate-patch now emits a has-fixes job output (true/false).
apply-patch is gated on it via `if: needs.generate-patch.outputs.has-fixes == 'true'`,
so when `npm run fix` produces no diff, the privileged job is skipped
entirely — no runner allocation, no redundant checkout/download/push/PR.
---
 .github/workflows/js-autofix.yml | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/.github/workflows/js-autofix.yml b/.github/workflows/js-autofix.yml
index ed0cd58abf76..38494abd0e38 100644
--- a/.github/workflows/js-autofix.yml
+++ b/.github/workflows/js-autofix.yml
@@ -29,6 +29,7 @@ name: auto-fix lint issues & formatting
 #      bot/js-autofix branch, creates/updates a PR, and enables auto-merge.
 #      This job never runs npm, never installs anything, never executes any
 #      repo code. The only input it trusts is the patch artifact.
+#      Skipped entirely when generate-patch reports no fixes (has-fixes != true).
 #      The PR auto-merges (squash) once CI passes. If CI fails or main moves,
 #      the PR is auto-closed and the branch deleted — the next run re-applies
 #      on the current state.
@@ -58,6 +59,8 @@ jobs:
     name: Generate eslint --fix patch
     runs-on: ubuntu-latest
     timeout-minutes: 5
+    outputs:
+      has-fixes: ${{ steps.produce-patch.outputs.has-fixes }}
     # No permissions override → inherits workflow-level contents: read.
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -80,13 +83,16 @@ jobs:
         run: npm run fix
 
       - name: Produce patch
+        id: produce-patch
         run: |
           if git diff --quiet; then
             echo "No fixes needed."
+            echo "has-fixes=false" >> "$GITHUB_OUTPUT"
             # Empty patch signals "nothing to do" to apply-patch.
             : > js-fix.patch
           else
             git diff > js-fix.patch
+            echo "has-fixes=true" >> "$GITHUB_OUTPUT"
             echo "Patch size: $(wc -c < js-fix.patch) bytes"
 
             # Reject patches that touch anything outside JS/TS/JSON sources.
@@ -111,6 +117,9 @@ jobs:
   apply-patch:
     name: Apply patch
     needs: generate-patch
+    # Skip entirely when generate-patch found no fixes — saves a runner,
+    # avoids a redundant checkout/download, and keeps the job graph honest.
+    if: needs.generate-patch.outputs.has-fixes == 'true'
     runs-on: ubuntu-latest
     timeout-minutes: 15
     permissions: