mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-07-20 15:33:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

fix(dashboard): correct approvals.mode select options

Browse source 
The web UI CONFIG_SCHEMA showed ['ask', 'yolo', 'deny'] for the
approvals.mode select field. These don't match any real config values
and 'smart' mode was entirely unreachable from the dashboard.

Correct the options to ['manual', 'smart', 'off'] which match the
values defined and documented in hermes_cli/config.py.

Adds a regression test to TestBuildSchemaFromConfig to pin the correct
option names and guard against future drift.

Fixes #31925
This commit is contained in:
Robert Blaas 2026-05-25 07:52:07 +00:00 • committed by Teknium
parent 7b5ba20547
commit da6d6164ba
2 changed files with 21 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
hermes_cli/web_server.py
View file

@ -671,7 +671,7 @@ _SCHEMA_OVERRIDES: Dict[str, Dict[str, Any]] = {
"approvals.mode": {
"type": "select",
"description": "Dangerous command approval mode",
"options": ["ask", "yolo", "deny"],
"options": ["manual", "smart", "off"],
},
"context.engine": {
"type": "select",

20
tests/hermes_cli/test_web_server.py
View file

@ -3539,6 +3539,26 @@ class TestBuildSchemaFromConfig:
assert "options" in entry
assert "local" in entry["options"]
def test_approvals_mode_options_match_config_values(self):
"""approvals.mode select options must match the values accepted by config.py.
Previously the dashboard showed ['ask', 'yolo', 'deny'] which are stale
names that don't correspond to any real config value. The correct values
are 'manual', 'smart', and 'off' (see hermes_cli/config.py).
'smart' was missing entirely, making it unreachable from the UI.
"""
from hermes_cli.web_server import CONFIG_SCHEMA
entry = CONFIG_SCHEMA["approvals.mode"]
assert entry["type"] == "select"
options = entry["options"]
assert "manual" in options, "'manual' missing from approvals.mode options"
assert "smart" in options, "'smart' missing from approvals.mode options"
assert "off" in options, "'off' missing from approvals.mode options"
# Stale names that were previously shown but don't match config values
assert "ask" not in options, "stale option 'ask' should not appear"
assert "yolo" not in options, "stale option 'yolo' should not appear"
assert "deny" not in options, "stale option 'deny' should not appear"
def test_empty_prefix_produces_correct_keys(self):
from hermes_cli.web_server import _build_schema_from_config
test_config = {"model": "test", "nested": {"key": "val"}}