refactor(bootstrap): consolidate ACP browser bootstrap into install.{sh,ps1} (#27851)

* refactor(bootstrap): consolidate ACP browser bootstrap into install.{sh,ps1}

Delete 687 lines of duplicated browser bootstrap code from
acp_adapter/bootstrap/. All browser installation now routes through
dep_ensure -> install.{sh,ps1} --ensure, using agent-browser install
for Chromium. install.sh gains ensure_browser() with macOS app-bundle
detection and per-distro guidance.

Tracking: #27826

* fix(install.sh): add --ignore-scripts to npm install for camofox

@askjo/camofox-browser has a dependency (impit) whose postinstall
script runs `npx only-allow pnpm`, which fails under npm. Adding
--ignore-scripts avoids the spurious failure without affecting
functionality.

Tracking: #27826

* fix: add explicit return in ensure_browser, narrow exception in entry.py

ensure_browser() now returns 0 explicitly on all success paths.
_run_setup_browser() catches OSError instead of broad Exception,
letting ImportError propagate as a real packaging bug.

scripts/install.sh

@@ -1512,6 +1512,17 @@ find_system_browser() {
         fi
     done
 
+    if [ "$(uname)" = "Darwin" ]; then
+        for app in \
+            "/Applications/Google Chrome.app/Contents/MacOS/Google Chrome" \
+            "/Applications/Chromium.app/Contents/MacOS/Chromium"; do
+            if [ -x "$app" ]; then
+                echo "$app"
+                return 0
+            fi
+        done
+    fi
+
     return 1
 }
 
@@ -1534,10 +1545,15 @@ configure_browser_env_from_system_browser() {
         browser_path="$(find_system_browser 2>/dev/null || true)"
     fi
 
-    if [ -z "$browser_path" ] || [ ! -f "$env_file" ]; then
+    if [ -z "$browser_path" ]; then
         return 0
     fi
 
+    mkdir -p "$HERMES_HOME"
+    if [ ! -f "$env_file" ]; then
+        touch "$env_file"
+    fi
+
     if grep -q '^AGENT_BROWSER_EXECUTABLE_PATH=' "$env_file" 2>/dev/null; then
         log_info "AGENT_BROWSER_EXECUTABLE_PATH already configured"
         return 0
@@ -1888,6 +1904,73 @@ print_success() {
     fi
 }
 
+ensure_browser() {
+    if ! command -v node >/dev/null 2>&1; then
+        local node_bin="$HERMES_HOME/node/bin/node"
+        if [ -x "$node_bin" ]; then
+            export PATH="$HERMES_HOME/node/bin:$PATH"
+        else
+            log_error "Node.js not found. Run with --ensure node first."
+            return 1
+        fi
+    fi
+
+    local npm_bin
+    npm_bin="$(command -v npm 2>/dev/null || echo "$HERMES_HOME/node/bin/npm")"
+    if [ ! -x "$npm_bin" ]; then
+        log_error "npm not found"
+        return 1
+    fi
+
+    log_info "Installing agent-browser..."
+    local log_file
+    log_file="$(mktemp)"
+    if ! "$npm_bin" install -g --prefix "$HERMES_HOME/node" --silent --ignore-scripts \
+        "agent-browser@^0.26.0" \
+        "@askjo/camofox-browser@^1.5.2" \
+        >"$log_file" 2>&1; then
+        log_error "npm install failed:"
+        cat "$log_file" >&2
+        rm -f "$log_file"
+        return 1
+    fi
+    rm -f "$log_file"
+    export PATH="$HERMES_HOME/node/bin:$PATH"
+
+    local sys_browser
+    sys_browser="$(find_system_browser 2>/dev/null || true)"
+    if [ -n "$sys_browser" ]; then
+        configure_browser_env_from_system_browser "$sys_browser"
+        log_info "System browser detected -- skipping Chromium download"
+        return 0
+    fi
+
+    log_info "Installing Chromium via agent-browser install..."
+    local ab_bin="$HERMES_HOME/node/bin/agent-browser"
+    if [ -x "$ab_bin" ]; then
+        "$ab_bin" install 2>/dev/null || {
+            log_warn "Chromium install failed. Browser tools may not work without a system browser."
+
+            # OS-specific hints (detect_os sets $DISTRO)
+            case "${DISTRO:-unknown}" in
+                ubuntu|debian)
+                    log_info "Try: sudo apt-get install -y chromium-browser"
+                    ;;
+                arch)
+                    log_info "Try: sudo pacman -S chromium"
+                    ;;
+                fedora|rhel|centos)
+                    log_info "Try: sudo dnf install -y chromium"
+                    ;;
+            esac
+        }
+    else
+        log_warn "agent-browser not found at $ab_bin"
+    fi
+
+    return 0
+}
+
 ensure_mode() {
     detect_os
 
@@ -1901,19 +1984,7 @@ ensure_mode() {
             browser)
                 check_node
                 if [ "$HAS_NODE" = true ]; then
-                    DETECTED_BROWSER_EXECUTABLE="$(find_system_browser 2>/dev/null || true)"
-                    if [ -z "$DETECTED_BROWSER_EXECUTABLE" ]; then
-                        log_info "Installing agent-browser + Chromium..."
-                        npm_bin="$(command -v npm 2>/dev/null || echo "")"
-                        if [ -n "$npm_bin" ]; then
-                            local agent_browser_dir="$HERMES_HOME/node_modules"
-                            mkdir -p "$agent_browser_dir"
-                            "$npm_bin" install --prefix "$HERMES_HOME" agent-browser 2>/dev/null || true
-                            npx playwright install chromium 2>/dev/null || true
-                        fi
-                    else
-                        log_success "System browser found: $DETECTED_BROWSER_EXECUTABLE"
-                    fi
+                    ensure_browser
                 fi
                 ;;
             ripgrep)
@@ -1948,16 +2019,7 @@ postinstall_mode() {
     install_system_packages
 
     if [ "$HAS_NODE" = true ] && [ "$SKIP_BROWSER" = false ]; then
-        DETECTED_BROWSER_EXECUTABLE="$(find_system_browser 2>/dev/null || true)"
-        if [ -z "$DETECTED_BROWSER_EXECUTABLE" ]; then
-            log_info "Installing browser engine..."
-            npm_bin="$(command -v npm 2>/dev/null || echo "")"
-            if [ -n "$npm_bin" ]; then
-                npx playwright install chromium 2>/dev/null || true
-            fi
-        else
-            log_success "System browser found: $DETECTED_BROWSER_EXECUTABLE"
-        fi
+        ensure_browser
     fi
 
     HERMES_CMD="$(command -v hermes 2>/dev/null || echo "")"