mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-04-26 01:01:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix: preserve legacy approval keys after pattern key migration

Browse source
This commit is contained in:
teknium1 2026-03-14 22:10:39 -07:00
parent 4a93cfd889
commit d5b64ebdb3
2 changed files with 48 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

16
tests/tools/test_approval.py
View file

@ -2,12 +2,14 @@
from unittest.mock import patch as mock_patch
import tools.approval as approval_module
from tools.approval import (
approve_session,
clear_session,
detect_dangerous_command,
has_pending,
is_approved,
load_permanent,
pop_pending,
prompt_dangerous_approval,
submit_pending,
@ -368,6 +370,20 @@ class TestPatternKeyUniqueness:
)
clear_session(session)
def test_legacy_find_key_still_approves_find_exec(self):
"""Old allowlist entry 'find' should keep approving the matching command."""
_, key_exec, _ = detect_dangerous_command("find . -exec rm {} \\;")
with mock_patch.object(approval_module, "_permanent_approved", set()):
load_permanent({"find"})
assert is_approved("legacy-find", key_exec) is True
def test_legacy_find_key_still_approves_find_delete(self):
"""Old colliding allowlist entry 'find' should remain backwards compatible."""
_, key_delete, _ = detect_dangerous_command("find . -name '*.tmp' -delete")
with mock_patch.object(approval_module, "_permanent_approved", set()):
load_permanent({"find"})
assert is_approved("legacy-find", key_delete) is True
class TestViewFullCommand:
"""Tests for the 'view full command' option in prompt_dangerous_approval."""