mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-07-14 14:12:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix: protect cron output root from cleanup

Browse source 
Only classify files below cron/output/ as disposable cron output.
The cron/output directory itself is a durable container for retained
job history and should not be tracked or deleted wholesale.

Add regression coverage for both category detection and cleanup of a
stale tracked entry pointing at the output root.
This commit is contained in:
martinramos002-bot 2026-06-19 16:23:28 -05:00 • committed by kshitij
parent 7f71a48a3a
commit d173e8c3a7
2 changed files with 37 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
plugins/disk-cleanup/disk_cleanup.py
View file

@ -166,9 +166,11 @@ def _is_protected_cron_path(p: Path) -> bool:
"""Return True if *p* is a cron control-plane file/directory that must
never be deleted.
This only matches the directory itself and known control-plane files
(``jobs.json``, ``.tick.lock``) — it does NOT blanket-protect
everything under ``cron/`` because ``cron/output/`` is disposable.
This only matches the directory itself, known control-plane files
(``jobs.json``, ``.tick.lock``), and the ``output/`` root directory.
It does NOT blanket-protect files under ``cron/output/`` because those
run artifacts are disposable, but deleting the output root itself is too
broad and can erase every job's retained run history at once.
"""
# Lazily build the set once per process so HERMES_HOME is resolved
# exactly once.
@ -177,6 +179,7 @@ def _is_protected_cron_path(p: Path) -> bool:
for parent in ("cron", "cronjobs"):
base = hermes_home / parent
_PROTECTED_CRON_PATHS.add(str(base))
_PROTECTED_CRON_PATHS.add(str(base / "output"))
_PROTECTED_CRON_PATHS.add(str(base / "jobs.json"))
_PROTECTED_CRON_PATHS.add(str(base / ".tick.lock"))
resolved = str(p.resolve())
@ -566,7 +569,7 @@ def guess_category(path: Path) -> Optional[str]:
# (e.g. ``jobs.json``, ``.tick.lock``) must never be
# auto-tracked — deleting it wipes the live scheduler
# registry. See issue #32164.
if len(rel.parts) >= 2 and rel.parts[1] == "output":
if len(rel.parts) >= 3 and rel.parts[1] == "output":
return "cron-output"
return None
if top == "cache":